[Discover] Prevent error message of read only user without default index pattern set

[kertal]

Summary

Given there's no default index pattern set and a read only user accesses Discover, he'll get the error message: "Unable to update UI setting"

Discover tries to set and persist a new default index pattern. But without permissions, this fails.
This PR extends the ensureDefaultIndexPattern function with a persist flag, so Discover can get a default index pattern without persisting it.

Testing

1. Create a readonly role and user for discover.
2. Go to Advanced Settings and remove the default index pattern.
3. Login with this user and go to discover.

Without this PR you should get the error message.

Fixes #46124

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[flash1293]

@elasticmachine merge upstream

[flash1293]

There are a bunch of calls to this in visualize and dashboard as well:

src/legacy/core_plugins/kibana/public/visualize/np_ready/legacy_app.js
30:  ensureDefaultIndexPattern,
88:            ensureDefaultIndexPattern(deps.core, deps.data, $rootScope, kbnUrl),
100:            ensureDefaultIndexPattern(deps.core, deps.data, $rootScope, kbnUrl),
126:            return ensureDefaultIndexPattern(core, data, $rootScope, kbnUrl)
149:            return ensureDefaultIndexPattern(core, data, $rootScope, kbnUrl)

src/legacy/core_plugins/kibana/public/dashboard/np_ready/legacy_app.js
26:  ensureDefaultIndexPattern,
136:            return ensureDefaultIndexPattern(deps.core, deps.npDataStart, $rootScope, kbnUrl).then(
176:            return ensureDefaultIndexPattern(deps.core, deps.npDataStart, $rootScope, kbnUrl)
196:            return ensureDefaultIndexPattern(deps.core, deps.npDataStart, $rootScope, kbnUrl)

Wouldn't they have the same problem? And if they do and we also need to set persist to false we can remove the logic of actually setting the default index pattern because it's never safe to call it. Additionally we could try to set in the settings and just hide the error (not sure whether that's possible). Also we should check whether there are any calls that depend on a default index pattern after the ensureDefaultIndexPattern check. So far this could always be assumed.

[kertal]

thx @flash1293 for you review, I'll do research about visualize & dashboard, we might not need this kind of persistence, and what is better than adding code? removing code 💇‍♂

[kertal]

@elasticmachine merge upstream

[flash1293]

Tested and works as expected, default index pattern is not set automatically anymore but no failures with readonly users. LGTM besides my comment above and @lizozom s remark.

[lizozom]

@kertal do we still want to merge this?

[kertal]

@kertal do we still want to merge this?

currently no, but I will have a closer look at it this week

[kertal]

@elasticmachine merge upstream

[kertal]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 8841766

History

• 💚 Build #52305 succeeded 14147f0
• 💚 Build #51906 succeeded 94af312
• 💔 Build #51732 failed 3e468f9
• 💔 Build #41549 failed 65691e0072b94e398af0a7db610010a64e65919d
• 💔 Build #40337 failed 8e0199f110c7f87301bec67be80a4f225f17c96f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[alexnelson-es]

How do I determine which Kibana release will have this fix?

[alexnelson-es]

I upgraded to the last OpenDistro release (1.13.1.0) and the problem still exists.
When I login as a readonly user, I get the (scary for my users) message about the 403 forbidden.
I do have a default index created.
I guess I'll file another ticket.