Clear cache when index pattern is deleted#63220
Closed
kertal wants to merge 4 commits intoelastic:masterfrom
Closed
Clear cache when index pattern is deleted#63220kertal wants to merge 4 commits intoelastic:masterfrom
kertal wants to merge 4 commits intoelastic:masterfrom
Conversation
…-10-clearCache-when-index-pattern-is-removed
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/dashboard·ts.Dashboard create dashboard buttonStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/dashboard·ts.Dashboard "after all" hook for "Open flight dashboard"Standard OutStack TraceKibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/dashboard·ts.Dashboard create dashboard buttonStandard OutStack Traceand 1 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
Contributor
|
@kertal It seems like this PR overlaps with #63329 The test failure is happening because there is an additional delay introduced when switching to a new dashboard because the index pattern check now requires a network roundtrip. In my PR I moved this check to the app mounting to limit the number of times this has to happen. |
Member
Author
|
@flash1293 thanks a lot! this saves me a lot of time, was just wondering why this was failing. |
Member
Author
|
After syncing with @flash1293, closing it in favor of #63329 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cache containing the index patterns wasn't cleanup up, when an index pattern was removed in management. This caused problems in Discover: When the previously selected index pattern was deleted, there was an exception in Discover's rendering. This PR cleans up the cache when an index pattern is deleted in management, and furthermore, it triggers a refresh of the in the
ensureDefaultIndexPatternfunction used by Discover/Virtualize/Dashboard.Fixes: #63180, #62269
Checklist