Skip to content

[SIEM] New Platform Saved Objects Registration#64029

Merged
rylnd merged 4 commits intoelastic:masterfrom
rylnd:siem_saved_objects_registration
Apr 21, 2020
Merged

[SIEM] New Platform Saved Objects Registration#64029
rylnd merged 4 commits intoelastic:masterfrom
rylnd:siem_saved_objects_registration

Conversation

@rylnd
Copy link
Contributor

@rylnd rylnd commented Apr 21, 2020 •
edited
Loading

Summary

Similar to #64015, this is a precursor to the client NP migration (#45831); it moves the savedObjects mappings out of the legacy plugin startup (legacy/siem/index.ts) and into the NP server plugin.

This is a little noisier than it needs to be as I also took the opportunity to remove widespread usage of the RuleStatus SavedObject type and instead replace those raw SO calls with the (existing) ruleStatusSavedObjectClient. If necessary, I can move that commit (6d600cb) to a separate PR. Regardless, here is the diff without that commit.

For maintainers

rylnd added 3 commits April 20, 2020 18:50
@rylnd
WIP: Register saved objects types in NP
3470076 
This works, but responsibilities are spread around. Refactor incoming.
@rylnd
Moves new SO definitions into corresponding folders
0808144 
This way our top-level file still acts as the index, but these are
more/less unconnected if/when we split these out into separate
applications.
@rylnd
Replace raw SO updates with our ruleStatusSavedObjectsClient
6d600cb 
This mainly consolidates the SO type name and the attributes type to a single
file so that we don't have to import both any time we want to work with
RuleStatus SavedObjects.
@rylnd rylnd added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 21, 2020
@rylnd rylnd self-assigned this Apr 21, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 21, 2020

Pinging @elastic/siem (Team:SIEM)

rylnd
rylnd commented Apr 21, 2020
View reviewed changes
x-pack/plugins/siem/server/lib/detection_engine/rule_actions/saved_object_mappings.ts
},
params: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
dynamic: true as any,
Copy link
Contributor Author

@rylnd rylnd Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrykkopycinski FYI this isn't officially supported by New Platform; you can see here that it's a special case for UI Settings. If this is/was a temporary thing, perhaps we can make it a little more strict, nw?

@rylnd rylnd marked this pull request as ready for review April 21, 2020 14:24
@rylnd rylnd requested a review from a team as a code owner April 21, 2020 14:24
FrankHassanabad
FrankHassanabad approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks great 👍

@rylnd rylnd mentioned this pull request Apr 21, 2020
Closed
@rylnd
Merge branch 'master' into siem_saved_objects_registration
596f3f1 
 Conflicts:
	x-pack/legacy/plugins/siem/index.ts
	x-pack/plugins/siem/server/plugin.ts
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 21, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd merged commit 592a0ff into elastic:master Apr 21, 2020
@rylnd rylnd deleted the siem_saved_objects_registration branch April 21, 2020 20:33
rylnd added a commit to rylnd/kibana that referenced this pull request Apr 21, 2020
@rylnd
[SIEM] New Platform Saved Objects Registration (elastic#64029)
d142664 
* WIP: Register saved objects types in NP

This works, but responsibilities are spread around. Refactor incoming.

* Moves new SO definitions into corresponding folders

This way our top-level file still acts as the index, but these are
more/less unconnected if/when we split these out into separate
applications.

* Replace raw SO updates with our ruleStatusSavedObjectsClient

This mainly consolidates the SO type name and the attributes type to a single
file so that we don't have to import both any time we want to work with
RuleStatus SavedObjects.
@rylnd rylnd mentioned this pull request Apr 21, 2020
Merged
rylnd added a commit that referenced this pull request Apr 21, 2020
@rylnd
[SIEM] New Platform Saved Objects Registration (#64029) (#64115)
4b4cd31 
* WIP: Register saved objects types in NP

This works, but responsibilities are spread around. Refactor incoming.

* Moves new SO definitions into corresponding folders

This way our top-level file still acts as the index, but these are
more/less unconnected if/when we split these out into separate
applications.

* Replace raw SO updates with our ruleStatusSavedObjectsClient

This mainly consolidates the SO type name and the attributes type to a single
file so that we don't have to import both any time we want to work with
RuleStatus SavedObjects.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 22, 2020
@gmmorris
Merge branch 'master' into alerting/no-explicit-any
02077cc 
* master: (29 commits)
  [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611)
  refactor action filter creation utils (elastic#62969)
  Refresh index pattern list before redirecting (elastic#63329)
  [APM]fixing custom link unit tests (elastic#64045)
  [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103)
  [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033)
  [Maps] Map settings: min and max zoom (elastic#63714)
  [kbn-storybook] Use raw loader for text files (elastic#64108)
  [EPM] /packages/{package} endpoint to support upgrades (elastic#63629)
  [SIEM] New Platform Saved Objects Registration (elastic#64029)
  [Endpoint] Hook to handle events needing navigation via Router (elastic#63863)
  Fixed small issue in clone functionality (elastic#64085)
  [Endpoint]EMT-146: use ingest agent for status info (elastic#63921)
  [SIEM] Server NP Followup (elastic#64010)
  Register uiSettings on New Platform (elastic#64015)
  [Reporting] Integration polling config with client code (elastic#63754)
  [Docs]7.7 SIEM doc updates (elastic#63951)
  [SIEM] [Cases] Tags suggestions (elastic#63878)
  Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027)
  [DOCS] Add file size setting for Data Visualizer (elastic#64006)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 22, 2020
@gmmorris
Merge branch 'task-manager/cancel-logging' of github.com:gmmorris/kib…
c3b9f64 
…ana into task-manager/cancel-logging

* 'task-manager/cancel-logging' of github.com:gmmorris/kibana: (28 commits)
  [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611)
  refactor action filter creation utils (elastic#62969)
  Refresh index pattern list before redirecting (elastic#63329)
  [APM]fixing custom link unit tests (elastic#64045)
  [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103)
  [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033)
  [Maps] Map settings: min and max zoom (elastic#63714)
  [kbn-storybook] Use raw loader for text files (elastic#64108)
  [EPM] /packages/{package} endpoint to support upgrades (elastic#63629)
  [SIEM] New Platform Saved Objects Registration (elastic#64029)
  [Endpoint] Hook to handle events needing navigation via Router (elastic#63863)
  Fixed small issue in clone functionality (elastic#64085)
  [Endpoint]EMT-146: use ingest agent for status info (elastic#63921)
  [SIEM] Server NP Followup (elastic#64010)
  Register uiSettings on New Platform (elastic#64015)
  [Reporting] Integration polling config with client code (elastic#63754)
  [Docs]7.7 SIEM doc updates (elastic#63951)
  [SIEM] [Cases] Tags suggestions (elastic#63878)
  Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027)
  [DOCS] Add file size setting for Data Visualizer (elastic#64006)
  ...
@rylnd rylnd mentioned this pull request Apr 23, 2020
Merged
1 task
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 23, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spong spong Awaiting requested review from spong

@XavierM XavierM Awaiting requested review from XavierM

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

1 more reviewer

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rylnd rylnd

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rylnd @elasticmachine @kibanamachine @FrankHassanabad @MindyRS