[Endpoint] Hook to handle events needing navigation via Router by paul-tavares · Pull Request #63863 · elastic/kibana

paul-tavares · 2020-04-17T15:28:01Z

Summary

Added a new react hook (useNavigateByRouterEventHandler()) that provides a common callback for handing click events that are meant to navigate to a page via the router's history.push
Refactored several components to use new hook

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…t-router-click-handler-hook

…r hook

elasticmachine · 2020-04-17T15:28:03Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

elasticmachine · 2020-04-17T15:28:04Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

…t-router-click-handler-hook

oatkiller · 2020-04-20T15:22:56Z

...ins/endpoint/public/applications/endpoint/view/hooks/use_navigate_by_router_event_handler.ts

+  routeTo: string | [string, unknown] | LocationDescriptorObject<unknown>, // Cover the calling signature of `history.push()`
+
+  /** Additional onClick callback */
+  onClick?: EventHandlerCallback


Maybe you could add a type parameter to this hook like: TargetElement extends HTMLButtonElement | HTMLAnchorElement
and then define onClick like: onClick?: MouseEventHandler<TargetElement> and then the return type of the hook could be MouseEventHandler<TargetElement>

I think this would allow onClick to have button or link specific logic (if needed)

🤔 isn't that the same that I already have defined above in the EventHandlerCallback type?

I don't see the difference here with what @paul-tavares did vs @oatkiller suggestion. Maybe we could reuse TargetElement if we defined it outside of the the generic types for MouseEventHandler. But we could do that later if needed

oatkiller · 2020-04-20T15:25:11Z

x-pack/plugins/endpoint/public/applications/endpoint/view/policy/policy_details.test.tsx

      expect(history.location.pathname).toEqual('/policy/1');
-      backToListButton.simulate('click');
+      backToListButton.simulate('click', { button: 0 });
+      await sleep();


is this sleep necessary?

Seems like a mistake/typo on my part. Will remove it. Thanks

kibanamachine · 2020-04-20T17:25:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7c2572e

History

💚 Build #41889 succeeded d863ed7
💔 Build #41591 failed 42a0af6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ic#63863) * new hook providing generic event handler for use with react router * Refactor of Header Naviagtion to use useNavigateByRouterEventHandler * Policy list refactor to use useNavigateByRouterEventHandler hook * Policy list Policy name link to use useNavigateByRouterEventHandler hook * Host list use of useNavigateByRouteEventHandler

… (#64113) * new hook providing generic event handler for use with react router * Refactor of Header Naviagtion to use useNavigateByRouterEventHandler * Policy list refactor to use useNavigateByRouterEventHandler hook * Policy list Policy name link to use useNavigateByRouterEventHandler hook * Host list use of useNavigateByRouteEventHandler

* master: (29 commits) [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611) refactor action filter creation utils (elastic#62969) Refresh index pattern list before redirecting (elastic#63329) [APM]fixing custom link unit tests (elastic#64045) [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103) [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033) [Maps] Map settings: min and max zoom (elastic#63714) [kbn-storybook] Use raw loader for text files (elastic#64108) [EPM] /packages/{package} endpoint to support upgrades (elastic#63629) [SIEM] New Platform Saved Objects Registration (elastic#64029) [Endpoint] Hook to handle events needing navigation via Router (elastic#63863) Fixed small issue in clone functionality (elastic#64085) [Endpoint]EMT-146: use ingest agent for status info (elastic#63921) [SIEM] Server NP Followup (elastic#64010) Register uiSettings on New Platform (elastic#64015) [Reporting] Integration polling config with client code (elastic#63754) [Docs]7.7 SIEM doc updates (elastic#63951) [SIEM] [Cases] Tags suggestions (elastic#63878) Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027) [DOCS] Add file size setting for Data Visualizer (elastic#64006) ...

…ana into task-manager/cancel-logging * 'task-manager/cancel-logging' of github.com:gmmorris/kibana: (28 commits) [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611) refactor action filter creation utils (elastic#62969) Refresh index pattern list before redirecting (elastic#63329) [APM]fixing custom link unit tests (elastic#64045) [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103) [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033) [Maps] Map settings: min and max zoom (elastic#63714) [kbn-storybook] Use raw loader for text files (elastic#64108) [EPM] /packages/{package} endpoint to support upgrades (elastic#63629) [SIEM] New Platform Saved Objects Registration (elastic#64029) [Endpoint] Hook to handle events needing navigation via Router (elastic#63863) Fixed small issue in clone functionality (elastic#64085) [Endpoint]EMT-146: use ingest agent for status info (elastic#63921) [SIEM] Server NP Followup (elastic#64010) Register uiSettings on New Platform (elastic#64015) [Reporting] Integration polling config with client code (elastic#63754) [Docs]7.7 SIEM doc updates (elastic#63951) [SIEM] [Cases] Tags suggestions (elastic#63878) Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027) [DOCS] Add file size setting for Data Visualizer (elastic#64006) ...

paul-tavares added 8 commits April 16, 2020 13:22

new hook providing generic event handler for use with react router

0b144da

Refactor of Header Naviagtion to use useNavigateByRouterEventHandler

e8e799c

Policy list refactor to use useNavigateByRouterEventHandler hook

4643efe

Policy list Policy name link to use useNavigateByRouterEventHandler hook

bac8e2c

Host list use of useNavigateByRouteEventHandler

87d72af

Added test plan for new hook

f718e05

Merge remote-tracking branch 'upstream/master' into task/EMT-230-reac…

535b196

…t-router-click-handler-hook

Refactor latest Host components to use useNavigateByRouterEventHandle…

42a0af6

…r hook

paul-tavares added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.8.0 labels Apr 17, 2020

paul-tavares self-assigned this Apr 17, 2020

paul-tavares added 3 commits April 17, 2020 15:35

Fix test cases for policy details

a2f5b8d

Finish tests for router event handler hook

585b511

Merge remote-tracking branch 'upstream/master' into task/EMT-230-reac…

d863ed7

…t-router-click-handler-hook

paul-tavares requested review from kevinlog, oatkiller and parkiino and removed request for kevinlog and oatkiller April 20, 2020 14:51

paul-tavares marked this pull request as ready for review April 20, 2020 14:52

paul-tavares requested a review from a team as a code owner April 20, 2020 14:52

oatkiller reviewed Apr 20, 2020

View reviewed changes

remove unnecessary sleep from test

7c2572e

paul-tavares requested review from kevinlog and oatkiller April 21, 2020 12:31

kevinlog approved these changes Apr 21, 2020

View reviewed changes

paul-tavares merged commit ed91275 into elastic:master Apr 21, 2020

paul-tavares deleted the task/EMT-230-react-router-click-handler-hook branch April 21, 2020 20:30

paul-tavares mentioned this pull request Apr 21, 2020

[7.x] [Endpoint] Hook to handle events needing navigation via Router (#63863) #64113

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Endpoint] Hook to handle events needing navigation via Router#63863

[Endpoint] Hook to handle events needing navigation via Router#63863
paul-tavares merged 12 commits intoelastic:masterfrom
paul-tavares:task/EMT-230-react-router-click-handler-hook

paul-tavares commented Apr 17, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Apr 17, 2020

Uh oh!

elasticmachine commented Apr 17, 2020

Uh oh!

oatkiller Apr 20, 2020

Uh oh!

paul-tavares Apr 20, 2020

Uh oh!

kevinlog Apr 21, 2020

Uh oh!

oatkiller Apr 20, 2020

Uh oh!

paul-tavares Apr 20, 2020

Uh oh!

kibanamachine commented Apr 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

paul-tavares commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Apr 17, 2020

Uh oh!

elasticmachine commented Apr 17, 2020

Uh oh!

oatkiller Apr 20, 2020

Choose a reason for hiding this comment

Uh oh!

paul-tavares Apr 20, 2020

Choose a reason for hiding this comment

Uh oh!

kevinlog Apr 21, 2020

Choose a reason for hiding this comment

Uh oh!

oatkiller Apr 20, 2020

Choose a reason for hiding this comment

Uh oh!

paul-tavares Apr 20, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 20, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

paul-tavares commented Apr 17, 2020 •

edited

Loading