[Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately#62772
Merged
gmmorris merged 15 commits intoelastic:masterfrom Apr 8, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
* master: (36 commits) [data.search.aggs] Remove service getters from agg types (elastic#61628) fixing APM internationalization (elastic#62757) fix: 🐛 correctly create error on no_matching_indices (elastic#61257) [Lens] Remove all legacy imports (elastic#62596) Add label for ace editor (elastic#62588) [ML] Show better file structure finder explanations (elastic#62316) Fix old pathes in eslintrc (elastic#62580) [Uptime] Improve Telemetry test (elastic#62428) [SIEM] Adds sort rules Cypress test (elastic#62700) [Uptime]Abstracted 'access:uptime-read' tag into a wrapper for… (elastic#62576) fixing bug (elastic#62577) [Maps] Allow updating requestType for ESGeoGridSource (elastic#62365) [Maps] do not show circle border when symbol size is zero (elastic#62644) [Maps] Always show current zoom level (elastic#62684) bc5 siem rules merge (elastic#62679) Revert "[Monitoring] Cluster state watch to Kibana alerting (elastic#61685)" Fix visual tests (elastic#62660) [Telemetry] update crypto packages (elastic#62469) [DOCS] Removed references to left (elastic#60807) [Maps] Move layers to np maps (elastic#61877) ...
mikecote
approved these changes
Apr 7, 2020
Contributor
mikecote
left a comment
There was a problem hiding this comment.
LGTM, pulled down locally, ran and tested a few different scenarios and it works.
Due to trying to have this merged / backported for 7.7.0, if the feedback would cause a re-trigger of CI, I'm ok seeing it done in another PR.
x-pack/plugins/triggers_actions_ui/public/application/components/health_check.tsx
Show resolved
Hide resolved
...k/plugins/triggers_actions_ui/public/application/components/prompts/action_needed_prompt.tsx
Outdated
Show resolved
Hide resolved
...lugins/triggers_actions_ui/public/application/components/prompts/empty_connectors_prompt.tsx
Outdated
Show resolved
Hide resolved
...lugins/triggers_actions_ui/public/application/components/prompts/empty_connectors_prompt.tsx
Outdated
Show resolved
Hide resolved
...lugins/triggers_actions_ui/public/application/components/prompts/empty_connectors_prompt.tsx
Outdated
Show resolved
Hide resolved
...lugins/triggers_actions_ui/public/application/components/prompts/empty_connectors_prompt.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/triggers_actions_ui/public/application/components/prompts/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/triggers_actions_ui/public/application/components/prompts/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/triggers_actions_ui/public/application/components/prompts/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
pmuellr
approved these changes
Apr 7, 2020
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
code LGTM; starting in on some live testing of the code
* master: [APM] Change custom link from EuiListGroupItem to EuiLink (elastic#62742) [Remote Clusters] Update callout and move server_name field (elastic#62352) Removes Pitch Presentation Template from Canvas (elastic#62688) FTR: Enable w3c for chromedriver (elastic#62542) [ML] Disable functional tests [ILM] Skip failing API integration test (elastic#62779) [SIEM] Update beat doc (elastic#61902) [Search] Properly add slash preceding path in async search (elastic#62722) [APM] make sure environment query is correct for service maps… (elastic#62764) Add service map icon for rum-js agent type (elastic#62721) [APM] Service map - fixes irrelevant services on data refresh (elastic#62750) [APM] Service map - Fix taxi edge arrow orientation (elastic#62741) [APM] Prevent error rate alert trigger from rendering NaN (elastic#62754) [EPM] Store map visualizations from the package registry and use saved object ID (elastic#62059) [Alerting] for email action, set tls.rejectUnauthorized: false when secure: false (elastic#62380)
Contributor
andreadelrio
requested changes
Apr 7, 2020
Contributor
andreadelrio
left a comment
There was a problem hiding this comment.
Please see comment about adjusting padding for EncryptionError
Contributor
Author
|
@andreadelrio done 👌 applied to all of them. |
Made mixin less specific and added class to target body
andreadelrio
approved these changes
Apr 8, 2020
Contributor
andreadelrio
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making those changes.
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/custom_elements·ts.Canvas app custom elements deletes custom element when promptedStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 8, 2020
…g and hides alerting UI appropriately (elastic#62772) Removes the Security flyout and instead replaces the Alerting List, Connectors List and Alert Flyout with suitable messaging. Verifies that a permanent Encryption Key has been configured and if it hasn't displays a suitable warning in place, or along side the TLS warning, as needed.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 8, 2020
…g and hides alerting UI appropriately (elastic#62772) Removes the Security flyout and instead replaces the Alerting List, Connectors List and Alert Flyout with suitable messaging. Verifies that a permanent Encryption Key has been configured and if it hasn't displays a suitable warning in place, or along side the TLS warning, as needed.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 9, 2020
…chore/put-all-xjson-together * 'master' of github.com:elastic/kibana: (35 commits) [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013) [SIEM][Detection Engine] Fix rule notification critical bugs Add Error Exception Type Column (elastic#59596) [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282) [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772) FTR: add chromium-based Edge browser support (elastic#61684) [Ingest] Data source configuration validation UI (elastic#61180) restore empty_kibana after saved objects test (elastic#62951) Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594) Add basic StatusService (elastic#60335) [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720) [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887) Exclude disabled datasources and streams from agent config (elastic#62869) [Alerting] Fix validation support for nested IErrorObjects (elastic#62833) [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837) Add --filter option to API docs script (elastic#62888) [Maps] fix attribution overflow with exit full screen button (elastic#62699) [Uptime]Alerting UI text in case filter is selected (elastic#62570) [Maps] Show create filter button for top-term tooltip property (elastic#62461) skip flaky suite (elastic#59030) ... # Conflicts: # src/plugins/es_ui_shared/public/index.ts
gmmorris
added a commit
that referenced
this pull request
Apr 9, 2020
…g and hides alerting UI appropriately (#62772) (#63064) Removes the Security flyout and instead replaces the Alerting List, Connectors List and Alert Flyout with suitable messaging. Verifies that a permanent Encryption Key has been configured and if it hasn't displays a suitable warning in place, or along side the TLS warning, as needed.
gmmorris
added a commit
that referenced
this pull request
Apr 9, 2020
…g and hides alerting UI appropriately (#62772) (#63065) Removes the Security flyout and instead replaces the Alerting List, Connectors List and Alert Flyout with suitable messaging. Verifies that a permanent Encryption Key has been configured and if it hasn't displays a suitable warning in place, or along side the TLS warning, as needed.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 9, 2020
* master: (40 commits) [ML] Functional transform tests - stabilize source selection (elastic#63087) add embed flag to saved object url as well (elastic#62926) [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013) [SIEM][Detection Engine] Fix rule notification critical bugs Add Error Exception Type Column (elastic#59596) [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282) [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772) FTR: add chromium-based Edge browser support (elastic#61684) [Ingest] Data source configuration validation UI (elastic#61180) restore empty_kibana after saved objects test (elastic#62951) Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594) Add basic StatusService (elastic#60335) [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720) [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887) Exclude disabled datasources and streams from agent config (elastic#62869) [Alerting] Fix validation support for nested IErrorObjects (elastic#62833) [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837) Add --filter option to API docs script (elastic#62888) [Maps] fix attribution overflow with exit full screen button (elastic#62699) [Uptime]Alerting UI text in case filter is selected (elastic#62570) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
Removes the Security flyout and instead replaces the Alerting List, Connectors List and Alert Flyout with suitable messaging.
Verifies that a permanent Encryption Key has been configured and if it hasn't displays a suitable warning in place, or along side the TLS warning, as needed.
closes #61885
closes #62595
Checklist
Delete any items that are not applicable to this PR.
Documentation was added for features that require explanation or tutorialsFor maintainers