[APM] Change custom link from EuiListGroupItem to EuiLink#62742
Merged
cauemarcondes merged 1 commit intoelastic:masterfrom Apr 7, 2020
Merged
[APM] Change custom link from EuiListGroupItem to EuiLink#62742cauemarcondes merged 1 commit intoelastic:masterfrom
cauemarcondes merged 1 commit intoelastic:masterfrom
Conversation
cauemarcondes
added
release_note:skip
cauemarcondes
force-pushed
the
custom-link-62655
branch
from
886d346 to
fc87abb
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
dgieselaar
reviewed
Apr 7, 2020
| transaction: Transaction; | ||
| }) => ( | ||
| <SectionLinks> | ||
| <ul> |
Contributor
There was a problem hiding this comment.
Should this change not be made in the shared SectionLinks component?
Contributor
Author
There was a problem hiding this comment.
I agreed, but due to the deadline of the release I thought to do it here, and create a new issue to replace it later on SectionLinks, WDYT?
dgieselaar
approved these changes
Apr 7, 2020
Contributor
dgieselaar
left a comment
dgieselaar
left a comment
There was a problem hiding this comment.
Got a question, but other than that looks good.
Contributor
|
Sounds good to me, might want to raise that in the observability group in
case it's an issue for them as well.
Op di 7 apr. 2020 17:16 schreef Cauê Marcondes <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In
x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/CustomLink/CustomLinkSection.tsx
<#62742 (comment)>:
> @@ -19,7 +31,7 @@ export const CustomLinkSection = ({
customLinks: CustomLink[];
transaction: Transaction;
}) => (
- <SectionLinks>
+ <ul>
I agreed, but due to the deadline of the release I thought to do it here,
and create a new issue to replace it later on SectionLinks, WDYT?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#62742 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACWDXHGHFSUAN7NPA7VXSDRLM7URANCNFSM4MC5LDCA>
.
|
Contributor
Author
I can do it, but the reason why I moved to EuiLink was because of external links. They only use it to internal links |
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Apr 7, 2020
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Apr 7, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 7, 2020
* master: [APM] Change custom link from EuiListGroupItem to EuiLink (elastic#62742) [Remote Clusters] Update callout and move server_name field (elastic#62352) Removes Pitch Presentation Template from Canvas (elastic#62688) FTR: Enable w3c for chromedriver (elastic#62542) [ML] Disable functional tests [ILM] Skip failing API integration test (elastic#62779) [SIEM] Update beat doc (elastic#61902) [Search] Properly add slash preceding path in async search (elastic#62722) [APM] make sure environment query is correct for service maps… (elastic#62764) Add service map icon for rum-js agent type (elastic#62721) [APM] Service map - fixes irrelevant services on data refresh (elastic#62750) [APM] Service map - Fix taxi edge arrow orientation (elastic#62741) [APM] Prevent error rate alert trigger from rendering NaN (elastic#62754) [EPM] Store map visualizations from the package registry and use saved object ID (elastic#62059) [Alerting] for email action, set tls.rejectUnauthorized: false when secure: false (elastic#62380)
cauemarcondes
added a commit
that referenced
this pull request
Apr 7, 2020
cauemarcondes
added a commit
that referenced
this pull request
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #62655