Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin by mattkime · Pull Request #62594 · elastic/kibana

mattkime · 2020-04-06T11:45:30Z

Summary

Create Index Pattern Management plugin -

Moves existing legacy management API to new platform - used to for rollup index pattern functionality.

Part of #51322

Checklist

Delete any items that are not applicable to this PR.

~~[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support]~~(https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
~~[ ] Documentation was added for features that require explanation or tutorials~~
~~[ ] Unit or functional tests were updated or added to match the most common scenarios~~
~~[ ] This was checked for keyboard-only and screenreader accessibility~~
~~[ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser~~
~~[ ] This was checked for cross-browser compatibility, including a check against IE11~~

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-04-07T03:15:14Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_to_space_flyout.tsx

flash1293

Rollup client changes LGTM, only code review. Thanks for prioritizing ❤️

streamich

Code changes LGTM.

alexwizp · 2020-04-07T15:07:13Z

x-pack/legacy/plugins/rollup/kibana.json

    "home",
    "index_management",
-    "metrics"
+    "metrics",


Please make sure before merge that the next PR was not merged: #62543

src/plugins/index_pattern_management/public/service/index_pattern_management_service.ts

cjcenizal

Rollup Jobs code LGTM. Didn't test locally.

mattkime · 2020-04-08T01:00:37Z

@elasticmachine merge upstream

mattkime · 2020-04-08T03:10:18Z

@elasticmachine merge upstream

azasypkin

LGTM, just two minor leftovers, thanks!

...plugins/spaces/public/copy_saved_objects_to_space/components/copy_to_space_flyout_footer.tsx

x-pack/plugins/spaces/public/copy_saved_objects_to_space/summarize_copy_result.test.ts

…nents/copy_to_space_flyout_footer.tsx Co-Authored-By: Aleh Zasypkin <aleh.zasypkin@gmail.com>

…rize_copy_result.test.ts Co-Authored-By: Aleh Zasypkin <aleh.zasypkin@gmail.com>

…o index_pattern_plugin

kibanamachine · 2020-04-08T19:59:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 434f4c1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…=> new platform plugin (elastic#62594) * implement index pattern management plugin in new platform

…=> new platform plugin (#62594) (#63019) * implement index pattern management plugin in new platform

…chore/put-all-xjson-together * 'master' of github.com:elastic/kibana: (35 commits) [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013) [SIEM][Detection Engine] Fix rule notification critical bugs Add Error Exception Type Column (elastic#59596) [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282) [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772) FTR: add chromium-based Edge browser support (elastic#61684) [Ingest] Data source configuration validation UI (elastic#61180) restore empty_kibana after saved objects test (elastic#62951) Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594) Add basic StatusService (elastic#60335) [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720) [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887) Exclude disabled datasources and streams from agent config (elastic#62869) [Alerting] Fix validation support for nested IErrorObjects (elastic#62833) [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837) Add --filter option to API docs script (elastic#62888) [Maps] fix attribution overflow with exit full screen button (elastic#62699) [Uptime]Alerting UI text in case filter is selected (elastic#62570) [Maps] Show create filter button for top-term tooltip property (elastic#62461) skip flaky suite (elastic#59030) ... # Conflicts: # src/plugins/es_ui_shared/public/index.ts

* master: (40 commits) [ML] Functional transform tests - stabilize source selection (elastic#63087) add embed flag to saved object url as well (elastic#62926) [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013) [SIEM][Detection Engine] Fix rule notification critical bugs Add Error Exception Type Column (elastic#59596) [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282) [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772) FTR: add chromium-based Edge browser support (elastic#61684) [Ingest] Data source configuration validation UI (elastic#61180) restore empty_kibana after saved objects test (elastic#62951) Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594) Add basic StatusService (elastic#60335) [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720) [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887) Exclude disabled datasources and streams from agent config (elastic#62869) [Alerting] Fix validation support for nested IErrorObjects (elastic#62833) [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837) Add --filter option to API docs script (elastic#62888) [Maps] fix attribution overflow with exit full screen button (elastic#62699) [Uptime]Alerting UI text in case filter is selected (elastic#62570) ...

mattkime added 6 commits April 4, 2020 22:14

implement index pattern management plugin in new platform

b2e35b9

Merge branch 'master' into index_pattern_plugin

ec7636c

remove comment

0033c65

cleanup, fix index pattern creation

31a25ba

improve function naames, fix karma, i18n

5902b6d

Merge branch 'master' into index_pattern_plugin

fec9171

mattkime changed the title ~~Index pattern plugin~~ Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin Apr 6, 2020

mattkime changed the title ~~Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin~~ Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin Apr 6, 2020

mattkime added 2 commits April 6, 2020 16:07

fix start interface, i18n

14014d4

fix test and remove unused dependency

bf492e8

mattkime added the Team:AppArch label Apr 7, 2020

mattkime added v7.8.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Apr 7, 2020

mattkime marked this pull request as ready for review April 7, 2020 04:14

mattkime requested review from a team as code owners April 7, 2020 04:14

mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages labels Apr 7, 2020

mattkime mentioned this pull request Apr 7, 2020

Index pattern management UI -> TypeScript and New Platform Ready #51322

Closed

16 tasks

azasypkin reviewed Apr 7, 2020

View reviewed changes

x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_to_space_flyout.tsx Outdated Show resolved Hide resolved

flash1293 approved these changes Apr 7, 2020

View reviewed changes

streamich approved these changes Apr 7, 2020

View reviewed changes

fix imports

1d05dbd

alexwizp reviewed Apr 7, 2020

View reviewed changes

fix imports

5fc2e8e

alexwizp reviewed Apr 7, 2020

View reviewed changes

src/plugins/index_pattern_management/public/service/index_pattern_management_service.ts Outdated Show resolved Hide resolved

elastic deleted a comment from kibanamachine Apr 7, 2020

cjcenizal self-requested a review April 7, 2020 18:50

cjcenizal approved these changes Apr 7, 2020

View reviewed changes

Merge branch 'master' into index_pattern_plugin

4ca1bb5

Merge branch 'master' into index_pattern_plugin

fb33aba

azasypkin approved these changes Apr 8, 2020

View reviewed changes

...plugins/spaces/public/copy_saved_objects_to_space/components/copy_to_space_flyout_footer.tsx Outdated Show resolved Hide resolved

x-pack/plugins/spaces/public/copy_saved_objects_to_space/summarize_copy_result.test.ts Outdated Show resolved Hide resolved

ppisljar and others added 5 commits April 8, 2020 13:56

Update x-pack/plugins/spaces/public/copy_saved_objects_to_space/compo…

0a8e60a

…nents/copy_to_space_flyout_footer.tsx Co-Authored-By: Aleh Zasypkin <aleh.zasypkin@gmail.com>

Update x-pack/plugins/spaces/public/copy_saved_objects_to_space/summa…

ecae451

…rize_copy_result.test.ts Co-Authored-By: Aleh Zasypkin <aleh.zasypkin@gmail.com>

pass args through setup fn

4f915a5

Merge branch 'index_pattern_plugin' of github.com:mattkime/kibana int…

52b4292

…o index_pattern_plugin

bind plugin interfaces

434f4c1

elastic deleted a comment from kibanamachine Apr 8, 2020

mattkime merged commit e0a5194 into elastic:master Apr 8, 2020

mattkime mentioned this pull request Apr 8, 2020

[7.x] Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (#62594) #63019

Merged

mattkime added a commit to mattkime/kibana that referenced this pull request Apr 8, 2020

Index pattern management plugin - src/legacy/core_plugins/management …

ce33f0a

…=> new platform plugin (elastic#62594) * implement index pattern management plugin in new platform

mattkime added a commit that referenced this pull request Apr 8, 2020

Index pattern management plugin - src/legacy/core_plugins/management …

8cd9059

…=> new platform plugin (#62594) (#63019) * implement index pattern management plugin in new platform

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin#62594

Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin#62594
mattkime merged 17 commits intoelastic:masterfrom
mattkime:index_pattern_plugin

mattkime commented Apr 6, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Apr 7, 2020

Uh oh!

Uh oh!

flash1293 left a comment

Uh oh!

streamich left a comment

Uh oh!

alexwizp Apr 7, 2020

Uh oh!

Uh oh!

cjcenizal left a comment

Uh oh!

mattkime commented Apr 8, 2020

Uh oh!

mattkime commented Apr 8, 2020

Uh oh!

azasypkin left a comment

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Apr 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

mattkime commented Apr 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Apr 7, 2020

Uh oh!

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

streamich left a comment

Choose a reason for hiding this comment

Uh oh!

alexwizp Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

mattkime commented Apr 8, 2020

Uh oh!

mattkime commented Apr 8, 2020

Uh oh!

azasypkin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Apr 8, 2020

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mattkime commented Apr 6, 2020 •

edited

Loading