[Uptime]Abstracted 'access:uptime-read' tag into a wrapper for uptime rest routes #62576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
requested review from
andrewvc and
justinkambic
and removed request for
andrewvc
shahzad31
added
v7.7.0
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
andrewvc
reviewed
Apr 6, 2020
| return { | ||
| ...uptimeRoute, | ||
| options: { | ||
| tags: ['access:uptime-read', ...(uptimeRoute.options?.tags ?? [])], |
Contributor
There was a problem hiding this comment.
Since we only have two options read/write, maybe instead of adding arbitrary tags we can just add a accessWrite: true option or similar that adds access:uptime-write.
justinkambic
approved these changes
Apr 6, 2020
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
Pulled this down and tested locally, LGTM.
Testing summary
- loaded app locally and made sure everything was working
- created a role with Uptime readonly privileges, was not able to perform admin actions like changing index pattern or creating ML job
| const licenseCheckHandler: UMRouteHandler = async (customParams, context, request, response) => { | ||
| const { statusCode, message } = libs.license(context.licensing.license); | ||
| if (statusCode === 200) { | ||
| return await handler(customParams, context, request, response); |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Apr 7, 2020
…tic#62576) * abstract access headers * updated code
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 7, 2020
* master: (36 commits) [data.search.aggs] Remove service getters from agg types (elastic#61628) fixing APM internationalization (elastic#62757) fix: 🐛 correctly create error on no_matching_indices (elastic#61257) [Lens] Remove all legacy imports (elastic#62596) Add label for ace editor (elastic#62588) [ML] Show better file structure finder explanations (elastic#62316) Fix old pathes in eslintrc (elastic#62580) [Uptime] Improve Telemetry test (elastic#62428) [SIEM] Adds sort rules Cypress test (elastic#62700) [Uptime]Abstracted 'access:uptime-read' tag into a wrapper for… (elastic#62576) fixing bug (elastic#62577) [Maps] Allow updating requestType for ESGeoGridSource (elastic#62365) [Maps] do not show circle border when symbol size is zero (elastic#62644) [Maps] Always show current zoom level (elastic#62684) bc5 siem rules merge (elastic#62679) Revert "[Monitoring] Cluster state watch to Kibana alerting (elastic#61685)" Fix visual tests (elastic#62660) [Telemetry] update crypto packages (elastic#62469) [DOCS] Removed references to left (elastic#60807) [Maps] Move layers to np maps (elastic#61877) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: elastic/uptime#154
Abstracted 'access:uptime-read' tag into a wrapper for uptime rest routes.