[NP] Remove IndexedArray usage in Schemas by maryia-lapata · Pull Request #61410 · elastic/kibana

maryia-lapata · 2020-03-26T08:52:08Z

Part of #60098.

Remove IndexedArray usage in Schemas

elasticmachine · 2020-03-26T08:52:10Z

Pinging @elastic/kibana-app (Team:KibanaApp)

maryia-lapata · 2020-03-26T08:52:30Z

@elasticmachine merge upstream

elasticmachine · 2020-03-26T08:52:31Z

merge conflict between base and head

…xed-array # Conflicts: # src/legacy/core_plugins/visualizations/public/np_ready/public/vis.ts

maryia-lapata · 2020-03-26T15:30:10Z

@elasticmachine merge upstream

maryia-lapata · 2020-03-27T06:19:57Z

src/legacy/core_plugins/vis_default_editor/public/components/agg_group.tsx

 }: DefaultEditorAggGroupProps) {
  const groupNameLabel = (search.aggs.aggGroupNamesMap() as any)[groupName];
  // e.g. buckets can have no aggs
-  const schemaNames = getSchemasByGroup(schemas, groupName).map(s => s.name);


Here schemas has already contained schemas by group from groupName. So we don't need to get them again.

sulemanof

Tested locally in Chrome, works as expected! 👍
I would only adjust some types as recommended below 👇

sulemanof · 2020-03-31T08:58:41Z

src/legacy/core_plugins/vis_default_editor/public/schemas.ts

 export class Schemas {
-  // @ts-ignore
-  all: IndexedArray<Schema>;
+  all: Schema[] = [];


I would specify metrics & buckets here also.
Basically, this class should implements the ISchemas interface.

👍 Done.
Since now Schemas has the same properties as ISchemas has, I got rid of ISchemas.

hmm, AFAIK ISchemas was intentionally created to use an interface instead of class instance (there were a lot of places with such an approach, so all of interfaces starts with I ).
@flash1293 am I right?

@stacey-gammon When I remember correctly you started to remove the types separate to actual class implementations in some places, right? Do you know what the current best practices around this are?

For awhile we (app arch) were moving toward an I prefix convention in these scenarios, but have since stopped doing this in favor of waiting for type-only imports which are available in TS 3.8. I believe this is the approach the platform team is taking too.

In the meantime, for the cases where we need a separate type in the interim, we have been inconsistent, using I* in some places but not in others.

In that case I like the current solution, once TS 3.8 is merged, we can do a bulk change of the remaining places.

For those who want to follow along, here's the PR which is working toward upgrading TS in Kibana: #57774

Discussion here if you are interested on the I-prefix: #51674

src/legacy/core_plugins/vis_default_editor/public/schemas.ts

flash1293

Tested with various aggregation configurations (adding/removing) - everything seems to be there and working as intended - LGTM. Left some small nits about types in addition to Daniils remarks

src/legacy/core_plugins/vis_default_editor/public/components/agg_group.test.tsx

maryia-lapata · 2020-04-02T06:21:55Z

@elasticmachine merge upstream

kibanamachine · 2020-04-02T09:23:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b95165b

History

💚 Build #37751 succeeded 39f1b1d
💚 Build #37072 succeeded b495d47
💔 Build #37065 failed dfdd6be
💚 Build #36574 succeeded 0b46f76
💔 Build #36528 failed 307d727

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Remove IndexedArray usage from schemas.ts * Update unit tests * Revert default value * Update sidebar.tsx * Updated TS * Fix code review comments * Remove ISchemas * Revert ISchemas Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: Switch to embeddable factory interface with optional override (elastic#61165) fix text error in diagrams (elastic#62101) [Index management] Prepare support Index template V2 format (elastic#61588) Updates dashboard images (elastic#62011) [Maps] remove MapBounds type (elastic#62332) [Uptime] Convert anomaly Jobs name to lowercase to comply with… (elastic#62293) Make d3 place nicely with object values (elastic#62004) EMT-287: update schema with elastic agent id (elastic#62252) [Maps] fix replaceLayerList to handle case where map is not intialized (elastic#62202) Remove support for deprecated xpack.telemetry configurations (elastic#51142) [Uptime] Remove static constant for index name completely (elastic#62256) [APM] E2E: install dependencies for vanilla workspaces (elastic#62178) [backport] Bump to 5.1.3 (elastic#62286) Show server name in Remote Cluster detail panel (elastic#62250) Rename some alert types (elastic#61693) changing duration type to ms, s, m (elastic#62265) [ML] Clear Kibana index pattern cache on creation or form reset. (elastic#62184) Move `src/legacy/server/index_patterns` to data plugin (server) (Remove step) (elastic#61618) [NP] Remove IndexedArray usage in Schemas (elastic#61410)

maryia-lapata added 2 commits March 26, 2020 10:53

Remove IndexedArray usage from schemas.ts

7948112

Update unit tests

e89b8a4

maryia-lapata added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.8 labels Mar 26, 2020

maryia-lapata added 3 commits March 26, 2020 11:56

Merge remote-tracking branch 'remotes/kibana/master' into remove-inde…

f3fdb95

…xed-array # Conflicts: # src/legacy/core_plugins/visualizations/public/np_ready/public/vis.ts

Revert default value

7e86148

Update sidebar.tsx

307d727

flash1293 mentioned this pull request Mar 26, 2020

Clean up Kibana app shims #60098

Closed

8 tasks

Merge branch 'master' into remove-indexed-array

0b46f76

maryia-lapata requested review from flash1293 and sulemanof March 27, 2020 06:11

maryia-lapata marked this pull request as ready for review March 27, 2020 06:11

maryia-lapata requested a review from a team as a code owner March 27, 2020 06:11

maryia-lapata commented Mar 27, 2020

View reviewed changes

maryia-lapata added 2 commits March 30, 2020 12:00

Merge remote-tracking branch 'kibana/master' into remove-indexed-array

dfdd6be

Updated TS

b495d47

sulemanof approved these changes Mar 31, 2020

View reviewed changes

flash1293 approved these changes Mar 31, 2020

View reviewed changes

src/legacy/core_plugins/vis_default_editor/public/components/agg_group.test.tsx Outdated Show resolved Hide resolved

src/legacy/core_plugins/vis_default_editor/public/components/agg_group.test.tsx Outdated Show resolved Hide resolved

maryia-lapata added 3 commits April 1, 2020 08:46

Merge remote-tracking branch 'kibana/master' into remove-indexed-array

cc0afc3

Fix code review comments

97a875d

Remove ISchemas

39f1b1d

flash1293 added v7.8.0 and removed v7.8 labels Apr 1, 2020

elasticmachine and others added 2 commits April 2, 2020 02:22

Merge branch 'master' into remove-indexed-array

3084e2d

Revert ISchemas

b95165b

maryia-lapata merged commit b4fd1eb into elastic:master Apr 2, 2020

maryia-lapata deleted the remove-indexed-array branch April 2, 2020 09:31

maryia-lapata mentioned this pull request Apr 2, 2020

[7.x] [NP] Remove IndexedArray usage in Schemas (#61410) #62279

Merged

maryia-lapata added the backported label Apr 2, 2020

Conversation

maryia-lapata commented Mar 26, 2020

Uh oh!

elasticmachine commented Mar 26, 2020

Uh oh!

maryia-lapata commented Mar 26, 2020

Uh oh!

elasticmachine commented Mar 26, 2020

Uh oh!

maryia-lapata commented Mar 26, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sulemanof left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sulemanof Apr 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

maryia-lapata commented Apr 2, 2020

Uh oh!

kibanamachine commented Apr 2, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sulemanof Apr 1, 2020 •

edited

Loading