EMT-287: update schema with elastic agent id#62252
EMT-287: update schema with elastic agent id#62252nnamdifrankie merged 1 commit intoelastic:masterfrom
Conversation
nnamdifrankie
added
v7.8.0
v8.0.0
release_note:skip
💚 Build SucceededTo update your PR or re-run it, just comment with: |
| ]; | ||
|
|
||
| interface HostInfo { | ||
| elastic: { |
There was a problem hiding this comment.
Outside of the scope of this PR, but wanted to mention it:
It feels like the types/interfaces defined here and duplicated in types.ts should be combined so that they come from one single source.
There was a problem hiding this comment.
Outside of the scope of this PR, but wanted to mention it:
It feels like the types/interfaces defined here and duplicated in types.ts should be combined so that they come from one single source.
Well, some of these code was changed without my notice. In my view they are two different application that knows about each other and the use cases are different. For now it is fine to leave it separate but makes for some maintenance work.
There was a problem hiding this comment.
Yeah this type can be refactored with the types in types.ts soon, doesn't need to be in this PR though.
There was a problem hiding this comment.
I see the challenge now @marshallmain 😄. Unrelated to this PR, I just added a new generator method to the EndpointDocGenerator and attempted to reference a method/type from endpoint/public/ from this file and got an ESLint error. Some of our stuff inside of the /public/ folder may need to first be moved to this top-level location.
| "version": "6.6.1", | ||
| "name" : "Elastic Endpoint" | ||
| }, | ||
| "elastic": { |
There was a problem hiding this comment.
Question: did you update this es_archive manually? or did you use some sort of a tool that just add "stuff" to it?
There was a problem hiding this comment.
Question: did you update this es_archive manually? or did you use some sort of a tool that just add "stuff" to it?
Yes we have to make incremental changes to the data because the changes are relative, e.g. in this case all events for a particular endpoint should have the same elastic.agent.id. And we have to be backward compatible with other tests too.
There was a problem hiding this comment.
So I assume you updated the file manually?
There was a problem hiding this comment.
Yes, I updated manually.
|
One thing that I just remembered - does this impact the indexing changes/updates that @jonathan-buttner is doing to the endpoint package over at epm? |
Thanks @paul-tavares, yeah I made the changes in the endpoint package already 👍 |
* master: Switch to embeddable factory interface with optional override (elastic#61165) fix text error in diagrams (elastic#62101) [Index management] Prepare support Index template V2 format (elastic#61588) Updates dashboard images (elastic#62011) [Maps] remove MapBounds type (elastic#62332) [Uptime] Convert anomaly Jobs name to lowercase to comply with… (elastic#62293) Make d3 place nicely with object values (elastic#62004) EMT-287: update schema with elastic agent id (elastic#62252) [Maps] fix replaceLayerList to handle case where map is not intialized (elastic#62202) Remove support for deprecated xpack.telemetry configurations (elastic#51142) [Uptime] Remove static constant for index name completely (elastic#62256) [APM] E2E: install dependencies for vanilla workspaces (elastic#62178) [backport] Bump to 5.1.3 (elastic#62286) Show server name in Remote Cluster detail panel (elastic#62250) Rename some alert types (elastic#61693) changing duration type to ms, s, m (elastic#62265) [ML] Clear Kibana index pattern cache on creation or form reset. (elastic#62184) Move `src/legacy/server/index_patterns` to data plugin (server) (Remove step) (elastic#61618) [NP] Remove IndexedArray usage in Schemas (elastic#61410)
7 participants
Summary
https://github.com/elastic/endpoint-app-team/issues/287
Update data structures and mapping to add elastic agent id to the metadata document. Updated the tests.
Checklist