update to TypeScript v3.8-rc by mshustov · Pull Request #57774 · elastic/kibana

mshustov · 2020-02-17T08:50:51Z

Summary

This PR starts preparatory work to upgrade to TS v3.8. Changes: https://devblogs.microsoft.com/typescript/announcing-typescript-3-8-beta/

Blockers

External:

TypeScript 3.8 Syntax Support typescript-eslint/typescript-eslint#1436

Internal:

update prettier to v2 Support TypeScript 3.8 prettier/prettier#7263
update babel packages bump up babel version #61037
fix TS errors in apm plugin @elastic/apm-ui
[optional] update cytoscape & @types/cytoscape @elastic/apm-ui
fix TS errors in timelion plugin @elastic/kibana-app
fix SO type errors @elastic/kibana-platform force savedObject API consumers to define SO type explicitly #58022

For maintainers

This was checked for breaking API changes and was labeled appropriately

src/core/public/chrome/ui/header/header_badge.tsx

mshustov · 2020-02-17T09:54:50Z

x-pack/legacy/plugins/apm/cypress/package.json

    "p-limit": "^2.2.1",
    "ts-loader": "^6.1.0",
-    "typescript": "3.7.2",
+    "typescript": "3.8.1-rc",


@elastic/apm-ui I need your help here to fix APMRequestHandlerContext which type is inferred as any

@dgieselaar fyi

Looking into it!

@restrry I can't explain this - there's no reason I can see why this fails, and others don't. It feels like a TS bug, but I cannot pinpoint it.

btw - in my case, I don't see context as any, but the type for context.params is incorrect.

@sqren is context.params type correct in your case?

Hmm. It seems like it's not. On master I get this:

I think it might be related to the fact that Params interface contains optional props only.
When I remove an empty object default from

kibana/x-pack/plugins/apm/server/routes/create_route.ts

Line 12 in 96a0aa0

TParams extends Params = {}

TS starts inferring context type, but not params

I'm not here until Monday, and my only guess right now is that this is a TS bug (either in resolving or in showing an appropriate error). Can someone flag this with the TS team? If there's not much of a rush I can look into it Monday.

@dgieselaar take your time, we are blocked by external dependencies as well

mshustov · 2020-02-20T10:49:32Z

src/legacy/core_plugins/vis_type_timelion/public/components/panel.tsx

  const [chart, setChart] = useState(() => cloneDeep(seriesList.list));
-  const [canvasElem, setCanvasElem] = useState();
-  const [chartElem, setChartElem] = useState();
+  const [canvasElem, setCanvasElem] = useState<HTMLElement>();


the file still contains some type errors. @timroes @sulemanof could someone take a look and fix the errors, please?

mshustov · 2020-02-24T09:26:19Z

x-pack/dev-tools/jest/setup/setup_test.js

+import * as testingLibraryDom from '@testing-library/dom';
+
+testingLibraryDom.configure({
+  testIdAttribute: 'data-test-subj',


I got a bunch of type errors due to data-testid not being declared on EUI elements. Our component library shouldn't depend on 3rd party libraries naming conventions, so I reconfigured @testing-library to use Kibana specific data-test-subj attribute instead.

pgayvallet · 2020-02-24T12:29:32Z

packages/kbn-pm/package.json

    "strong-log-transformer": "^2.1.0",
    "tempy": "^0.3.0",
-    "typescript": "3.7.2",
+    "typescript": "3.8.2",


(Thinking) npm really need a maven-like pinable version management for multi-projects...

pgayvallet · 2020-02-24T12:31:37Z

x-pack/legacy/plugins/ml/public/application/settings/calendars/edit/new_calendar.test.js

    const wrapper = mountWithIntl(<NewCalendar {...props} />);

-    const importButton = wrapper.find('[data-testid="ml_new_event"]');
+    const importButton = wrapper.find('[data-test-subj="ml_new_event"]');


Just wondering, as these are JS files: Did you manually grep for data-testid to 'fix' that ?

x-pack/plugins/endpoint/public/applications/endpoint/view/alerts/index.test.tsx

pgayvallet · 2020-02-24T12:35:55Z

x-pack/plugins/infra/public/components/waffle/waffle_accounts_controls.tsx

 export const WaffleAccountsControls = (props: Props) => {
  const { accountId, options } = props;
-  const [isOpen, setIsOpen] = useState();
+  const [isOpen, setIsOpen] = useState<boolean>();


To understand, are these added explicits types are a requirement for the bump or only cleanup?

To understand, are these added explicits types are a requirement for the bump

yeah, it started showing error after TS version upgrade

kibanamachine · 2020-03-23T10:50:25Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: f13a261

History

💔 Build #30040 failed 9d51788
💔 Build #28426 failed 9d8c170
💔 Build #28389 failed 3e1e353
💔 Build #28383 failed 1c25e13
💔 Build #28366 failed fa4334f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jfsiii · 2020-05-05T12:05:50Z

Is this still in progress?

Worth noting 3.9 is an RC now and should be final in the next week or so.

mshustov · 2020-05-05T12:31:05Z

Is this still in progress?

Yes. We have to update prettier to v2 to support new syntax, which requires code style changes on the whole codebase. I will get back to work after FF.
prettier update PR #63735

Worth noting 3.9 is an RC now and should be final in the next week or so.

Yeah, but I'd prefer a gradual migration --> 3.8 --> 3.9 to minimize the amount of work.

mshustov · 2020-05-28T19:07:10Z

closed in favor of #67666

mshustov added 6 commits February 17, 2020 09:20

update package.json to v3.8

3018d18

fix security types

4bab0a5

fix eui types. TODO: update types in the library

b9016ff

fix http headers definition

34b069d

add explicit types

c62c8df

add explicit types in timelion

6c8c249

mshustov added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 17, 2020

mshustov commented Feb 17, 2020

View reviewed changes

src/core/public/chrome/ui/header/header_badge.tsx Outdated Show resolved Hide resolved

mshustov commented Feb 17, 2020

View reviewed changes

add @babel/plugin-proposal-export-namespace-from

f282992

mshustov mentioned this pull request Feb 17, 2020

Improve SavedObjectAttributes type #47334

Closed

mshustov added 2 commits February 20, 2020 11:00

Merge branch 'master' into ts-3.8-rc

647d2b7

fix and mute errors

c561ee4

mshustov commented Feb 20, 2020

View reviewed changes

mshustov added 4 commits February 24, 2020 08:52

use TS stable version

82fcfdc

Merge branch 'master' into ts-3.8-rc

fa4334f

declare SO type explicitly

1ab9894

use a common property data-test-subj as testid

1c25e13

mshustov commented Feb 24, 2020

View reviewed changes

fix undefined usestate

3e1e353

pgayvallet reviewed Feb 24, 2020

View reviewed changes

mshustov added 6 commits February 24, 2020 13:49

rebuild dist-pm

5fe5d5c

fix typo

9d8c170

Merge branch 'master' into ts-3.8-rc

b3489d9

update to 3.8.3

33d3f93

remove unnecessary ts directives

822b5bd

fix ml type error

9d51788

joshdover mentioned this pull request Mar 4, 2020

Use HTTP request schemas to create types, use those types in the client #59340

Merged

3 tasks

Merge branch 'master' into ts-3.8-rc

f13a261

mshustov mentioned this pull request Mar 24, 2020

bump up babel version #61037

Merged

mshustov added v7.8.0 and removed v7.7.0 labels Mar 24, 2020

lukeelmers mentioned this pull request Apr 2, 2020

[NP] Remove IndexedArray usage in Schemas #61410

Merged

mshustov added v7.9.0 and removed v7.8.0 labels May 15, 2020

mshustov closed this May 28, 2020

mshustov deleted the ts-3.8-rc branch May 28, 2020 19:07

Conversation

mshustov commented Feb 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Blockers

For maintainers

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mshustov Feb 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mshustov Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 23, 2020

💔 Build Failed

History

Uh oh!

jfsiii commented May 5, 2020

Uh oh!

mshustov commented May 5, 2020

Uh oh!

mshustov commented May 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mshustov commented Feb 17, 2020 •

edited

Loading

mshustov Feb 20, 2020 •

edited

Loading

mshustov Feb 24, 2020 •

edited

Loading