Move src/legacy/server/index_patterns to data plugin (server) (Remove step)#61618
Merged
VladLasitsa merged 6 commits intoelastic:masterfrom Apr 2, 2020
Merged
Conversation
alexwizp
requested changes
Mar 30, 2020
Contributor
alexwizp
left a comment
alexwizp
left a comment
There was a problem hiding this comment.
Looks LGTM! but we still have some references to indexPatternsServiceFactory
At least in these files:
src/legacy/server/saved_objects/saved_objects_mixin.test.js
x-pack/plugins/infra/server/lib/adapters/framework/adapter_types.ts
Contributor
Author
|
@elasticmachine merge upstream |
VladLasitsa
added
Feature:NP Migration
release_note:skip
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lizozom
approved these changes
Mar 31, 2020
weltenwort
approved these changes
Mar 31, 2020
Member
weltenwort
left a comment
weltenwort
left a comment
There was a problem hiding this comment.
infra changes LGTM, thank you
lukeelmers
approved these changes
Mar 31, 2020
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
Code changes LGTM (have not tested locally though).
Just one request: Could we add release_note:dev_docs to this with a few sentences describing the deprecation and directing folks to replace usages with IndexPatternsFetcher?
pgayvallet
approved these changes
Apr 1, 2020
Contributor
Author
|
@elasticmachine merge upstream |
VladLasitsa
added
the
release_note:plugin_api_changes
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
Apr 2, 2020
…ve step) (elastic#61618) * Removed legacy index pattern * fix type * remove unnecessary import * Removed old references to indexPatternsServiceFactory Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
VladLasitsa
added a commit
that referenced
this pull request
Apr 2, 2020
…ve step) (#61618) (#62280) * Removed legacy index pattern * fix type * remove unnecessary import * Removed old references to indexPatternsServiceFactory Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 2, 2020
* master: Switch to embeddable factory interface with optional override (elastic#61165) fix text error in diagrams (elastic#62101) [Index management] Prepare support Index template V2 format (elastic#61588) Updates dashboard images (elastic#62011) [Maps] remove MapBounds type (elastic#62332) [Uptime] Convert anomaly Jobs name to lowercase to comply with… (elastic#62293) Make d3 place nicely with object values (elastic#62004) EMT-287: update schema with elastic agent id (elastic#62252) [Maps] fix replaceLayerList to handle case where map is not intialized (elastic#62202) Remove support for deprecated xpack.telemetry configurations (elastic#51142) [Uptime] Remove static constant for index name completely (elastic#62256) [APM] E2E: install dependencies for vanilla workspaces (elastic#62178) [backport] Bump to 5.1.3 (elastic#62286) Show server name in Remote Cluster detail panel (elastic#62250) Rename some alert types (elastic#61693) changing duration type to ms, s, m (elastic#62265) [ML] Clear Kibana index pattern cache on creation or form reset. (elastic#62184) Move `src/legacy/server/index_patterns` to data plugin (server) (Remove step) (elastic#61618) [NP] Remove IndexedArray usage in Schemas (elastic#61410)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #44190
Summary
Delete src/legacy/server/index_patterns
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Dev docs
The legacy folder
src / legacy / server / index_patternshas been deleted due to the fact that we have already moved the corresponding code to the new platform.For more information on where to locate new platform
dataservices, please refer to the table of plugins for shared application services insrc/core/MIGRATION.md.