Remove support for deprecated xpack.telemetry configurations by epixa · Pull Request #51142 · elastic/kibana

epixa · 2019-11-20T01:32:39Z

In 7.5, we moved telemetry to OSS and dropped the xpack prefix for the
telemetry plugin configuration options. We deprecated the usage of the
xpack prefix so any existing usage would trigger a warning at startup.

In 8.0, we remove support for the deprecated xpack prefix configs for
telemetry.

Closes #51141

elasticmachine · 2019-11-20T01:32:40Z

Pinging @elastic/kibana-docs (Team:Docs)

elasticmachine · 2019-11-20T01:32:42Z

Pinging @elastic/kibana-stack-services (Team:Stack Services)

elasticmachine · 2019-11-20T02:56:48Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3e908f47c97d06ce731d0326c00f162d9b594544

Bamieh

We need to remove a few extra lines of code from the telemetry plugin and xpack_main before merging this on master.

epixa · 2019-11-20T11:53:11Z

@Bamieh Can you clarify? I'm not aware of the code you're referring to, but I'll go remove it if you point me in its direction.

epixa · 2019-11-20T11:56:44Z

@gchaps Can you help me out on this docs failure? I'm not sure how since this is simply adding a new section that doesn't link outward, but apparently it broke the stack upgrade docs?

gchaps · 2019-11-20T17:09:39Z

docs/migration/migrate_8_0.asciidoc

Because this content gets pulled into the Stack docs, the link needs to be formatted as follows:

{kibana-ref}/monitoring-settings-kb.html#monitoring-general-settings[telemetry.enabled]

Note: This link goes to the section heading because I was unable to get the link to telemetry.enabled to work. Also, linking to the section heading gives the reader more context.

@afharo i believe we need to address this one before merging.

yup! It's even failing the build. I'll work on it today...

I was wondering why we have that config parameter in the monitoring file instead of a specific doc file for telemetry where we can explain all the configuration properties.

Bamieh · 2019-11-20T20:44:07Z

@epixa I believe your comment is before our sync today where we've discussed these changes. If you still need me to write them in a comment please let me know.

elasticmachine · 2019-12-20T18:47:28Z

Pinging @elastic/pulse (Team:Pulse)

TinaHeiligers · 2020-03-05T16:32:31Z

@Bamieh Would you mind taking ownership of this task please? It's not urgent.

In 7.5, we moved telemetry to OSS and dropped the xpack prefix for the telemetry plugin configuration options. We deprecated the usage of the xpack prefix so any existing usage would trigger a warning at startup. In 8.0, we remove support for the deprecated xpack prefix configs for telemetry.

pgayvallet

LGTM for platform changes

…telemetry-config

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

gchaps

LGTM

Bamieh

@afharo we need to remove the telemetry configs from xpack_main:
x-pack/legacy/plugins/xpack_main/index.js

afharo · 2020-04-02T12:06:44Z

@Bamieh good call! I'm surprised it was there anyway... since that file enforces configPrefix: 'xpack.xpack_main', so the specified telemetry config would have the accumulated prefix xpack.xpack_main.telemetry.*.

Anyway... removed!

kibanamachine · 2020-04-02T13:42:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4c47e20

History

💚 Build #37929 succeeded bd7161a
💚 Build #37921 succeeded 5c9a2d4
💚 Build #37875 succeeded 10c9f7b
💚 Build #37174 succeeded fe8b9ea
💚 Build #35936 succeeded 56541ef

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Bamieh · 2020-04-02T14:26:08Z

@afharo it was needed to support the legacy config to be passed to the kibana configs.

Bamieh

LGTM

* master: Switch to embeddable factory interface with optional override (elastic#61165) fix text error in diagrams (elastic#62101) [Index management] Prepare support Index template V2 format (elastic#61588) Updates dashboard images (elastic#62011) [Maps] remove MapBounds type (elastic#62332) [Uptime] Convert anomaly Jobs name to lowercase to comply with… (elastic#62293) Make d3 place nicely with object values (elastic#62004) EMT-287: update schema with elastic agent id (elastic#62252) [Maps] fix replaceLayerList to handle case where map is not intialized (elastic#62202) Remove support for deprecated xpack.telemetry configurations (elastic#51142) [Uptime] Remove static constant for index name completely (elastic#62256) [APM] E2E: install dependencies for vanilla workspaces (elastic#62178) [backport] Bump to 5.1.3 (elastic#62286) Show server name in Remote Cluster detail panel (elastic#62250) Rename some alert types (elastic#61693) changing duration type to ms, s, m (elastic#62265) [ML] Clear Kibana index pattern cache on creation or form reset. (elastic#62184) Move `src/legacy/server/index_patterns` to data plugin (server) (Remove step) (elastic#61618) [NP] Remove IndexedArray usage in Schemas (elastic#61410)

kibanamachine · 2020-04-06T14:28:45Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 51142 or prevent reminders by adding the backport:skip label.

afharo · 2020-04-07T09:28:54Z

This is for 8.x. No need to backport it

elasticmachine · 2021-10-01T21:41:41Z

Pinging @elastic/kibana-core (Team:Core)

epixa added Team:Docs release_note:breaking Feature:Telemetry v8.0.0 Team:Stack Services labels Nov 20, 2019

epixa requested a review from a team November 20, 2019 01:33

Bamieh self-requested a review November 20, 2019 10:26

Bamieh requested changes Nov 20, 2019

View reviewed changes

gchaps reviewed Nov 20, 2019

View reviewed changes

epixa added Team:Pulse and removed DONOTUSETeam:Stack Services labels Dec 20, 2019

Bamieh self-assigned this Mar 17, 2020

afharo force-pushed the remove-xpack-telemetry-config branch from 3e908f4 to 4996348 Compare March 23, 2020 18:21

epixa requested a review from a team as a code owner March 23, 2020 18:21

afharo assigned afharo and unassigned Bamieh Mar 23, 2020

afharo requested a review from Bamieh March 23, 2020 18:24

pgayvallet approved these changes Mar 24, 2020

View reviewed changes

afharo added 3 commits March 24, 2020 17:51

Merge branch 'master' of github.com:elastic/kibana into remove-xpack-…

9388687

…telemetry-config

Move telemetry settings into its own document

daa7f29

Use external reference instead of anchor

56541ef

afharo and others added 9 commits April 1, 2020 18:57

Update docs/migration/migrate_8_0.asciidoc

5c9a2d4

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/settings/telemetry-settings.asciidoc

db1cff5

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/settings/telemetry-settings.asciidoc

bb929c6

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/settings/telemetry-settings.asciidoc

5c7cbc1

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/settings/telemetry-settings.asciidoc

11d0326

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/settings/telemetry-settings.asciidoc

297e3d7

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/settings/telemetry-settings.asciidoc

bebe783

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/settings/telemetry-settings.asciidoc

ef20e9a

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/settings/telemetry-settings.asciidoc

bd7161a

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

gchaps approved these changes Apr 1, 2020

View reviewed changes

Bamieh requested changes Apr 2, 2020

View reviewed changes

Remove depecrated xpack.telemetry.* config from xpack_main/index.js

4c47e20

Bamieh approved these changes Apr 2, 2020

View reviewed changes

afharo merged commit a729b3b into elastic:master Apr 2, 2020

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 6, 2020

afharo added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 7, 2020

afharo mentioned this pull request Apr 24, 2020

[Docs] Add telemetry docs to 7.x #64442

Closed

afharo mentioned this pull request Nov 3, 2020

[Breaking change] Move xpack.telemetry.* config to telemetry.* #82432

Closed

lukeelmers added the Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// label Oct 1, 2021

lukeelmers removed the Team:KibanaTelemetry label Oct 1, 2021

kibanamachine mentioned this pull request Jan 27, 2023

[DOCS] Updates telemetry settings #149651

Merged

kibanamachine mentioned this pull request May 25, 2023

[DOCS] Telemetry settings: improve phrasing #158396

Merged

1 task

Conversation

epixa commented Nov 20, 2019

Uh oh!

elasticmachine commented Nov 20, 2019

Uh oh!

elasticmachine commented Nov 20, 2019

Uh oh!

elasticmachine commented Nov 20, 2019

💚 Build Succeeded

Uh oh!

Bamieh left a comment

Choose a reason for hiding this comment

Uh oh!

epixa commented Nov 20, 2019

Uh oh!

epixa commented Nov 20, 2019

Uh oh!

gchaps Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

Bamieh Mar 24, 2020

Choose a reason for hiding this comment

Uh oh!

afharo Mar 24, 2020

Choose a reason for hiding this comment

Uh oh!

Bamieh commented Nov 20, 2019

Uh oh!

elasticmachine commented Dec 20, 2019

Uh oh!

TinaHeiligers commented Mar 5, 2020

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

gchaps left a comment

Choose a reason for hiding this comment

Uh oh!

Bamieh left a comment

Choose a reason for hiding this comment

Uh oh!

afharo commented Apr 2, 2020

Uh oh!

kibanamachine commented Apr 2, 2020

💚 Build Succeeded

History

Uh oh!

Bamieh commented Apr 2, 2020

Uh oh!

Bamieh left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 6, 2020

Uh oh!

afharo commented Apr 7, 2020

Uh oh!

elasticmachine commented Oct 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants