[ML] Transforms: Use EuiInMemoryTable instead of custom typed table.#59782
Merged
walterra merged 2 commits intoelastic:masterfrom Mar 11, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Mar 10, 2020
| @@ -186,52 +182,46 @@ export const TransformList: FC<Props> = ({ | |||
| // Before the transforms have been loaded for the first time, display the loading indicator only. | |||
Contributor
There was a problem hiding this comment.
Is this comment still valid?
Contributor
Author
There was a problem hiding this comment.
Yes that's still relevant.
Contributor
💔 Build FailedTest FailuresKibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list.Transform: Transform List Minimal initializationStandard OutStack TraceTo update your PR or re-run it, just comment with: |
alvarezmelissa87
approved these changes
Mar 10, 2020
Contributor
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Tested and LGTM ⚡️
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Mar 11, 2020
…lastic#59782) Before EuiInMemoryTable had TypeScript support we used our own typings and some state & CSS fixes. This is now all solved by the original EUI component. - Use EuiInMemoryTable instead of custom typed table. - Deletes some legacy leftover files.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 11, 2020
* master: [ML] Transforms: Use EuiInMemoryTable instead of custom typed table. (elastic#59782) Alerting/fix flaky instance test (elastic#58994) ci: disable all Mocha rules for tape tests (elastic#59798) Fix UX in alerting UI forms when errors occur (elastic#59444) [DOCS] Updated and added jump tables (elastic#59774) [DOCS] Moved rolled up index content (elastic#59372) Regenerate core api docs (elastic#59814) [Lens] remove react warnings (elastic#59574) The scripts/backport.js file isn't an executable (elastic#59800) [Alerting] add more alert properties to action parameter templating (elastic#59718) [Design] Branding changes in Elastic to focus more towards the Elastic brand (elastic#58160) [SIEM] Adds 'Create new rule' Cypress test (elastic#59790) Updating svgo -> css-tree -> mdn-data, all so we get mdn-data > 2.0 (elastic#58913) Use EUI test environment build with Jest (elastic#55877) update typescript version in all packages to avoid warnings (elastic#59787) [SIEM] [Case] Insert timeline into case textarea (elastic#59586) [ML] Functional tests - stabilize saved search tests (elastic#59652)
tylersmalley
added a commit
that referenced
this pull request
Mar 11, 2020
#59782 was merged with failing test. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before
EuiInMemoryTablehad TypeScript support we used our own typings and some state & CSS fixes. This is now all solved by the original EUI component.Note for
kibana-design: NoSCSSfiles where modified, just deleted some overrides.Checklist
For maintainers