[SIEM] Adds 'Create new rule' Cypress test#59790
Merged
MadameSheema merged 3 commits intoelastic:masterfrom Mar 10, 2020
Merged
[SIEM] Adds 'Create new rule' Cypress test#59790MadameSheema merged 3 commits intoelastic:masterfrom
MadameSheema merged 3 commits intoelastic:masterfrom
Conversation
MadameSheema
added
Team:SIEM
v8.0.0
release_note:skip
MadameSheema
requested review from
FrankHassanabad,
dhurley14,
patrykkopycinski,
rylnd,
spong and
yctercero
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
| name: i18n.COLUMN_RULE, | ||
| render: (value: Rule['name'], item: Rule) => ( | ||
| <EuiLink href={getRuleDetailsUrl(item.id)}>{value}</EuiLink> | ||
| <EuiLink data-test-subj="ruleName" href={getRuleDetailsUrl(item.id)}> |
Contributor
There was a problem hiding this comment.
👍 for the data-test-subj! Thank you!
| </div> | ||
| ))} | ||
| <MyAddItemButton onClick={addItem} isDisabled={isDisabled}> | ||
| <MyAddItemButton data-test-subj="addMitre" onClick={addItem} isDisabled={isDisabled}> |
Contributor
There was a problem hiding this comment.
I see a mix in our code base of data-test-subj using hypen separators such as add-mitre versus camel case. I don't know if there is a convention documented in the contributing guide but just pointing it out.
This looks fine to me though. (I'm not picky about it)
FrankHassanabad
approved these changes
Mar 10, 2020
Contributor
FrankHassanabad
left a comment
FrankHassanabad
left a comment
There was a problem hiding this comment.
Left one question about our convention of camelcase 🐫but I like everything about this PR and approve!
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
Contributor
Author
|
@FrankHassanabad agree with you about the convention, I'll take a look and I'll try to refactor for the winning one :P |
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Mar 10, 2020
* adds 'Creates and activates new rule' * loads data using es_archive * refactor test
MadameSheema
added a commit
that referenced
this pull request
Mar 11, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 11, 2020
* master: [ML] Transforms: Use EuiInMemoryTable instead of custom typed table. (elastic#59782) Alerting/fix flaky instance test (elastic#58994) ci: disable all Mocha rules for tape tests (elastic#59798) Fix UX in alerting UI forms when errors occur (elastic#59444) [DOCS] Updated and added jump tables (elastic#59774) [DOCS] Moved rolled up index content (elastic#59372) Regenerate core api docs (elastic#59814) [Lens] remove react warnings (elastic#59574) The scripts/backport.js file isn't an executable (elastic#59800) [Alerting] add more alert properties to action parameter templating (elastic#59718) [Design] Branding changes in Elastic to focus more towards the Elastic brand (elastic#58160) [SIEM] Adds 'Create new rule' Cypress test (elastic#59790) Updating svgo -> css-tree -> mdn-data, all so we get mdn-data > 2.0 (elastic#58913) Use EUI test environment build with Jest (elastic#55877) update typescript version in all packages to avoid warnings (elastic#59787) [SIEM] [Case] Insert timeline into case textarea (elastic#59586) [ML] Functional tests - stabilize saved search tests (elastic#59652)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we are adding a Cypress test in order to check that a new rule can be correctly created.
In order to do that the test is performing the following actions: