Use EUI test environment build with Jest by thompsongl · Pull Request #55877 · elastic/kibana

thompsongl · 2020-01-24T18:36:42Z

Summary

Set Jest's moduleNameMapper config to use EUI's new commonjs test environment build. This build has async & dynamic import functions transformed, removing the need for Kibana to do so. We've also mocked the EuiIcon component to solidify snapshot testing output. Instead of the full svg icon, snapshots will now get a div with relevant identifying attributes.

~~Sibling/dependent PR: elastic/eui#2698~~

Undoes the Jest environment changes introduced in #36316 when EUI started using dynamic imports.

Checklist

Build targeting Jest with relevant transforms eui#2698 has merged and been released

~~- [ ] This was checked for cross-browser compatibility, including a check against IE11~~
~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~

Unit or functional tests were updated or added to match the most common scenarios

~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately

~~- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

src/dev/jest/babel_transform.js

elasticmachine · 2020-02-07T10:08:33Z

Pinging @elastic/kibana-design (Team:Design)

thompsongl · 2020-02-07T17:46:03Z

Update:

We released the new test build as part of eui@19.0.0 this week. Once Kibana has been updated to use that version, I will update this PR to have more clear intentions.

thompsongl · 2020-02-14T22:10:01Z

Snapshot test failures are as expected. I'll be updating snapshots next week to match new expected output for EuiIcon

thompsongl · 2020-02-24T21:48:42Z

Waiting on a resolution to #58068 before this can move forward

spalger

The jest changes here look fine, but the large number of changed snapshots is concerning... Are there multiple changes we could decouple a bit? Why does this change to the config cause so many snapshots to update?

walterra

ML changes LGTM

legrego

Love it! Security changes LGTM

chrisronline

Stack monitoring changes LGTM!

spalger

LGTM

smith

APM changes look good!

lizozom

@elastic/kibana-app-arch changes are only snapshots.
LGTM

pgayvallet

LGTM for platform changes

kertal

LGTM for KibanaApp, 👍 for this Kibana snapshot diet

cqliu1

Canvas changes LGTM 👍

package.json

chandlerprall

Changes LGTM; jest configuration looks correct, and the changes to tests' selectors and their snapshots look like what we expect

thompsongl · 2020-03-10T14:43:45Z

@elasticmachine merge upstream

thompsongl · 2020-03-10T16:26:33Z

@elasticmachine merge upstream

kibanamachine · 2020-03-10T18:07:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 53aeb70

History

💔 Build #32083 failed 0de33f3
💚 Build #31863 succeeded 3734843
💔 Build #31799 failed 8f91ee4
💚 Build #31466 succeeded ef85b3f
💔 Build #27682 failed 856e232

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* wip * dir name * src snapshot changes * x-pack snapshots * svg element lookups * snapshot updates Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Use EUI test environment build with Jest (#55877) * wip * dir name * src snapshot changes * x-pack snapshots * svg element lookups * snapshot updates Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * yarn.lock update Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: [ML] Transforms: Use EuiInMemoryTable instead of custom typed table. (elastic#59782) Alerting/fix flaky instance test (elastic#58994) ci: disable all Mocha rules for tape tests (elastic#59798) Fix UX in alerting UI forms when errors occur (elastic#59444) [DOCS] Updated and added jump tables (elastic#59774) [DOCS] Moved rolled up index content (elastic#59372) Regenerate core api docs (elastic#59814) [Lens] remove react warnings (elastic#59574) The scripts/backport.js file isn't an executable (elastic#59800) [Alerting] add more alert properties to action parameter templating (elastic#59718) [Design] Branding changes in Elastic to focus more towards the Elastic brand (elastic#58160) [SIEM] Adds 'Create new rule' Cypress test (elastic#59790) Updating svgo -> css-tree -> mdn-data, all so we get mdn-data > 2.0 (elastic#58913) Use EUI test environment build with Jest (elastic#55877) update typescript version in all packages to avoid warnings (elastic#59787) [SIEM] [Case] Insert timeline into case textarea (elastic#59586) [ML] Functional tests - stabilize saved search tests (elastic#59652)

thompsongl added 6 commits December 18, 2019 13:02

wip

76ad0ae

Merge branch 'master' into jest-build

04bd20f

dir name

0b69616

Merge branch 'master' into jest-build

eaa3cf4

Merge branch 'master' into jest-build

ee638ab

Merge branch 'master' into jest-build

5676e66

thompsongl requested review from chandlerprall and spalger January 24, 2020 18:36

thompsongl mentioned this pull request Jan 24, 2020

Build targeting Jest with relevant transforms elastic/eui#2698

Merged

4 tasks

chandlerprall reviewed Jan 24, 2020

View reviewed changes

src/dev/jest/babel_transform.js Show resolved Hide resolved

streamich added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Feb 7, 2020

Merge branch 'master' into jest-build

6fe892e

thompsongl added 7 commits February 18, 2020 09:46

Merge branch 'master' into jest-build

1b932ee

src snapshot changes

b909135

x-pack snapshots

6d95f03

Merge branch 'master' into jest-build

33dd162

svg element lookups

ae13aec

Merge branch 'master' into jest-build

ba18212

Merge branch 'master' into jest-build

856e232

thompsongl mentioned this pull request Feb 19, 2020

[Lens] EditorFrame + EuiIcon test suite interaction #58068

Closed

Merge branch 'master' into jest-build

a028cb7

thompsongl added the blocked label Mar 2, 2020

thompsongl added 3 commits March 4, 2020 17:35

Merge branch 'master' into jest-build

3324116

Merge branch 'master' into jest-build

5ae1d96

snapshot updates

ef85b3f

spalger reviewed Mar 6, 2020

View reviewed changes

thompsongl added v7.7.0 v8.0.0 labels Mar 6, 2020

walterra approved these changes Mar 6, 2020

View reviewed changes

legrego approved these changes Mar 6, 2020

View reviewed changes

chrisronline approved these changes Mar 6, 2020

View reviewed changes

spalger approved these changes Mar 6, 2020

View reviewed changes

smith approved these changes Mar 6, 2020

View reviewed changes

lizozom approved these changes Mar 8, 2020

View reviewed changes

pgayvallet approved these changes Mar 9, 2020

View reviewed changes

kertal approved these changes Mar 9, 2020

View reviewed changes

thompsongl added 2 commits March 9, 2020 10:26

Merge branch 'master' into jest-build

8f91ee4

Merge branch 'master' into jest-build

3734843

cqliu1 approved these changes Mar 9, 2020

View reviewed changes

thompsongl requested a review from chandlerprall March 9, 2020 19:42

chandlerprall reviewed Mar 9, 2020

View reviewed changes

package.json Show resolved Hide resolved

chandlerprall approved these changes Mar 9, 2020

View reviewed changes

Merge branch 'master' into jest-build

0edcc71

Merge branch 'master' into jest-build

0de33f3

Merge branch 'master' into jest-build

53aeb70

thompsongl merged commit 4e52dee into elastic:master Mar 10, 2020

thompsongl mentioned this pull request Mar 10, 2020

[7.x] Use EUI test environment build with Jest (#55877) #59818

Merged

jportner mentioned this pull request Mar 11, 2020

Failing test: X-Pack Jest Tests.x-pack/plugins/index_management/__jest__/client_integration - <TemplateCreate /> on component mount form validation aliases (step 4) should set the correct page title #59855

Closed

Comments

Conversation

thompsongl commented Jan 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

Uh oh!

elasticmachine commented Feb 7, 2020

Uh oh!

thompsongl commented Feb 7, 2020

Uh oh!

thompsongl commented Feb 14, 2020

Uh oh!

thompsongl commented Feb 24, 2020

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

walterra left a comment

Choose a reason for hiding this comment

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

cqliu1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chandlerprall left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Mar 10, 2020

Uh oh!

thompsongl commented Mar 10, 2020

Uh oh!

kibanamachine commented Mar 10, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

thompsongl commented Jan 24, 2020 •

edited

Loading