Fix UX in alerting UI forms when errors occur#59444
Merged
mikecote merged 13 commits intoelastic:masterfrom Mar 11, 2020
Merged
Fix UX in alerting UI forms when errors occur#59444mikecote merged 13 commits intoelastic:masterfrom
mikecote merged 13 commits intoelastic:masterfrom
Conversation
mikecote
added
Feature:Alerting
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Contributor
Author
|
@elasticmachine merge upstream |
…kibana into alerting/ui-form-server-errors
Contributor
Author
|
@elasticmachine merge upstream |
…kibana into alerting/ui-form-server-errors
pmuellr
approved these changes
Mar 10, 2020
Contributor
pmuellr
left a comment
pmuellr
left a comment
There was a problem hiding this comment.
code LGTM, left a comment about if check on toastNotifications
x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_add.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Mar 11, 2020
* Fix UX in UI forms when errors occur * Create connector modal won't change * ESLint fixes * Fix type check * Add some tests * Remove if checks Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 11, 2020
* master: [ML] Transforms: Use EuiInMemoryTable instead of custom typed table. (elastic#59782) Alerting/fix flaky instance test (elastic#58994) ci: disable all Mocha rules for tape tests (elastic#59798) Fix UX in alerting UI forms when errors occur (elastic#59444) [DOCS] Updated and added jump tables (elastic#59774) [DOCS] Moved rolled up index content (elastic#59372) Regenerate core api docs (elastic#59814) [Lens] remove react warnings (elastic#59574) The scripts/backport.js file isn't an executable (elastic#59800) [Alerting] add more alert properties to action parameter templating (elastic#59718) [Design] Branding changes in Elastic to focus more towards the Elastic brand (elastic#58160) [SIEM] Adds 'Create new rule' Cypress test (elastic#59790) Updating svgo -> css-tree -> mdn-data, all so we get mdn-data > 2.0 (elastic#58913) Use EUI test environment build with Jest (elastic#55877) update typescript version in all packages to avoid warnings (elastic#59787) [SIEM] [Case] Insert timeline into case textarea (elastic#59586) [ML] Functional tests - stabilize saved search tests (elastic#59652)
mikecote
added a commit
that referenced
this pull request
Mar 11, 2020
* Fix UX in UI forms when errors occur * Create connector modal won't change * ESLint fixes * Fix type check * Add some tests * Remove if checks Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #58181.
In this PR, I'm making a few changes to alert and connector forms to improve the UX whenever a user encounters an error:
Screenshots
Create connector modal
Create connector flyout
Edit connector flyout
cc @mdefazio for screenshots