Skip to content

Comments

[ML] Transforms: Updates Jest snapshots#59897

Merged
tylersmalley merged 1 commit intoelastic:masterfrom
tylersmalley:update-failing-ml-snapshot
Mar 11, 2020
Merged

[ML] Transforms: Updates Jest snapshots#59897
tylersmalley merged 1 commit intoelastic:masterfrom
tylersmalley:update-failing-ml-snapshot

Conversation

@tylersmalley
Copy link
Member

@tylersmalley tylersmalley commented Mar 11, 2020

Snapshot is failing on master

Closes #59878

#59782 was merged with failing test.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 11, 2020
@tylersmalley tylersmalley requested a review from a team as a code owner March 11, 2020 13:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@tylersmalley tylersmalley changed the title [ML] Updates Jest snapshots [ML] Transforms: Updates Jest snapshots Mar 11, 2020
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@tylersmalley tylersmalley merged commit d781b3e into elastic:master Mar 11, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 12, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59897 or prevent reminders by adding the backport:skip label.

@walterra walterra added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 12, 2020
@walterra
Copy link
Contributor

Added backport:skip label since the backport of the original PR includes the snapshot fix #59868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.0.0

Projects

None yet

5 participants