Upgrade EUI to 11.0.1; support dynamic import() calls in UI code + eui#36316
Merged
chandlerprall merged 18 commits intoelastic:masterfrom Jun 3, 2019
Merged
Upgrade EUI to 11.0.1; support dynamic import() calls in UI code + eui#36316chandlerprall merged 18 commits intoelastic:masterfrom
chandlerprall merged 18 commits intoelastic:masterfrom
Conversation
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins test this |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins test this |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins test this |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins test this |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
Author
|
with all tests happy, this is now ready for review /me wipes sweat from brow |
kobelb
approved these changes
May 31, 2019
spalger
approved these changes
May 31, 2019
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
LGTM for babel/jest changes
| plugins: [ | ||
| // enables jest to parse and execute dynamic import() calls | ||
| '@babel/plugin-syntax-dynamic-import', | ||
| 'dynamic-import-node' |
Contributor
There was a problem hiding this comment.
I don't hate with this, but I would really appreciate not needing to build EUI when running our tests. Ideally EUI can ship with a commonjs version in the future that applies this plugin to rewrite the dynamic imports with static ones, then we can use jest's moduleNameMapper config to rewrite @elastic/eui(/.*)? to <rootDir>/node_modules/@elastic/eui/commonjs$1.
Contributor
Author
There was a problem hiding this comment.
Sounds good to me!
Contributor
💚 Build Succeeded |
chandlerprall
added a commit
to chandlerprall/kibana
that referenced
this pull request
Jun 3, 2019
elastic#36316) * Upgrade EUI to 11.0.1; support dynamic import() calls in UI code + eui * update snaps * Clicking on the svg itself once loaded * updated snaps * update icon in snapshots * Fix snapshot
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import()calls to jest's babel configurationnode_modules/@elastic/euiBecause of the widespread presence/usage of EuiIcon and the impact this most likely has on active PRs, after approvals I will merge master into this branch, re-update and check snapshots, and then merge.
EUI Changelog
11.0.1Bug fixes
EuiIconTip's typescript definition (#1934)EuiIconcomponent ability to handletypeprop updates (#1935)11.0.0EuiIcon(#1924)Bug fixes
Breaking changes
EuiIconicon loading into dynamic imports (#1924)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately