[Logs UI] Support zoom by brushing in the log rate chart#45879
Merged
weltenwort merged 3 commits intoelastic:masterfrom Sep 17, 2019
Merged
[Logs UI] Support zoom by brushing in the log rate chart#45879weltenwort merged 3 commits intoelastic:masterfrom
weltenwort merged 3 commits intoelastic:masterfrom
Conversation
weltenwort
added
v8.0.0
Feature:Logs UI
Contributor
|
Pinging @elastic/infra-logs-ui |
Contributor
💚 Build Succeeded |
weltenwort
added
the
release_note:skip
Member
Author
|
@elasticmachine update branch |
Member
Author
|
ℹ️ The known issue seems to have been fixed upstream. |
Contributor
💚 Build Succeeded |
simianhacker
approved these changes
Sep 17, 2019
Member
simianhacker
left a comment
simianhacker
left a comment
There was a problem hiding this comment.
LGTM... Every thing works as expected.
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Sep 17, 2019
This enables the modification of the displayed time range in the log rate chart by brushing over the chart. closes elastic#45472
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Sep 17, 2019
* master: (33 commits) [easy] Exclude __examples__ from coverage (elastic#45556) [DOCS] Update CCR links (elastic#44012) Use unique junit report filenames again (elastic#45897) [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856) New visualization editor Lens (elastic#36437) Sort using unix timestamp value (elastic#43162) [APM] Use POST instead of implicit GET (elastic#45903) [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274) skip flaky test (elastic#45884) set IS_PIPELINE_JOB in intake jobs (elastic#45850) [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759) [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879) [DOCS] Changes name to host (elastic#45798) [ML] Add population job wizard test (elastic#45765) [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394) remove setTimeoue for state change (elastic#45853) [Graph] Restructure folders and add readme (elastic#45782) [ML] Enhance job id error message (elastic#45349) [SIEM] Do not update state component when they did unmount (elastic#45847) [i18n] sync from 7.4 latest translations (elastic#45823) ...
weltenwort
added a commit
that referenced
this pull request
Sep 17, 2019
Backports the following commits to 7.x: - [Logs UI] Support zoom by brushing in the log rate chart (#45879)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This enables the modification of the displayed time range in the log rate chart by brushing over the chart.
closes #45472
Known issues
Brushing on the chart causes warnings from React about state updates in unmounted components to be shown on the console. This originates from within elastic-charts and has already been fixed upstream (onBrushEnd should be called after setState is completed elastic-charts#360). This should therefore disappear as soon as the fix is made available in Kibana ([SIEM] upgrade elastic charts library - v12.0.2 #45853).Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibility