Sort using unix timestamp value#43162
Conversation
|
@justinkambic @cjcenizal It's been a while since I've touched UI code and it looks like EUI has advanced quite a bit since I was last using it. I feel like the fix I have in this PR should just work but it doesn't 😞. So obviously there's more going on here that I can't figure out. I did notice a bunch of React proptype validation warnings (even before I made any changes for this PR), so maybe that has something to do with why this change isn't just working? Could either of you take a look and point me in the right direction? Thanks! |
ycombinator
added
Feature:Logstash Pipelines
💔 Build Failed |
|
Per @cjcenizal's suggestion, pinging @chandlerprall and @thompsongl for help (please see my previous comment). Thanks! |
|
@ycombinator Happy to help. I don't seem to have a local setup right now that let's me see this view, but it appears that you're using |
|
Thanks @thompsongl!
It's a moment object. |
|
Is it possible to use the
Really, I'm just trying to discern whether |
Yes, it is. It returns the milliseconds-since-epoch timestamp, so it's an integer. |
|
Ok. I'll have to get a local setup that will let me debug. Replicating that component config in a more basic environment works as I'd expect it to. |
|
FWIW I went so far as to create a contrived table/data on this page and was unable to produce the desired behavior. I can provide the code if it's helpful to anyone. |
|
Might be helpful, but, I don't think This is using the config and new
|
|
I've added d9b2ae5 and 1d9d0ae to fix the sorting problem and update the branch with newer master, respectively. @chandlerprall do you think you'd be ok doing a review for us since @ycombinator and I have both committed at this point? |
ycombinator
changed the title
There was a problem hiding this comment.
I played around with the latest changes and they LGTM. I'm able to sort all columns, including the Last Modified one, as expected. Thanks @justinkambic and @chandlerprall!
@chandlerprall, we'd still like your review on this for reasons @justinkambic mentioned in his comment.
💔 Build Failed |
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
I made sure that localized headings translated alright.
LGTM too!
* Sort using unix timestamp value * Extract internationalization from react components to function calls. * Updating Jest snapshots for pipelines table component
* master: (33 commits) [easy] Exclude __examples__ from coverage (elastic#45556) [DOCS] Update CCR links (elastic#44012) Use unique junit report filenames again (elastic#45897) [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856) New visualization editor Lens (elastic#36437) Sort using unix timestamp value (elastic#43162) [APM] Use POST instead of implicit GET (elastic#45903) [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274) skip flaky test (elastic#45884) set IS_PIPELINE_JOB in intake jobs (elastic#45850) [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759) [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879) [DOCS] Changes name to host (elastic#45798) [ML] Add population job wizard test (elastic#45765) [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394) remove setTimeoue for state change (elastic#45853) [Graph] Restructure folders and add readme (elastic#45782) [ML] Enhance job id error message (elastic#45349) [SIEM] Do not update state component when they did unmount (elastic#45847) [i18n] sync from 7.4 latest translations (elastic#45823) ...
5 participants
Fixes #42472.
This PR attempts to fix the sorting for the "Last Modified" column in the Logstash Pipeline Management UI.
Pre-requisites for viewing the Logstash Pipeline Management UI