Skip to content

[easy] Exclude __examples__ from coverage#45556

Merged
clintandrewhall merged 2 commits intoelastic:masterfrom
clintandrewhall:jest-exclude
Sep 17, 2019
Merged

[easy] Exclude __examples__ from coverage#45556
clintandrewhall merged 2 commits intoelastic:masterfrom
clintandrewhall:jest-exclude

Conversation

@clintandrewhall
Copy link
Contributor

Summary

Example test files are automatically 100%, so they pad our coverage data. This quick fix addresses that.

About Coverage

A report is generated and placed in in canvas/coverage.

Overview Page

Screen Shot 2019-09-12 at 12 25 25 PM

More Coverage

Screen Shot 2019-09-12 at 12 25 36 PM

Drilling into a Directory

Screen Shot 2019-09-12 at 12 25 41 PM

Coverage by File

Screen Shot 2019-09-12 at 12 25 55 PM

@clintandrewhall clintandrewhall added review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v7.5.0 labels Sep 12, 2019
@clintandrewhall clintandrewhall requested a review from a team as a code owner September 12, 2019 17:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough 👍

@clintandrewhall
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@clintandrewhall clintandrewhall merged commit f6be95a into elastic:master Sep 17, 2019
@clintandrewhall clintandrewhall deleted the jest-exclude branch September 17, 2019 19:50
clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request Sep 17, 2019

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rylnd added a commit to rylnd/kibana that referenced this pull request Sep 17, 2019
* master: (33 commits)
  [easy] Exclude __examples__ from coverage (elastic#45556)
  [DOCS] Update CCR links (elastic#44012)
  Use unique junit report filenames again (elastic#45897)
  [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856)
  New visualization editor Lens (elastic#36437)
  Sort using unix timestamp value (elastic#43162)
  [APM] Use POST instead of implicit GET (elastic#45903)
  [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274)
  skip flaky test (elastic#45884)
  set IS_PIPELINE_JOB in intake jobs (elastic#45850)
  [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759)
  [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879)
  [DOCS] Changes name to host (elastic#45798)
  [ML] Add population job wizard test (elastic#45765)
  [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394)
  remove setTimeoue for state change (elastic#45853)
  [Graph] Restructure folders and add readme (elastic#45782)
  [ML] Enhance job id error message (elastic#45349)
  [SIEM] Do not update state component when they did unmount (elastic#45847)
  [i18n] sync from 7.4 latest translations (elastic#45823)
  ...
clintandrewhall added a commit that referenced this pull request Sep 17, 2019
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.5.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants