[Graph] Restructure folders and add readme#45782
Merged
flash1293 merged 5 commits intoelastic:masterfrom Sep 17, 2019
Merged
Conversation
flash1293
added
Feature:Graph
Contributor
|
Pinging @elastic/kibana-app |
Contributor
Author
|
@elastic/kibana-design Nothing to review here, just moved some folders containing stylesheets |
cchaos
suggested changes
Sep 16, 2019
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
You need to change the import in this file too: https://github.com/elastic/kibana/blob/cd5cecdd8c3d785aa55191a9331c51c1ac2e991c/x-pack/legacy/plugins/graph/public/components/_index.scss
Contributor
Author
|
@cchaos Oops, thanks - fixed! |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
kertal
approved these changes
Sep 17, 2019
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Nice doc + structure 🎨 , LGTM!
Contributor
💚 Build Succeeded |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Sep 17, 2019
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Sep 17, 2019
* master: (33 commits) [easy] Exclude __examples__ from coverage (elastic#45556) [DOCS] Update CCR links (elastic#44012) Use unique junit report filenames again (elastic#45897) [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856) New visualization editor Lens (elastic#36437) Sort using unix timestamp value (elastic#43162) [APM] Use POST instead of implicit GET (elastic#45903) [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274) skip flaky test (elastic#45884) set IS_PIPELINE_JOB in intake jobs (elastic#45850) [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759) [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879) [DOCS] Changes name to host (elastic#45798) [ML] Add population job wizard test (elastic#45765) [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394) remove setTimeoue for state change (elastic#45853) [Graph] Restructure folders and add readme (elastic#45782) [ML] Enhance job id error message (elastic#45349) [SIEM] Do not update state component when they did unmount (elastic#45847) [i18n] sync from 7.4 latest translations (elastic#45823) ...
flash1293
added a commit
that referenced
this pull request
Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a readme outlining a target folder structure and structures the existing code accordingly. PRs currently in flight will be brought in shape as soon as this one is merged.
It doesn't change anything about functionality besides a small bugfix in deserialization