[Logstash] Remove formatted message component in favor of i18n translate function#45658
Merged
justinkambic merged 3 commits intoelastic:masterfrom Sep 23, 2019
Merged
Conversation
justinkambic
added
Feature:Logstash Pipelines
Contributor
💔 Build Failed |
justinkambic
changed the title
justinkambic
force-pushed
the
logstash_pipeline-search-error
branch
from
0ecfc04 to
02d92af
Compare
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
justinkambic
changed the title
ycombinator
approved these changes
Sep 20, 2019
Contributor
ycombinator
left a comment
ycombinator
left a comment
There was a problem hiding this comment.
LGTM. Saw errors on master. Confirmed that those errors are gone with this PR. Thanks @justinkambic!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Sep 23, 2019
…ate function (elastic#45658) * Remove formatted message component in favor for i18n translate function. * Update broken test snapshot.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Logstash pipelines page is generating console warnings because JSX is injected to
EuiInMemoryTable'ssearchprop where only a string is valid. The JSX was added to provide internationalization of the page's controls, which is working, but has caused other problems in addition to the dirty console.Testing this PR
Management/Logstash PipelinesChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers