[SIEM] Fix draggables to work with escapeId for the ML severity column by FrankHassanabad · Pull Request #41621 · elastic/kibana

FrankHassanabad · 2019-07-19T23:14:36Z

Summary

Blocker bug where you could not drag and drop to the timeline.

Fix for host:

Fix for network:

One line fix for it so you can drag and drop to the timeline

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, including a check against IE11~~

~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~

~~- [ ] Documentation was added for features that require explanation or tutorials~~

~~- [ ] Unit or functional tests were updated or added to match the most common scenarios~~

~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~- [ ] This was checked for breaking API changes and was labeled appropriately~~

~~- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

andrew-goldstein · 2019-07-19T23:20:13Z

x-pack/legacy/plugins/siem/public/components/load_more_table/index.tsx

  truncateText?: boolean;
  hideForMobile?: boolean;
-  render?: (item: T, node: U) => void;
+  render?: (item: T, node: U) => React.ReactNode;


thanks for fixing this type

elasticmachine · 2019-07-19T23:22:24Z

Pinging @elastic/secops

andrew-goldstein

LGTM

spong

LGTM! Thanks for this quick-fix!

elasticmachine · 2019-07-20T00:17:19Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elastic#41621) ## Summary Blocker bug where you could not drag and drop to the timeline. ![drag-n-drop-issue-with-severity](https://user-images.githubusercontent.com/1151048/61570279-cf12e500-aa48-11e9-967f-8ef0e6c8750b.gif) Fix for host: ![drag-and-dop-host](https://user-images.githubusercontent.com/1151048/61570380-6aa45580-aa49-11e9-80e6-2a9e7fa7f650.gif) Fix for network: ![network-drag-and-drop](https://user-images.githubusercontent.com/1151048/61570386-7132cd00-aa49-11e9-8342-1524aeb5093f.gif) One line fix for it so you can drag and drop to the timeline ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. ~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~ ~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~ ~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ ~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~ ~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ ### For maintainers ~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ ~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

#41621) (#41626) ## Summary Blocker bug where you could not drag and drop to the timeline. ![drag-n-drop-issue-with-severity](https://user-images.githubusercontent.com/1151048/61570279-cf12e500-aa48-11e9-967f-8ef0e6c8750b.gif) Fix for host: ![drag-and-dop-host](https://user-images.githubusercontent.com/1151048/61570380-6aa45580-aa49-11e9-80e6-2a9e7fa7f650.gif) Fix for network: ![network-drag-and-drop](https://user-images.githubusercontent.com/1151048/61570386-7132cd00-aa49-11e9-8342-1524aeb5093f.gif) One line fix for it so you can drag and drop to the timeline ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. ~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~ ~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~ ~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ ~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~ ~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ ### For maintainers ~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ ~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

#41621) (#41627) ## Summary Blocker bug where you could not drag and drop to the timeline. ![drag-n-drop-issue-with-severity](https://user-images.githubusercontent.com/1151048/61570279-cf12e500-aa48-11e9-967f-8ef0e6c8750b.gif) Fix for host: ![drag-and-dop-host](https://user-images.githubusercontent.com/1151048/61570380-6aa45580-aa49-11e9-80e6-2a9e7fa7f650.gif) Fix for network: ![network-drag-and-drop](https://user-images.githubusercontent.com/1151048/61570386-7132cd00-aa49-11e9-8342-1524aeb5093f.gif) One line fix for it so you can drag and drop to the timeline ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. ~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~ ~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~ ~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ ~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~ ~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ ### For maintainers ~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ ~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

…b-panel-for-stopping-jobs * 'master' of github.com:elastic/kibana: (58 commits) [DOCS] Timelion cleanup (elastic#41381) [Docs] Add simple phrase highlighting to Logs UI (elastic#41610) [Maps] Rename modules for clarity (elastic#41608) [Monitoring] Metricbeat migration net new user experience (elastic#39832) [Maps] Only color legend icon with dynamic color when dynamic config is complete (elastic#41607) [TSVB] [Markdown] markdown section do not render after change data parameter (elastic#41576) [Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (elastic#41565) update dark mode tsvb test (elastic#41618) [i18n] .i18nrc file as the source of truth and enhance tooling (elastic#39774) Reactify Top Nav Menu (kbn_top_nav) (elastic#40262) fix(code/frontend): should update search results if search options change (elastic#41232) Use kibana-ci-proxy-cache for chrome and gecko drivers (elastic#41581) [SIEM] Fix draggables to work with escapeId for the ML severity column (elastic#41621) [Canvas] Updates esdocs default count to 1000 (elastic#41604) [Uptime] Fix duration chart for Safari (elastic#41619) [Canvas] Restores "Today" as a quick time range in time filter (elastic#41528) docs: lowercase app (elastic#41612) [Code] Update git repository update frequency (elastic#41541) Remove language=json on code blocks due to performance hit (elastic#41540) [DOCS] Update anchors and links for Elasticserach API relocation. (elastic#41372) ...

Fix draggables to work with escapeId and ML severity

afefc33

FrankHassanabad changed the title ~~Fix draggables to work with escapeId for the ML severity column~~ [SIEM] Fix draggables to work with escapeId for the ML severity column Jul 19, 2019

andrew-goldstein reviewed Jul 19, 2019

View reviewed changes

FrankHassanabad added v7.3.0 v7.2.0 v7.4.0 v8.0.0 and removed v7.2.0 labels Jul 19, 2019

FrankHassanabad self-assigned this Jul 19, 2019

FrankHassanabad added the Team:SIEM label Jul 19, 2019

Fix draggables

3209268

FrankHassanabad added the loe:small Small Level of Effort label Jul 19, 2019

spong added the release_note:skip Skip the PR/issue when compiling release notes label Jul 19, 2019

andrew-goldstein approved these changes Jul 19, 2019

View reviewed changes

spong approved these changes Jul 19, 2019

View reviewed changes

FrankHassanabad merged commit 5a06491 into elastic:master Jul 20, 2019

FrankHassanabad deleted the fix-severity-draggable branch July 20, 2019 00:23

FrankHassanabad mentioned this pull request Jul 20, 2019

[7.x] [SIEM] Fix draggables to work with escapeId for the ML severity column (#41621) #41626

Merged

FrankHassanabad mentioned this pull request Jul 20, 2019

[7.3] [SIEM] Fix draggables to work with escapeId for the ML severity column (#41621) #41627

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM] Fix draggables to work with escapeId for the ML severity column#41621

[SIEM] Fix draggables to work with escapeId for the ML severity column#41621
FrankHassanabad merged 2 commits intoelastic:masterfrom
FrankHassanabad:fix-severity-draggable

FrankHassanabad commented Jul 19, 2019 •

edited

Loading

Uh oh!

andrew-goldstein Jul 19, 2019

Uh oh!

elasticmachine commented Jul 19, 2019

Uh oh!

andrew-goldstein left a comment

Uh oh!

spong left a comment

Uh oh!

elasticmachine commented Jul 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

FrankHassanabad commented Jul 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

andrew-goldstein Jul 19, 2019

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 19, 2019

Uh oh!

andrew-goldstein left a comment

Choose a reason for hiding this comment

Uh oh!

spong left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 20, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FrankHassanabad commented Jul 19, 2019 •

edited

Loading