Skip to content

[Maps] Only color legend icon with dynamic color when dynamic config is complete#41607

Merged
nreese merged 3 commits intoelastic:masterfrom
nreese:issue_39909
Jul 22, 2019
Merged

[Maps] Only color legend icon with dynamic color when dynamic config is complete#41607
nreese merged 3 commits intoelastic:masterfrom
nreese:issue_39909

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Jul 19, 2019

fixes #39909

Before

Screen Shot 2019-07-19 at 1 46 33 PM

After

Screen Shot 2019-07-19 at 1 47 29 PM

@nreese nreese added release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.4.0 labels Jul 19, 2019
@nreese nreese requested a review from thomasneirynck July 19, 2019 19:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested. nice little detail, really adds to overall polish

@nreese nreese merged commit e9c1ce9 into elastic:master Jul 22, 2019
nreese added a commit to nreese/kibana that referenced this pull request Jul 22, 2019
…is complete (elastic#41607)

* [Maps] Only color legend icon with dynamic color when dynamic config is complete

* reword comment

* update jest test
nreese added a commit that referenced this pull request Jul 22, 2019
…is complete (#41607) (#41664)

* [Maps] Only color legend icon with dynamic color when dynamic config is complete

* reword comment

* update jest test
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 22, 2019
…b-panel-for-stopping-jobs

* 'master' of github.com:elastic/kibana: (58 commits)
  [DOCS] Timelion cleanup (elastic#41381)
  [Docs] Add simple phrase highlighting to Logs UI (elastic#41610)
  [Maps] Rename modules for clarity (elastic#41608)
  [Monitoring] Metricbeat migration net new user experience (elastic#39832)
  [Maps] Only color legend icon with dynamic color when dynamic config is complete (elastic#41607)
  [TSVB] [Markdown] markdown section do not render after change data parameter (elastic#41576)
  [Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (elastic#41565)
  update dark mode tsvb test (elastic#41618)
  [i18n] .i18nrc file as the source of truth and enhance tooling (elastic#39774)
  Reactify Top Nav Menu (kbn_top_nav) (elastic#40262)
  fix(code/frontend): should update search results if search options change (elastic#41232)
  Use kibana-ci-proxy-cache for chrome and gecko drivers (elastic#41581)
  [SIEM] Fix draggables to work with escapeId for the ML severity column (elastic#41621)
  [Canvas] Updates esdocs default count to 1000 (elastic#41604)
  [Uptime] Fix duration chart for Safari (elastic#41619)
  [Canvas] Restores "Today" as a quick time range in time filter (elastic#41528)
  docs: lowercase app (elastic#41612)
  [Code] Update git repository update frequency (elastic#41541)
  Remove language=json on code blocks due to performance hit (elastic#41540)
  [DOCS] Update anchors and links for Elasticserach API relocation. (elastic#41372)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.4.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maps] Legend icon should not use dynamic styling if config is incomplete

3 participants