Skip to content

[Canvas] Restores "Today" as a quick time range in time filter#41528

Merged
cqliu1 merged 2 commits intoelastic:masterfrom
cqliu1:fix/today-quick-range
Jul 19, 2019
Merged

[Canvas] Restores "Today" as a quick time range in time filter#41528
cqliu1 merged 2 commits intoelastic:masterfrom
cqliu1:fix/today-quick-range

Conversation

@cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Jul 18, 2019

Summary

This option was accidentally removed as part of the TS conversion of the time_filter component.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

@cqliu1 cqliu1 requested a review from a team as a code owner July 18, 2019 22:04
@cqliu1 cqliu1 added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.4.0 v8.0.0 labels Jul 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@cqliu1 cqliu1 added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jul 18, 2019
@cqliu1 cqliu1 requested a review from poffdeluxe July 18, 2019 22:05
@cqliu1 cqliu1 added the release_note:skip Skip the PR/issue when compiling release notes label Jul 18, 2019
@cqliu1 cqliu1 changed the title [Canvas] Adds back "Today" as a quick time range in time filter [Canvas] Restores "Today" as a quick time range in time filter Jul 18, 2019
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, good catch. I suspect you'll have to update a jest snapshot tho

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough 👍

@cqliu1 cqliu1 force-pushed the fix/today-quick-range branch from 297b063 to e528ef6 Compare July 19, 2019 20:02
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cqliu1 cqliu1 merged commit 9dfd89f into elastic:master Jul 19, 2019
@cqliu1 cqliu1 deleted the fix/today-quick-range branch July 19, 2019 22:44
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Jul 19, 2019
…ic#41528)

* Adds back Today as a quick time range in time filter

* Updated snapshots
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 22, 2019
…b-panel-for-stopping-jobs

* 'master' of github.com:elastic/kibana: (58 commits)
  [DOCS] Timelion cleanup (elastic#41381)
  [Docs] Add simple phrase highlighting to Logs UI (elastic#41610)
  [Maps] Rename modules for clarity (elastic#41608)
  [Monitoring] Metricbeat migration net new user experience (elastic#39832)
  [Maps] Only color legend icon with dynamic color when dynamic config is complete (elastic#41607)
  [TSVB] [Markdown] markdown section do not render after change data parameter (elastic#41576)
  [Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (elastic#41565)
  update dark mode tsvb test (elastic#41618)
  [i18n] .i18nrc file as the source of truth and enhance tooling (elastic#39774)
  Reactify Top Nav Menu (kbn_top_nav) (elastic#40262)
  fix(code/frontend): should update search results if search options change (elastic#41232)
  Use kibana-ci-proxy-cache for chrome and gecko drivers (elastic#41581)
  [SIEM] Fix draggables to work with escapeId for the ML severity column (elastic#41621)
  [Canvas] Updates esdocs default count to 1000 (elastic#41604)
  [Uptime] Fix duration chart for Safari (elastic#41619)
  [Canvas] Restores "Today" as a quick time range in time filter (elastic#41528)
  docs: lowercase app (elastic#41612)
  [Code] Update git repository update frequency (elastic#41541)
  Remove language=json on code blocks due to performance hit (elastic#41540)
  [DOCS] Update anchors and links for Elasticserach API relocation. (elastic#41372)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.4.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants