Skip to content

[7.3] [SIEM] Fix draggables to work with escapeId for the ML severity column (#41621)#41627

Merged
FrankHassanabad merged 1 commit intoelastic:7.3from
FrankHassanabad:backport/7.3/pr-41621
Jul 20, 2019
Merged

[7.3] [SIEM] Fix draggables to work with escapeId for the ML severity column (#41621)#41627
FrankHassanabad merged 1 commit intoelastic:7.3from
FrankHassanabad:backport/7.3/pr-41621

Conversation

@FrankHassanabad
Copy link
Contributor

Backports the following commits to 7.3:

elastic#41621)

## Summary

Blocker bug where you could not drag and drop to the timeline.
![drag-n-drop-issue-with-severity](https://user-images.githubusercontent.com/1151048/61570279-cf12e500-aa48-11e9-967f-8ef0e6c8750b.gif)

Fix for host:
![drag-and-dop-host](https://user-images.githubusercontent.com/1151048/61570380-6aa45580-aa49-11e9-80e6-2a9e7fa7f650.gif)

Fix for network:
![network-drag-and-drop](https://user-images.githubusercontent.com/1151048/61570386-7132cd00-aa49-11e9-8342-1524aeb5093f.gif)


One line fix for it so you can drag and drop to the timeline 

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~

~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~

~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~

~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~

~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
@FrankHassanabad FrankHassanabad added the backport This PR is a backport of another PR label Jul 20, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@FrankHassanabad FrankHassanabad merged commit 479634d into elastic:7.3 Jul 20, 2019
@FrankHassanabad FrankHassanabad deleted the backport/7.3/pr-41621 branch July 20, 2019 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants