Skip to content

Replace <account> with {account} in i18n strings#267775

Merged
mattnowzari merged 6 commits into
elastic:mainfrom
mattnowzari:fix_snowflake_i18n_angle_brackets
May 8, 2026
Merged

Replace <account> with {account} in i18n strings#267775
mattnowzari merged 6 commits into
elastic:mainfrom
mattnowzari:fix_snowflake_i18n_angle_brackets

Conversation

@mattnowzari
Copy link
Copy Markdown
Contributor

@mattnowzari mattnowzari commented May 5, 2026

Summary

Replaces <account> with {account} inside the Snowflake connector's i18n message strings as well as placholder URL text.

The presence of angle brackets was causing error messages on Kibana startup:

installHook.js:1 Error: [@formatjs/intl Error FORMAT_ERROR] Error formatting default message for: "core.kibanaConnectorSpecs.snowflake.auth.oauth.authorizationUrl.helpText", rendering default message verbatim
MessageID: core.kibanaConnectorSpecs.snowflake.auth.oauth.authorizationUrl.helpText
Default Message: Snowflake OAuth authorization URL. Replace <account> with your Snowflake account identifier.
Description: undefined

installHook.js:1 Error: [@formatjs/intl Error FORMAT_ERROR] Error formatting default message for: "core.kibanaConnectorSpecs.snowflake.auth.oauth.tokenUrl.helpText", rendering default message verbatim
MessageID: core.kibanaConnectorSpecs.snowflake.auth.oauth.tokenUrl.helpText
Default Message: Snowflake OAuth token endpoint. Replace <account> with your Snowflake account identifier.
Description: undefined

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@mattnowzari mattnowzari requested a review from a team as a code owner May 5, 2026 14:55
@mattnowzari mattnowzari added backport:version Backport to applied version labels v9.4.0 labels May 5, 2026
@mattnowzari mattnowzari changed the title Replace <account> with [account] in i18n strings Replace <account> with {account} in i18n strings May 5, 2026
@mattnowzari mattnowzari added the release_note:skip Skip the PR/issue when compiling release notes label May 5, 2026
Copy link
Copy Markdown
Contributor

@lorenabalan lorenabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two different ways already in the code for how we format these messages. While here could we align all 3?

{
defaultMessage:
'Snowflake OAuth authorization URL. Replace <account> with your Snowflake account identifier.',
'Snowflake OAuth authorization URL. Replace {account} with your Snowflake account identifier.',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Snowflake OAuth authorization URL. Replace {account} with your Snowflake account identifier.',
'Snowflake OAuth authorization URL. Replace '{account}' with your Snowflake account identifier.',

it's what we have on sharepoint_online connector

{
defaultMessage:
'Snowflake OAuth token endpoint. Replace <account> with your Snowflake account identifier.',
'Snowflake OAuth token endpoint. Replace {account} with your Snowflake account identifier.',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Snowflake OAuth token endpoint. Replace {account} with your Snowflake account identifier.',
'Snowflake OAuth token endpoint. Replace ''{account}'' with your Snowflake account identifier.',
values: { account: '{account}' },

is what we have on microsoft_teams.ts

@mattnowzari mattnowzari requested a review from lorenabalan May 5, 2026 15:40
{
defaultMessage:
'Snowflake OAuth authorization URL. Replace <account> with your Snowflake account identifier.',
"Snowflake OAuth authorization URL. Replace '{account}' with your Snowflake account identifier.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need a values: {...} here as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @lorenabalan - I'm not sure I quite follow what you mean here?

Copy link
Copy Markdown
Contributor

@lorenabalan lorenabalan May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comparing to src/platform/packages/shared/kbn-connector-specs/src/specs/sharepoint_online/sharepoint_online.ts for example. We pass

{
    defaultMessage: ...,
    values: {...},
}

otherwise I'm not sure if it's formatted correctly, doesn't it expect an account variable to plugin into the format string?

@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #163 / Core Analysis - Entity Store @ess Entity Store Engine APIs in non-default space get and list "before all" hook in "get and list"
  • [job] [logs] Scout Lane #17 - stateful-classic / uptime_legacy / local-stateful-classic - DefaultEmailSettings - configures email connector and validates settings
  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Discover app - errors - should render invalid scripted field error
  • [job] [logs] FTR Configs #52 / serverless observability UI - onboarding Onboarding Onboarding Firehose Quickstart Flow shows the existing data callout and detected AWS services when data was ingested previously

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 1.8MB 1.8MB +34.0B
workflowsManagement 2.3MB 2.3MB +34.0B
total +68.0B

History

@mattnowzari mattnowzari merged commit f9ee3df into elastic:main May 8, 2026
31 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.4

https://github.com/elastic/kibana/actions/runs/25569029303

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
9.4 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.4:
- test: include noDataViewsPrompt in Observability Scout pageOrNoData (#268486)
- Add aria-hidden={true} to decorative EuiIcon instances (#268367)
- [APM][Scout] Stabilize service map embeddable test panel time range (#268459)
- Fix broken translation string (#268460)
- [scout] migrate Lens API tests (#267993)
- [One Workflow] Unskip Workflow editor: validation performance tests (#268149)
- [scout] fix cleanup in SO managerment find test (#268349)

Manual backport

To create the backport manually run:

node scripts/backport --pr 267775

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 11, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 267775 locally
cc: @mattnowzari

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 267775 locally
cc: @mattnowzari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v9.4.0 v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants