Replace <account> with {account} in i18n strings#267775
Conversation
lorenabalan
left a comment
There was a problem hiding this comment.
We have two different ways already in the code for how we format these messages. While here could we align all 3?
| { | ||
| defaultMessage: | ||
| 'Snowflake OAuth authorization URL. Replace <account> with your Snowflake account identifier.', | ||
| 'Snowflake OAuth authorization URL. Replace {account} with your Snowflake account identifier.', |
There was a problem hiding this comment.
| 'Snowflake OAuth authorization URL. Replace {account} with your Snowflake account identifier.', | |
| 'Snowflake OAuth authorization URL. Replace '{account}' with your Snowflake account identifier.', |
it's what we have on sharepoint_online connector
| { | ||
| defaultMessage: | ||
| 'Snowflake OAuth token endpoint. Replace <account> with your Snowflake account identifier.', | ||
| 'Snowflake OAuth token endpoint. Replace {account} with your Snowflake account identifier.', |
There was a problem hiding this comment.
| 'Snowflake OAuth token endpoint. Replace {account} with your Snowflake account identifier.', | |
| 'Snowflake OAuth token endpoint. Replace ''{account}'' with your Snowflake account identifier.', | |
| values: { account: '{account}' }, |
is what we have on microsoft_teams.ts
| { | ||
| defaultMessage: | ||
| 'Snowflake OAuth authorization URL. Replace <account> with your Snowflake account identifier.', | ||
| "Snowflake OAuth authorization URL. Replace '{account}' with your Snowflake account identifier.", |
There was a problem hiding this comment.
Don't we need a values: {...} here as well?
There was a problem hiding this comment.
Sorry for the delay @lorenabalan - I'm not sure I quite follow what you mean here?
There was a problem hiding this comment.
comparing to src/platform/packages/shared/kbn-connector-specs/src/specs/sharepoint_online/sharepoint_online.ts for example. We pass
{
defaultMessage: ...,
values: {...},
}
otherwise I'm not sure if it's formatted correctly, doesn't it expect an account variable to plugin into the format string?
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 9.4 https://github.com/elastic/kibana/actions/runs/25569029303 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
Replaces
<account>with{account}inside the Snowflake connector'si18nmessage strings as well as placholder URL text.The presence of angle brackets was causing error messages on Kibana startup:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.