Skip to content

Replace <account> with {account} in i18n strings #267775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattnowzari merged 6 commits into from
May 8, 2026
+10 −7
Merged

Replace <account> with {account} in i18n strings #267775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb3d990
Replace <account> with [account] in i18n strings
mattnowzari May 5, 2026
efc1117
Actually, replace <> and [] with {}
mattnowzari May 5, 2026
81467ab
Align SPO, Snowflake and MS Teams connectors on how placeholder strin…
mattnowzari May 5, 2026
5ee940b
Merge branch 'main' into fix_snowflake_i18n_angle_brackets
mattnowzari May 7, 2026
1246ba2
Add missing values to defaultMessage string
mattnowzari May 8, 2026
7594fef
Merge branch 'main' into fix_snowflake_i18n_angle_brackets
mattnowzari May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...platform/packages/shared/kbn-connector-specs/src/specs/microsoft_teams/microsoft_teams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export const MicrosoftTeams: ConnectorSpec = {
'core.kibanaConnectorSpecs.microsoftTeams.auth.oauthAuthCode.authorizationUrl.helpText',
{
defaultMessage:
"Replace ''{tenantId}'' with your Azure AD tenant ID. For example: https://login.microsoftonline.com/your-tenant-id/oauth2/v2.0/authorize",
"Replace '{tenantId}' with your Azure AD tenant ID. For example: https://login.microsoftonline.com/your-tenant-id/oauth2/v2.0/authorize",
values: { tenantId: '{tenant-id}' },
}
),
Expand All @@ -109,7 +109,7 @@ export const MicrosoftTeams: ConnectorSpec = {
'core.kibanaConnectorSpecs.microsoftTeams.auth.oauthAuthCode.tokenUrl.helpText',
{
defaultMessage:
"Replace ''{tenantId}'' with your Azure AD tenant ID. For example: https://login.microsoftonline.com/your-tenant-id/oauth2/v2.0/token",
"Replace '{tenantId}' with your Azure AD tenant ID. For example: https://login.microsoftonline.com/your-tenant-id/oauth2/v2.0/token",
values: { tenantId: '{tenant-id}' },
}
),
Expand All @@ -135,7 +135,7 @@ export const MicrosoftTeams: ConnectorSpec = {
'core.kibanaConnectorSpecs.microsoftTeams.auth.oauth.tokenUrl.helpText',
{
defaultMessage:
"Replace ''{tenantId}'' with your Azure AD tenant ID. For example: https://login.microsoftonline.com/your-tenant-id/oauth2/v2.0/token",
"Replace '{tenantId}' with your Azure AD tenant ID. For example: https://login.microsoftonline.com/your-tenant-id/oauth2/v2.0/token",
values: { tenantId: '{tenant-id}' },
}
),
Expand Down
2 changes: 1 addition & 1 deletion ...form/packages/shared/kbn-connector-specs/src/specs/sharepoint_online/sharepoint_online.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const SharepointOnline: ConnectorSpec = {
'core.kibanaConnectorSpecs.sharepointOnline.auth.oauth.tokenUrl.helpText',
{
defaultMessage:
"Replace ''{tenantId}'' with your Azure AD tenant ID. For example: https://login.microsoftonline.com/your-tenant-id/oauth2/v2.0/token",
"Replace '{tenantId}' with your Azure AD tenant ID. For example: https://login.microsoftonline.com/your-tenant-id/oauth2/v2.0/token",
values: { tenantId: '{tenant-id}' },
}
),
Expand Down
9 changes: 6 additions & 3 deletions src/platform/packages/shared/kbn-connector-specs/src/specs/snowflake/snowflake.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,17 +228,20 @@ export const Snowflake: ConnectorSpec = {
overrides: {
meta: {
authorizationUrl: {
placeholder: 'https://<account>.snowflakecomputing.com/oauth/authorize',
placeholder: 'https://{account}.snowflakecomputing.com/oauth/authorize',
helpText: i18n.translate(
'core.kibanaConnectorSpecs.snowflake.auth.oauth.authorizationUrl.helpText',
{
defaultMessage:
'Snowflake OAuth authorization URL. Replace <account> with your Snowflake account identifier.',
"Snowflake OAuth authorization URL. Replace '{account}' with your Snowflake account identifier.",
Copy link
Copy Markdown
Contributor

@lorenabalan lorenabalan May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need a values: {...} here as well?

Copy link
Copy Markdown
Contributor Author

@mattnowzari mattnowzari May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @lorenabalan - I'm not sure I quite follow what you mean here?

Copy link
Copy Markdown
Contributor

@lorenabalan lorenabalan May 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comparing to src/platform/packages/shared/kbn-connector-specs/src/specs/sharepoint_online/sharepoint_online.ts for example. We pass

{
    defaultMessage: ...,
    values: {...},
}

otherwise I'm not sure if it's formatted correctly, doesn't it expect an account variable to plugin into the format string?

values: {
accountPlaceholder: '{account}',
},
}
),
},
tokenUrl: {
placeholder: 'https://<account>.snowflakecomputing.com/oauth/token-request',
placeholder: 'https://{account}.snowflakecomputing.com/oauth/token-request',
helpText: i18n.translate(
'core.kibanaConnectorSpecs.snowflake.auth.oauth.tokenUrl.helpText',
{
Expand Down
Loading