[One Workflow] Unskip Workflow editor: validation performance tests by dej611 · Pull Request #268149 · elastic/kibana

dej611 · 2026-05-07T11:06:06Z

Summary

Checklist

Unit or functional tests were updated or added to match the most common scenarios

kibanamachine · 2026-05-07T14:14:23Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#12159

[❌] src/platform/plugins/shared/workflows_management/test/scout_workflows_ui/ui/parallel.playwright.config.ts (--arch stateful --domain classic): 47/50 tests passed.
[✅] src/platform/plugins/shared/workflows_management/test/scout_workflows_ui/ui/parallel.playwright.config.ts (--arch serverless --domain observability_complete): 50/50 tests passed.
[❌] src/platform/plugins/shared/workflows_management/test/scout_workflows_ui/ui/parallel.playwright.config.ts (--arch serverless --domain security_complete): 47/50 tests passed.
[✅] src/platform/plugins/shared/workflows_management/test/scout_workflows_ui/ui/parallel.playwright.config.ts (--arch serverless --domain search): 50/50 tests passed.
[✅] src/platform/plugins/shared/workflows_management/test/scout_workflows_ui/ui/parallel.playwright.config.ts (--arch serverless --domain observability_logs_essentials): 50/50 tests passed.

see run history

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Re-enables the Workflow editor validation performance tests and optimizes YAML marker formatting by avoiding repeated YAML parses during marker update bursts.

Changes:

Unskips the workflow editor validation performance test suite (fix for #261213).
Caches parsed YAML documents per Monaco model version to reduce repeated parseDocument() calls during marker updates.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`src/platform/plugins/shared/workflows_management/test/scout_workflows_ui/ui/parallel_tests/workflow_editor_perf.spec.ts`	Unskips the previously skipped validation performance test suite.
`src/platform/plugins/shared/workflows_management/public/features/validate_workflow_yaml/lib/use_monaco_markers_changed_interceptor.ts`	Adds a version-based cache to reuse a single YAML parse across multiple marker callbacks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dej611 · 2026-05-08T10:15:06Z

+  // yamlDocumentRef lags the model by the 500ms Redux compute debounce, so formatMonacoYamlMarker
+  // needs a parse matching the current model. Cache by versionId so multiple setModelMarkers
+  // bursts within the same version share one parse instead of reparsing per marker callback.
+  const freshYamlDocCacheRef = useRef<{ versionId: number; doc: YAML.Document } | null>(null);


Integrated feedback with 6658963

h88 · 2026-05-07T14:19:51Z

+      const versionId = editorModel.getVersionId();
+      const cached = freshYamlDocCacheRef.current;
+      const freshYamlDocument =
+        cached && cached.versionId === versionId
+          ? cached.doc
+          : parseDocument(editorModel.getValue());
+      if (cached?.versionId !== versionId) {
+        freshYamlDocCacheRef.current = { versionId, doc: freshYamlDocument };
+      }


dup comment

h88

1 non-blocking comment + worth reviewing the flaky pipeline to see if it's related to the enabled spec

kibanamachine · 2026-05-08T11:24:30Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 6658963

Failed CI Steps

Test Failures

[job] [logs] Scout Lane #21 - serverless-observability_complete / default / local-serverless-observability_complete - Serverless Observability Navigation - Complete tier body - clicking body nav items sets the active link, updates breadcrumbs, and navigates
[job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - APM integration not installed but setup completed - Admin user
[job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Collector integration is not installed - collector integration missing
[job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Collector integration is not installed - Symbolizer integration is not installed
[job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Observability Landing Page (discover.isEsqlDefault enabled) - redirects to onboarding when no logs data exists
[job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Profiling is setup and data is loaded - Admin user
[job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Profiling is setup and data is loaded - Viewer user
[job] [logs] FTR Configs #2 / task_manager scheduling and running tasks should schedule tasks with API keys if request is provided

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`workflowsManagement`	2.3MB	2.3MB	+706.0B

History

💛 Build #439340 was flaky 7253f3b

kibanamachine · 2026-05-08T13:30:51Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#12201

see run history

kibanamachine · 2026-05-08T15:08:16Z

Starting backport for target branches: 9.4

https://github.com/elastic/kibana/actions/runs/25563121152

kibanamachine · 2026-05-08T15:17:19Z

💔 All backports failed

Status	Branch	Result
❌	9.4	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 268149

Questions ?

Please refer to the Backport tool documentation

…lastic#268149) ## Summary Fixes elastic#261213 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

kibanamachine · 2026-05-12T15:49:56Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 268149 locally
cc: @dej611

kibanamachine · 2026-05-13T16:48:55Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 268149 locally
cc: @dej611

kibanamachine · 2026-05-14T17:48:33Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 268149 locally
cc: @dej611

dej611 added 2 commits May 7, 2026 12:31

⚡ cache model

b66d87d

✅ Restore test

7253f3b

dej611 added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels Team:One Workflow Team label for One Workflow (Workflow automation) v9.5.0 v9.4.1 labels May 7, 2026

dej611 marked this pull request as ready for review May 7, 2026 13:11

dej611 requested a review from a team as a code owner May 7, 2026 13:11

h88 requested a review from Copilot May 7, 2026 14:13

Copilot AI reviewed May 7, 2026

View reviewed changes

h88 approved these changes May 7, 2026

View reviewed changes

♻️ Rework the memoize logic to be more precise

6658963

dej611 merged commit cbad667 into elastic:main May 8, 2026
45 checks passed

This was referenced May 8, 2026

Fix broken translation string #268460

Merged

[APM][Scout] Stabilize service map embeddable test panel time range #268459

Merged

Replace <account> with {account} in i18n strings #267775

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 12, 2026

github-actions Bot mentioned this pull request May 13, 2026

Failing test: Workflow editor: validation performance - [infosec_demo (150 steps, 361 vars)] frame rate stays above threshold during rapid edits #261189

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[One Workflow] Unskip Workflow editor: validation performance tests#268149

[One Workflow] Unskip Workflow editor: validation performance tests#268149
dej611 merged 3 commits into
elastic:mainfrom
dej611:fix/261213

dej611 commented May 7, 2026 •

edited by kibanamachine

Loading

Uh oh!

kibanamachine commented May 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

dej611 May 8, 2026

Uh oh!

h88 May 7, 2026

Uh oh!

h88 left a comment

Uh oh!

kibanamachine commented May 8, 2026

Uh oh!

kibanamachine commented May 8, 2026

Uh oh!

Uh oh!

kibanamachine commented May 8, 2026

Uh oh!

kibanamachine commented May 8, 2026

Uh oh!

kibanamachine commented May 12, 2026

Uh oh!

kibanamachine commented May 13, 2026

Uh oh!

kibanamachine commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dej611 commented May 7, 2026 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

kibanamachine commented May 7, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#12159

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

dej611 May 8, 2026

Choose a reason for hiding this comment

Uh oh!

h88 May 7, 2026

Choose a reason for hiding this comment

Uh oh!

h88 left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented May 8, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

History

Uh oh!

kibanamachine commented May 8, 2026

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#12201

Uh oh!

Uh oh!

kibanamachine commented May 8, 2026

Uh oh!

kibanamachine commented May 8, 2026

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented May 12, 2026

Uh oh!

kibanamachine commented May 13, 2026

Uh oh!

kibanamachine commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dej611 commented May 7, 2026 •

edited by kibanamachine

Loading