Add aria-hidden={true} to decorative EuiIcon instances#268367
Merged
Conversation
6 tasks
Fixes @elastic/eui/icon-accessibility-rules violations in: - swap_duplicate_combine.tsx: icon next to visible label text - status.tsx: 4 status icons next to visible status text labels Agent-Logs-Url: https://github.com/elastic/kibana/sessions/dc7aa275-7493-4e20-9ac8-57ad21c87a89 Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix
Add May 8, 2026
@elastic/eui/icon-accessibility-rules lint violationsaria-hidden={true} to decorative EuiIcon instances
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
|
/ci |
alexwizp
approved these changes
May 8, 2026
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @alexwizp @Copilot |
nickofthyme
approved these changes
May 8, 2026
Contributor
|
Starting backport for target branches: 9.3, 9.4 https://github.com/elastic/kibana/actions/runs/25568930850 |
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced May 8, 2026
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
@elastic/eui/icon-accessibility-ruleslint violations across 2 files. All icons are decorative—adjacent visible text already conveys the meaning.swap_duplicate_combine.tsx: Icon sits next to the drop target label (Duplicate/Swap/Combine)status.tsx: Four status icons (clock, error ×2, checkCircleFill) sit next to status text labelsWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ci-stats.kibana.dev/home/REDACTED/.nvm/versions/node/v24.14.1/bin/node /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node scripts/yarn_install_scripts.js run ldd 0.8.2(dns block)/home/REDACTED/.nvm/versions/node/v24.14.1/bin/node /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node scripts/kbn bootstrap(dns block)/home/REDACTED/.nvm/versions/node/v24.14.1/bin/node node scripts/eslint src/platform/packages/shared/kbn-dom-drag-drop/src/drop_targets/swap_duplicate_combine.tsx src/platform/plugins/shared/data/public/search/session/sessions_mgmt/components/status.tsx s/li��(dns block)clients3.google.com/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.8.2(dns block)detectportal.firefox.com/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.8.2(dns block)google.com/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.8.2(dns block)googlechromelabs.github.io/home/REDACTED/.nvm/versions/node/v24.14.1/bin/node /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node install.js dd ldd b/li�� swap_duplicate_combine.tsx mgmt/components/status.tsx ode_modules/.bin/ldd(dns block)iojs.org/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -(dns block)If you need me to access, download, or install something from one of these locations, you can either: