Skip to content

Add aria-hidden={true} to decorative EuiIcon instances#268367

Merged
alexwizp merged 4 commits into
mainfrom
copilot/fix-eslint-icon-accessibility-violations
May 8, 2026
Merged

Add aria-hidden={true} to decorative EuiIcon instances#268367
alexwizp merged 4 commits into
mainfrom
copilot/fix-eslint-icon-accessibility-violations

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

Fixes @elastic/eui/icon-accessibility-rules lint violations across 2 files. All icons are decorative—adjacent visible text already conveys the meaning.

  • swap_duplicate_combine.tsx: Icon sits next to the drop target label (Duplicate/Swap/Combine)
  • status.tsx: Four status icons (clock, error ×2, checkCircleFill) sit next to status text labels
// Before
<EuiIcon size="m" type={icon} />

// After
<EuiIcon size="m" type={icon} aria-hidden={true} />

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • ci-stats.kibana.dev
    • Triggering command: /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node scripts/yarn_install_scripts.js run ldd 0.8.2 (dns block)
    • Triggering command: /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node scripts/kbn bootstrap (dns block)
    • Triggering command: /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node node scripts/eslint src/platform/packages/shared/kbn-dom-drag-drop/src/drop_targets/swap_duplicate_combine.tsx src/platform/plugins/shared/data/public/search/session/sessions_mgmt/components/status.tsx s/li�� (dns block)
  • clients3.google.com
    • Triggering command: /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.8.2 (dns block)
  • detectportal.firefox.com
    • Triggering command: /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.8.2 (dns block)
  • google.com
    • Triggering command: /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.8.2 (dns block)
  • googlechromelabs.github.io
    • Triggering command: /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node install.js dd ldd b/li�� swap_duplicate_combine.tsx mgmt/components/status.tsx ode_modules/.bin/ldd (dns block)
  • iojs.org
    • Triggering command: /usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o - (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Fixes @elastic/eui/icon-accessibility-rules violations in:
- swap_duplicate_combine.tsx: icon next to visible label text
- status.tsx: 4 status icons next to visible status text labels

Agent-Logs-Url: https://github.com/elastic/kibana/sessions/dc7aa275-7493-4e20-9ac8-57ad21c87a89

Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix @elastic/eui/icon-accessibility-rules lint violations Add aria-hidden={true} to decorative EuiIcon instances May 8, 2026
Copilot AI requested a review from alexwizp May 8, 2026 09:57
@alexwizp alexwizp marked this pull request as ready for review May 8, 2026 10:05
@alexwizp alexwizp requested review from a team as code owners May 8, 2026 10:06
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@alexwizp alexwizp added a11y:agent-pr PR has been created by the agent backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes labels May 8, 2026
@alexwizp
Copy link
Copy Markdown
Contributor

alexwizp commented May 8, 2026

/ci

@alexwizp alexwizp added release_note:fix release_note:skip Skip the PR/issue when compiling release notes and removed release_note:skip Skip the PR/issue when compiling release notes release_note:fix labels May 8, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Scout Lane #8 - stateful-classic / default / local-stateful-classic - APM integration not installed but setup completed - Admin user
  • [job] [logs] Scout Lane #8 - stateful-classic / default / local-stateful-classic - Collector integration is not installed - collector integration missing
  • [job] [logs] Scout Lane #8 - stateful-classic / default / local-stateful-classic - Collector integration is not installed - Symbolizer integration is not installed
  • [job] [logs] Scout Lane #8 - stateful-classic / default / local-stateful-classic - Maps - maps telemetry - should return the correct telemetry values for map saved objects
  • [job] [logs] Scout Lane #8 - stateful-classic / default / local-stateful-classic - Observability Landing Page (discover.isEsqlDefault enabled) - redirects to onboarding when no logs data exists
  • [job] [logs] Scout Lane #8 - stateful-classic / default / local-stateful-classic - Profiling is setup and data is loaded - Admin user
  • [job] [logs] Scout Lane #8 - stateful-classic / default / local-stateful-classic - Profiling is setup and data is loaded - Viewer user

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
eventAnnotationListing 208.7KB 208.7KB +17.0B
lens 2.1MB 2.1MB +17.0B
total +34.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 444.6KB 444.7KB +68.0B

History

cc @alexwizp @Copilot

@alexwizp alexwizp merged commit 3400fa4 into main May 8, 2026
64 checks passed
@alexwizp alexwizp deleted the copilot/fix-eslint-icon-accessibility-violations branch May 8, 2026 17:11
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.3, 9.4

https://github.com/elastic/kibana/actions/runs/25568930850

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
9.3 Backport failed because of merge conflicts
9.4

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 268367

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @alexwizp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y:agent-pr PR has been created by the agent backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels 💝community Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v9.3.5 v9.4.0 v9.5.0

Projects

None yet

4 participants