[SLO] Fix APM embeddable ids#264750
Merged
AlejandroFrndz merged 1 commit intoelastic:mainfrom Apr 22, 2026
Merged
Conversation
AlejandroFrndz
added
release_note:skip
Contributor
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
AlejandroFrndz
commented
Apr 21, 2026
Comment on lines
-21
to
-22
| | 'APM_THROUGHPUT_CHART_EMBEDDABLE' | ||
| | 'APM_LATENCY_CHART_EMBEDDABLE' |
Contributor
Author
There was a problem hiding this comment.
I couldn't find an equivalent for these 2 ids so I'd say they don't exist anymore. And anyway, they weren't being used so I just removed them from the union type
Contributor
ApprovabilityVerdict: Needs human review This PR changes embeddable ID strings that affect runtime behavior - the actual IDs passed to load APM chart embeddables are being modified. The author does not own these files (owned by @elastic/actionable-obs-team), and the author's own comment expresses uncertainty about removing two IDs. The designated code owners should verify these new ID values match the expected embeddable registrations. You can customize Macroscope's approvability policy. Learn more. |
fkanout
approved these changes
Apr 21, 2026
tfcmarques
approved these changes
Apr 21, 2026
Contributor
tfcmarques
left a comment
tfcmarques
left a comment
There was a problem hiding this comment.
Thanks for working on this 🙇🏼
Contributor
Author
|
/ci |
Contributor
|
Starting backport for target branches: 9.4 https://github.com/elastic/kibana/actions/runs/24767813660 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 22, 2026
# Backport This will backport the following commits from `main` to `9.4`: - [[SLO] Fix APM embeddable ids (#264750)](#264750) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alex Fernandez","email":"47327793+AlejandroFrndz@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-04-22T08:15:11Z","message":"[SLO] Fix APM embeddable ids (#264750)\n\n## Summary\n\nCloses #264008\n\nAs part of the dashboards as code effort, #254079 introduced a change by\nwhich embeddable ids were changed. While most usages were properly\nupdated, a couple of hardcoded string references in the SLO plugin were\nleft unchanged. This is leading to issues where the APM embeddables in\nthe alert details page are failing to be displayed because the code is\nunable to find the appropiate embeddable factory when searching by it's\nold id.\n\nIn order to prevent issues like this in the future, I plan to do a\nfollow up PR providing a proper fix to this issue in a way that allows\nthe SLO plugin to consume the embeddable id constants defined in APM\ninstead of having to relay on redefining the strings values in both\nplugins, which can lead to inconsistencies as this one. But, given the\ntiming with the 9.4 BC I've decided to go first for this quick-and-easy\napproach of just changing the strings in the SLO plugin as well. While\nthis is not ideal code-wise it will allow us to have a low-risk fix in\ntime to be backported to 9.4 so we don't ship this view in a broken\nstate.","sha":"1463b9b352d82c8b43b3e3df2792a7c871e3bf19","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.4.0","Team:obs-presentation","v9.5.0"],"title":"[SLO] Fix APM embeddable ids","number":264750,"url":"https://github.com/elastic/kibana/pull/264750","mergeCommit":{"message":"[SLO] Fix APM embeddable ids (#264750)\n\n## Summary\n\nCloses #264008\n\nAs part of the dashboards as code effort, #254079 introduced a change by\nwhich embeddable ids were changed. While most usages were properly\nupdated, a couple of hardcoded string references in the SLO plugin were\nleft unchanged. This is leading to issues where the APM embeddables in\nthe alert details page are failing to be displayed because the code is\nunable to find the appropiate embeddable factory when searching by it's\nold id.\n\nIn order to prevent issues like this in the future, I plan to do a\nfollow up PR providing a proper fix to this issue in a way that allows\nthe SLO plugin to consume the embeddable id constants defined in APM\ninstead of having to relay on redefining the strings values in both\nplugins, which can lead to inconsistencies as this one. But, given the\ntiming with the 9.4 BC I've decided to go first for this quick-and-easy\napproach of just changing the strings in the SLO plugin as well. While\nthis is not ideal code-wise it will allow us to have a low-risk fix in\ntime to be backported to 9.4 so we don't ship this view in a broken\nstate.","sha":"1463b9b352d82c8b43b3e3df2792a7c871e3bf19"}},"sourceBranch":"main","suggestedTargetBranches":["9.4"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/264750","number":264750,"mergeCommit":{"message":"[SLO] Fix APM embeddable ids (#264750)\n\n## Summary\n\nCloses #264008\n\nAs part of the dashboards as code effort, #254079 introduced a change by\nwhich embeddable ids were changed. While most usages were properly\nupdated, a couple of hardcoded string references in the SLO plugin were\nleft unchanged. This is leading to issues where the APM embeddables in\nthe alert details page are failing to be displayed because the code is\nunable to find the appropiate embeddable factory when searching by it's\nold id.\n\nIn order to prevent issues like this in the future, I plan to do a\nfollow up PR providing a proper fix to this issue in a way that allows\nthe SLO plugin to consume the embeddable id constants defined in APM\ninstead of having to relay on redefining the strings values in both\nplugins, which can lead to inconsistencies as this one. But, given the\ntiming with the 9.4 BC I've decided to go first for this quick-and-easy\napproach of just changing the strings in the SLO plugin as well. While\nthis is not ideal code-wise it will allow us to have a low-risk fix in\ntime to be backported to 9.4 so we don't ship this view in a broken\nstate.","sha":"1463b9b352d82c8b43b3e3df2792a7c871e3bf19"}}]}] BACKPORT--> Co-authored-by: Alex Fernandez <47327793+AlejandroFrndz@users.noreply.github.com>
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Apr 22, 2026
…sationChanges23 * commit '9a7b717c662d1c904052bc59f0e5a81daab87c7f': (145 commits) Upgrade EUI to v114.2.0 (elastic#264550) [Entity Analytics] Add missing OpenAPI descriptions and examples to p… (elastic#264778) [Entity Resolution] Clarify CSV upload result for already-linked entities (elastic#264689) [AI Infra] Fix failing GenAI Settings Scout tests (elastic#260496) [Agent Builder] [Bug Bash] OAuth connector settings mention fields that are not there (elastic#264756) [performance] process-wide cache for advanced settings lookup (elastic#262618) [CI] Update limits.yml for securitySolution (elastic#264946) [SLO] Fix APM embeddable ids (elastic#264750) [EDR Workflows] Unify artifacts empty state buttons (elastic#264389) [Alert Triage workflow] Adds security.buildAlertEntityGraph and security.renderAlertNarrative… (elastic#259159) [SigEvents] Add KI feature identification endpoints and refactor task to use shared service (elastic#263528) [Scout] Migrate Data Views API tests from FTR - Part5 (elastic#264088) [Cases] Apply shared extended_fields path util server side (elastic#264706) [Lens as code] Fix metric trendline (elastic#264777) [api-docs] 2026-04-22 Daily api_docs build (elastic#264882) [Scout] Update test config manifests (elastic#264575) [workflows_management] Lazy-load Zod connector schemas to cut idle memory (elastic#264283) [ES|QL] Fix ES|QL columns reset race during active fetch (elastic#263947) [Content List] Column layout props, sticky actions, and title click handlers (elastic#264203) [Lens as code] Validate `id` in route for new vis types (elastic#264480) ...
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Apr 27, 2026
## Summary Closes elastic#264008 As part of the dashboards as code effort, elastic#254079 introduced a change by which embeddable ids were changed. While most usages were properly updated, a couple of hardcoded string references in the SLO plugin were left unchanged. This is leading to issues where the APM embeddables in the alert details page are failing to be displayed because the code is unable to find the appropiate embeddable factory when searching by it's old id. In order to prevent issues like this in the future, I plan to do a follow up PR providing a proper fix to this issue in a way that allows the SLO plugin to consume the embeddable id constants defined in APM instead of having to relay on redefining the strings values in both plugins, which can lead to inconsistencies as this one. But, given the timing with the 9.4 BC I've decided to go first for this quick-and-easy approach of just changing the strings in the SLO plugin as well. While this is not ideal code-wise it will allow us to have a low-risk fix in time to be backported to 9.4 so we don't ship this view in a broken state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #264008
As part of the dashboards as code effort, #254079 introduced a change by which embeddable ids were changed. While most usages were properly updated, a couple of hardcoded string references in the SLO plugin were left unchanged. This is leading to issues where the APM embeddables in the alert details page are failing to be displayed because the code is unable to find the appropiate embeddable factory when searching by it's old id.
In order to prevent issues like this in the future, I plan to do a follow up PR providing a proper fix to this issue in a way that allows the SLO plugin to consume the embeddable id constants defined in APM instead of having to relay on redefining the strings values in both plugins, which can lead to inconsistencies as this one. But, given the timing with the 9.4 BC I've decided to go first for this quick-and-easy approach of just changing the strings in the SLO plugin as well. While this is not ideal code-wise it will allow us to have a low-risk fix in time to be backported to 9.4 so we don't ship this view in a broken state.