[EDR Workflows] Unify artifacts empty state buttons#264389
Merged
gergoabraham merged 5 commits intoelastic:mainfrom Apr 22, 2026
Merged
[EDR Workflows] Unify artifacts empty state buttons#264389gergoabraham merged 5 commits intoelastic:mainfrom
gergoabraham merged 5 commits intoelastic:mainfrom
Conversation
gergoabraham
added
release_note:skip
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
tomsonpl
approved these changes
Apr 21, 2026
Contributor
tomsonpl
left a comment
tomsonpl
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for the unifying this :)
ashokaditya
approved these changes
Apr 22, 2026
Contributor
Author
|
@coderabbitai help |
Contributor
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
Status, support, documentation and community
|
Contributor
|
Starting backport for target branches: 9.4 https://github.com/elastic/kibana/actions/runs/24766617127 |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 22, 2026
…264931) # Backport This will backport the following commits from `main` to `9.4`: - [[EDR Workflows] Unify artifacts empty state buttons (#264389)](#264389) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2026-04-22T07:45:13Z","message":"[EDR Workflows] Unify artifacts empty state buttons (#264389)\n\n## Summary\n\nAs now we're adding a new secondary button for artifact _Import_ to the\nempty state pages of Artifact page and Policy details page, this PR aims\nto unify the UI a bit.\n\n- [x] 'Add artifact' button and 'Import artifacts' empty button are now\nvertically aligned on **Artifacts** page's empty state\n<img width=\"600\" alt=\"artifacts\"\nsrc=\"https://github.com/user-attachments/assets/ccd94868-8521-4ffa-81f8-d2fb8016d4cb\"\n/>\n\n\n- [x] Same vertical alignment on **Policy details** page's artifact tabs\n<img width=\"600\" alt=\"policy details\"\nsrc=\"https://github.com/user-attachments/assets/e605b047-d889-46e6-82bf-b336d7273cda\"\n/>\n\n- [x] When arriving to **Artifacts** page from **Policy details** page,\nthe (now) 3rd button is changed to a simple link\n<img width=\"600\" alt=\"bakc\"\nsrc=\"https://github.com/user-attachments/assets/a6fe0f98-5088-4e76-a111-485261c87da1\"\n/>\n\n- [x] On **Policy details** page's 'artifacts exist, but they are not\nassigned' empty state the old 'Manage artifacts' link is changed to an\nempty button to harmonize with the new Import button\n<img width=\"600\" alt=\"manage\"\nsrc=\"https://github.com/user-attachments/assets/8d20e532-ca97-41dd-b201-57624457df91\"\n/>\n\n\n## Testing\n\nTo see the Import button, enable the following feature flag:\n```\nxpack.securitySolution.enableExperimental:\n - endpointExceptionsMovedUnderManagement\n```","sha":"c5cbc5f7312d5e1221ad115133085a351b72644e","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:version","v9.4.0","v9.5.0"],"title":"[EDR Workflows] Unify artifacts empty state buttons","number":264389,"url":"https://github.com/elastic/kibana/pull/264389","mergeCommit":{"message":"[EDR Workflows] Unify artifacts empty state buttons (#264389)\n\n## Summary\n\nAs now we're adding a new secondary button for artifact _Import_ to the\nempty state pages of Artifact page and Policy details page, this PR aims\nto unify the UI a bit.\n\n- [x] 'Add artifact' button and 'Import artifacts' empty button are now\nvertically aligned on **Artifacts** page's empty state\n<img width=\"600\" alt=\"artifacts\"\nsrc=\"https://github.com/user-attachments/assets/ccd94868-8521-4ffa-81f8-d2fb8016d4cb\"\n/>\n\n\n- [x] Same vertical alignment on **Policy details** page's artifact tabs\n<img width=\"600\" alt=\"policy details\"\nsrc=\"https://github.com/user-attachments/assets/e605b047-d889-46e6-82bf-b336d7273cda\"\n/>\n\n- [x] When arriving to **Artifacts** page from **Policy details** page,\nthe (now) 3rd button is changed to a simple link\n<img width=\"600\" alt=\"bakc\"\nsrc=\"https://github.com/user-attachments/assets/a6fe0f98-5088-4e76-a111-485261c87da1\"\n/>\n\n- [x] On **Policy details** page's 'artifacts exist, but they are not\nassigned' empty state the old 'Manage artifacts' link is changed to an\nempty button to harmonize with the new Import button\n<img width=\"600\" alt=\"manage\"\nsrc=\"https://github.com/user-attachments/assets/8d20e532-ca97-41dd-b201-57624457df91\"\n/>\n\n\n## Testing\n\nTo see the Import button, enable the following feature flag:\n```\nxpack.securitySolution.enableExperimental:\n - endpointExceptionsMovedUnderManagement\n```","sha":"c5cbc5f7312d5e1221ad115133085a351b72644e"}},"sourceBranch":"main","suggestedTargetBranches":["9.4"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/264389","number":264389,"mergeCommit":{"message":"[EDR Workflows] Unify artifacts empty state buttons (#264389)\n\n## Summary\n\nAs now we're adding a new secondary button for artifact _Import_ to the\nempty state pages of Artifact page and Policy details page, this PR aims\nto unify the UI a bit.\n\n- [x] 'Add artifact' button and 'Import artifacts' empty button are now\nvertically aligned on **Artifacts** page's empty state\n<img width=\"600\" alt=\"artifacts\"\nsrc=\"https://github.com/user-attachments/assets/ccd94868-8521-4ffa-81f8-d2fb8016d4cb\"\n/>\n\n\n- [x] Same vertical alignment on **Policy details** page's artifact tabs\n<img width=\"600\" alt=\"policy details\"\nsrc=\"https://github.com/user-attachments/assets/e605b047-d889-46e6-82bf-b336d7273cda\"\n/>\n\n- [x] When arriving to **Artifacts** page from **Policy details** page,\nthe (now) 3rd button is changed to a simple link\n<img width=\"600\" alt=\"bakc\"\nsrc=\"https://github.com/user-attachments/assets/a6fe0f98-5088-4e76-a111-485261c87da1\"\n/>\n\n- [x] On **Policy details** page's 'artifacts exist, but they are not\nassigned' empty state the old 'Manage artifacts' link is changed to an\nempty button to harmonize with the new Import button\n<img width=\"600\" alt=\"manage\"\nsrc=\"https://github.com/user-attachments/assets/8d20e532-ca97-41dd-b201-57624457df91\"\n/>\n\n\n## Testing\n\nTo see the Import button, enable the following feature flag:\n```\nxpack.securitySolution.enableExperimental:\n - endpointExceptionsMovedUnderManagement\n```","sha":"c5cbc5f7312d5e1221ad115133085a351b72644e"}}]}] BACKPORT--> Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Apr 22, 2026
…sationChanges23 * commit '9a7b717c662d1c904052bc59f0e5a81daab87c7f': (145 commits) Upgrade EUI to v114.2.0 (elastic#264550) [Entity Analytics] Add missing OpenAPI descriptions and examples to p… (elastic#264778) [Entity Resolution] Clarify CSV upload result for already-linked entities (elastic#264689) [AI Infra] Fix failing GenAI Settings Scout tests (elastic#260496) [Agent Builder] [Bug Bash] OAuth connector settings mention fields that are not there (elastic#264756) [performance] process-wide cache for advanced settings lookup (elastic#262618) [CI] Update limits.yml for securitySolution (elastic#264946) [SLO] Fix APM embeddable ids (elastic#264750) [EDR Workflows] Unify artifacts empty state buttons (elastic#264389) [Alert Triage workflow] Adds security.buildAlertEntityGraph and security.renderAlertNarrative… (elastic#259159) [SigEvents] Add KI feature identification endpoints and refactor task to use shared service (elastic#263528) [Scout] Migrate Data Views API tests from FTR - Part5 (elastic#264088) [Cases] Apply shared extended_fields path util server side (elastic#264706) [Lens as code] Fix metric trendline (elastic#264777) [api-docs] 2026-04-22 Daily api_docs build (elastic#264882) [Scout] Update test config manifests (elastic#264575) [workflows_management] Lazy-load Zod connector schemas to cut idle memory (elastic#264283) [ES|QL] Fix ES|QL columns reset race during active fetch (elastic#263947) [Content List] Column layout props, sticky actions, and title click handlers (elastic#264203) [Lens as code] Validate `id` in route for new vis types (elastic#264480) ...
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Apr 27, 2026
## Summary As now we're adding a new secondary button for artifact _Import_ to the empty state pages of Artifact page and Policy details page, this PR aims to unify the UI a bit. - [x] 'Add artifact' button and 'Import artifacts' empty button are now vertically aligned on **Artifacts** page's empty state <img width="600" alt="artifacts" src="https://github.com/user-attachments/assets/ccd94868-8521-4ffa-81f8-d2fb8016d4cb" /> - [x] Same vertical alignment on **Policy details** page's artifact tabs <img width="600" alt="policy details" src="https://github.com/user-attachments/assets/e605b047-d889-46e6-82bf-b336d7273cda" /> - [x] When arriving to **Artifacts** page from **Policy details** page, the (now) 3rd button is changed to a simple link <img width="600" alt="bakc" src="https://github.com/user-attachments/assets/a6fe0f98-5088-4e76-a111-485261c87da1" /> - [x] On **Policy details** page's 'artifacts exist, but they are not assigned' empty state the old 'Manage artifacts' link is changed to an empty button to harmonize with the new Import button <img width="600" alt="manage" src="https://github.com/user-attachments/assets/8d20e532-ca97-41dd-b201-57624457df91" /> ## Testing To see the Import button, enable the following feature flag: ``` xpack.securitySolution.enableExperimental: - endpointExceptionsMovedUnderManagement ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As now we're adding a new secondary button for artifact Import to the empty state pages of Artifact page and Policy details page, this PR aims to unify the UI a bit.
'Add artifact' button and 'Import artifacts' empty button are now vertically aligned on Artifacts page's empty state
Same vertical alignment on Policy details page's artifact tabs
When arriving to Artifacts page from Policy details page, the (now) 3rd button is changed to a simple link
On Policy details page's 'artifacts exist, but they are not assigned' empty state the old 'Manage artifacts' link is changed to an empty button to harmonize with the new Import button
Testing
To see the Import button, enable the following feature flag: