[Content List] Column layout props, sticky actions, and title click handlers#264203
Merged
clintandrewhall merged 5 commits intoApr 22, 2026
Merged
Conversation
ddd8d30 to
059213b
Compare
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
kowalczyk-krzysztof
approved these changes
Apr 21, 2026
Member
kowalczyk-krzysztof
left a comment
There was a problem hiding this comment.
Left some nitpick comments, otherwise LGTM
…eMap comment. - Rename `useHref` prop to `shouldUseHref` across `NameCellTitle`, `NameCell`, and `NameColumnProps` to avoid misleading React hook naming convention. - Update comment on `defaultWidth` calculation in `buildActionsColumn` to reference `euiButtonSizeMap`'s `xs.height` (`euiTheme.size.l`) as the source of the 24px constant.
57c212c to
7acde4d
Compare
… undefined.
When `shouldUseHref={true}` but `getHref` is absent or returns `undefined`,
the early-return guard was checking the `useHref` flag instead of whether
`href` actually resolved to a value. A Cmd/Ctrl-click would exit early with
no URL to follow and `onClick` never called. Change the guard to `if (href &&
!isPlainPrimaryClick(event))` so the pass-through only fires when there is a
real href. Adds a regression test for the no-href path.
9a0deb8 to
3ce035c
Compare
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Public APIs missing comments
Public APIs missing exports
|
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Apr 22, 2026
…sationChanges23 * commit '9a7b717c662d1c904052bc59f0e5a81daab87c7f': (145 commits) Upgrade EUI to v114.2.0 (elastic#264550) [Entity Analytics] Add missing OpenAPI descriptions and examples to p… (elastic#264778) [Entity Resolution] Clarify CSV upload result for already-linked entities (elastic#264689) [AI Infra] Fix failing GenAI Settings Scout tests (elastic#260496) [Agent Builder] [Bug Bash] OAuth connector settings mention fields that are not there (elastic#264756) [performance] process-wide cache for advanced settings lookup (elastic#262618) [CI] Update limits.yml for securitySolution (elastic#264946) [SLO] Fix APM embeddable ids (elastic#264750) [EDR Workflows] Unify artifacts empty state buttons (elastic#264389) [Alert Triage workflow] Adds security.buildAlertEntityGraph and security.renderAlertNarrative… (elastic#259159) [SigEvents] Add KI feature identification endpoints and refactor task to use shared service (elastic#263528) [Scout] Migrate Data Views API tests from FTR - Part5 (elastic#264088) [Cases] Apply shared extended_fields path util server side (elastic#264706) [Lens as code] Fix metric trendline (elastic#264777) [api-docs] 2026-04-22 Daily api_docs build (elastic#264882) [Scout] Update test config manifests (elastic#264575) [workflows_management] Lazy-load Zod connector schemas to cut idle memory (elastic#264283) [ES|QL] Fix ES|QL columns reset race during active fetch (elastic#263947) [Content List] Column layout props, sticky actions, and title click handlers (elastic#264203) [Lens as code] Validate `id` in route for new vis types (elastic#264480) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes column sizing across all Content List table presets and adds click handling to
Column.Name.ColumnLayoutProps(width,minWidth,maxWidth,truncateText) shared by all column presets and the genericColumncomponent, replacing the per-presetwidth?: stringprop.scrollableInlineandresponsiveBreakpointas props onContentListTablewith opinionated defaults (trueandfalserespectively) to support sticky columns. Consumers can override if needed.onClickanduseHrefprops toColumn.Name, threaded throughNameCell→NameCellTitle. When bothhrefandonClickare present, modifier clicks follow the href while plain clicks callonClick.NameCellTitlerender branches from four to two.scrollableInlineandresponsiveBreakpointto the Core Features story.Changes
All changes are scoped to
@kbn/content-list-tableand@kbn/content-list-docs.layout.ts(new)ColumnLayoutPropstype andgetColumnLayoutPropshelper — standardizeswidth/minWidth/maxWidth/truncateTextacross columns.part.tsColumncomponent extendsColumnLayoutProps.NameColumnPropsextendsColumnLayoutProps, addsonClick/useHref.NameCellandNameCellTitlethread these through.NameCellTitlecollapsed from 4 render branches to 2.ColumnLayoutProps(or the relevant subset for non-text columns).scrollableInline(defaulttrue) andresponsiveBreakpoint(defaultfalse) props onContentListTable, passed through toEuiBasicTable. Defaults enable horizontal scrolling and disable mobile card layout, which is required for sticky columns and does not support Content List features like selection, tags, and stars.scrollableInlineandresponsiveBreakpointas Storybook controls.cell_title, anduse_columnstests updated.onClick/useHref.Test plan
@kbn/content-list-tableunit tests pass (155/155).Column.NameonClickfires on plain click, modifier clicks followhref.scrollableInlineoff in Storybook controls — table should no longer scroll horizontally.responsiveBreakpointon in Storybook controls — table should collapse to cards on narrow viewports.