Skip to content

[SLO] Fix APM embeddable ids #264750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlejandroFrndz merged 1 commit into from
Apr 22, 2026
Merged

[SLO] Fix APM embeddable ids #264750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...ns/slo/public/components/alert_details/components/custom_panels/apm/apm_alert_details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function APMLatencyAlertDetails({
<APMEmbeddableRoot
slo={slo}
dataTimeRange={dataTimeRange}
embeddableId={'APM_ALERTING_LATENCY_CHART_EMBEDDABLE'}
embeddableId={'apm_alerting_latency_chart'}
alert={alert}
rule={rule}
/>
Expand All @@ -37,7 +37,7 @@ export function APMLatencyAlertDetails({
<APMEmbeddableRoot
slo={slo}
dataTimeRange={dataTimeRange}
embeddableId={'APM_ALERTING_THROUGHPUT_CHART_EMBEDDABLE'}
embeddableId={'apm_alerting_throughput_chart'}
alert={alert}
rule={rule}
/>
Expand All @@ -46,7 +46,7 @@ export function APMLatencyAlertDetails({
<APMEmbeddableRoot
slo={slo}
dataTimeRange={dataTimeRange}
embeddableId={'APM_ALERTING_FAILED_TRANSACTIONS_CHART_EMBEDDABLE'}
embeddableId={'apm_alerting_failed_transactions_chart'}
alert={alert}
rule={rule}
/>
Expand All @@ -67,7 +67,7 @@ export function APMAvailabilityAlertDetails({
<APMEmbeddableRoot
slo={slo}
dataTimeRange={dataTimeRange}
embeddableId={'APM_ALERTING_FAILED_TRANSACTIONS_CHART_EMBEDDABLE'}
embeddableId={'apm_alerting_failed_transactions_chart'}
alert={alert}
rule={rule}
/>
Expand All @@ -76,7 +76,7 @@ export function APMAvailabilityAlertDetails({
<APMEmbeddableRoot
slo={slo}
dataTimeRange={dataTimeRange}
embeddableId={'APM_ALERTING_THROUGHPUT_CHART_EMBEDDABLE'}
embeddableId={'apm_alerting_throughput_chart'}
alert={alert}
rule={rule}
/>
Expand All @@ -85,7 +85,7 @@ export function APMAvailabilityAlertDetails({
<APMEmbeddableRoot
slo={slo}
dataTimeRange={dataTimeRange}
embeddableId={'APM_ALERTING_LATENCY_CHART_EMBEDDABLE'}
embeddableId={'apm_alerting_latency_chart'}
alert={alert}
rule={rule}
/>
Expand Down
8 changes: 3 additions & 5 deletions ...gins/slo/public/components/alert_details/components/custom_panels/apm/embeddable_root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,9 @@ import { apmTransactionDurationIndicatorSchema } from '@kbn/slo-schema';
import type { BurnRateAlert, BurnRateRule, TimeRange } from '../../../types';

type EmbeddableId =
| 'APM_THROUGHPUT_CHART_EMBEDDABLE'
| 'APM_LATENCY_CHART_EMBEDDABLE'
Comment on lines -21 to -22
Copy link
Copy Markdown
Contributor Author

@AlejandroFrndz AlejandroFrndz Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find an equivalent for these 2 ids so I'd say they don't exist anymore. And anyway, they weren't being used so I just removed them from the union type

| 'APM_ALERTING_FAILED_TRANSACTIONS_CHART_EMBEDDABLE'
| 'APM_ALERTING_LATENCY_CHART_EMBEDDABLE'
| 'APM_ALERTING_THROUGHPUT_CHART_EMBEDDABLE';
| 'apm_alerting_failed_transactions_chart'
| 'apm_alerting_latency_chart'
| 'apm_alerting_throughput_chart';

export type APMTransactionDurationSLOResponse = GetSLOResponse & {
indicator: APMTransactionDurationIndicator;
Expand Down
Loading