[9.4] [SLO] Fix APM embeddable ids (#264750)#264940
Merged
kibanamachine merged 1 commit intoelastic:9.4from Apr 22, 2026
Merged
[9.4] [SLO] Fix APM embeddable ids (#264750)#264940kibanamachine merged 1 commit intoelastic:9.4from
kibanamachine merged 1 commit intoelastic:9.4from
Conversation
## Summary Closes elastic#264008 As part of the dashboards as code effort, elastic#254079 introduced a change by which embeddable ids were changed. While most usages were properly updated, a couple of hardcoded string references in the SLO plugin were left unchanged. This is leading to issues where the APM embeddables in the alert details page are failing to be displayed because the code is unable to find the appropiate embeddable factory when searching by it's old id. In order to prevent issues like this in the future, I plan to do a follow up PR providing a proper fix to this issue in a way that allows the SLO plugin to consume the embeddable id constants defined in APM instead of having to relay on redefining the strings values in both plugins, which can lead to inconsistencies as this one. But, given the timing with the 9.4 BC I've decided to go first for this quick-and-easy approach of just changing the strings in the SLO plugin as well. While this is not ideal code-wise it will allow us to have a low-risk fix in time to be backported to 9.4 so we don't ship this view in a broken state. (cherry picked from commit 1463b9b)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:Questions ?
Please refer to the Backport tool documentation