Skip to content

[ES|QL] Show next actions after simple field assignment in RERANK ON Clause#246676

Merged
bartoval merged 1 commit intoelastic:mainfrom
bartoval:show_next_actions_field_after_assignment
Dec 17, 2025
Merged

[ES|QL] Show next actions after simple field assignment in RERANK ON Clause#246676
bartoval merged 1 commit intoelastic:mainfrom
bartoval:show_next_actions_field_after_assignment

Conversation

@bartoval
Copy link
Contributor

_## Summary

There is an incorrect interpretation of the RERANK grammar, namely rerankField qualifiedName (ASSIGN BooleanExpression). This does not mean it should return a Boolean, but simply the name describing the rule.

so even simple fields are valid

@bartoval bartoval self-assigned this Dec 17, 2025
@bartoval bartoval added the bug Fixes for quality problems that affect the customer experience label Dec 17, 2025
@bartoval bartoval requested a review from a team as a code owner December 17, 2025 08:21
@bartoval bartoval added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.3.0 labels Dec 17, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@bartoval bartoval force-pushed the show_next_actions_field_after_assignment branch from b810e60 to 6b3154e Compare December 17, 2025 08:36
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #8 / Endpoint Exceptions with feature flag enabled @ess @serverless @skipInServerlessMKI Endpoint artifacts (via lists plugin): Endpoint Exceptions "before all" hook in "@ess @serverless @skipInServerlessMKI Endpoint artifacts (via lists plugin): Endpoint Exceptions"
  • [job] [logs] Scout: [ platform / discover_enhanced ] plugin / serverless-es - Discover app - value suggestions: useTimeRange enabled - show up if in range
  • [job] [logs] Scout: [ platform / discover_enhanced ] plugin / show up if in range

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 4.3MB 4.3MB -32.0B

cc @bartoval

@bartoval bartoval merged commit e2f5aa0 into elastic:main Dec 17, 2025
13 checks passed
mbondyra added a commit to mbondyra/kibana that referenced this pull request Dec 17, 2025
…donly

* commit 'bb1f55fa520b30ceb923af069ef403b24dcb1606': (52 commits)
  [CPS][Maps] Support CPS Picker in Maps  (elastic#246382)
  [APM] Migrate the Transaction Overview tests to Scout/Playwright/Component/API tests (elastic#245972)
  [Cases] Change nested field search to be case insensitive (elastic#246643)
  [ES|QL] PromQL parser initial implementation (elastic#246552)
  [Agent Builder] Adds keyboard shortcut and toggle behavior to AI Agent button (elastic#246659)
  Retry on "all shards failed" from ES (elastic#246533)
  [Streams] Test enable wired streams flow (elastic#246113)
  [Agent Builder] Fast-follow bugfixes for MCP Tool type  (elastic#246665)
  [Entity Store][API] Fix snake case on CRUD API List response (elastic#246003)
  [ResponseOps][Slack] Simplify channel configuration  (elastic#245423)
  Add Canonical Name Badge to Documentation (elastic#246647)
  [Streams] Add simulation filtering by conditions (elastic#245400)
  [o11y AI] Add `get_hosts` tool (elastic#246541)
  [agent builder] create_visualization: support heatmap and regionmap (elastic#246671)
  [AI Infra] Chat experience: Selection modal title change (elastic#246683)
  [Background search] Change polling behavior (elastic#244760)
  [ES|QL  ]  Common Lookup Join Fields Are Not Listed First (elastic#246582)
  Add missing `dynamic: false` (elastic#246685)
  [Metrics in Discover] Unskip metrics api test (elastic#246593)
  [ES|QL] Show next actions after simple field assignment in RERANK ON Clause (elastic#246676)
  ...
KodeRad pushed a commit to KodeRad/kibana that referenced this pull request Dec 17, 2025
…Clause (elastic#246676)

_## Summary

There is an incorrect interpretation of the RERANK grammar, namely
`rerankField qualifiedName (ASSIGN BooleanExpression)`. This does not
mean it should return a Boolean, but simply the name describing the
rule.

so even simple fields are valid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants