Skip to content

[Agent Builder] Fast-follow bugfixes for MCP Tool type #246665

Merged
dennis-tismenko merged 5 commits intoelastic:mainfrom
dennis-tismenko:agent-builder/mcp-tool-type-bugfixes
Dec 17, 2025
Merged

[Agent Builder] Fast-follow bugfixes for MCP Tool type #246665
dennis-tismenko merged 5 commits intoelastic:mainfrom
dennis-tismenko:agent-builder/mcp-tool-type-bugfixes

Conversation

@dennis-tismenko
Copy link
Contributor

Summary

A couple of relatively small bugfixes for MCP tool type support in Agent Builder bundled together:

  • MCP tool search not working on the bulk import page: I forgot that if you have a custom change handler for search, you need to handle the filtering as well
  • Select all MCP tools: Would inadvertently get reset when clicking on the "x selected" button due to some reconciliation logic built into EuiInMemoryTable
  • Namespace validation: Focused on the complicated one first but forgot to add the simple ones — added similar validation rules to tool IDs
  • UX improvement: Automatically select newly created connector
  • Health status improvements: Disabled retries for health checks (faster feedback) and some minor refactor and improvements to how they're rendered

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@dennis-tismenko dennis-tismenko requested a review from a team as a code owner December 17, 2025 04:24
@dennis-tismenko dennis-tismenko added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.3.0 labels Dec 17, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
onechat 1388 1390 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
onechat 519.8KB 521.3KB +1.4KB

@dennis-tismenko dennis-tismenko enabled auto-merge (squash) December 17, 2025 13:49
@dennis-tismenko dennis-tismenko merged commit 4b68d02 into elastic:main Dec 17, 2025
24 checks passed
mbondyra added a commit to mbondyra/kibana that referenced this pull request Dec 17, 2025
…donly

* commit 'bb1f55fa520b30ceb923af069ef403b24dcb1606': (52 commits)
  [CPS][Maps] Support CPS Picker in Maps  (elastic#246382)
  [APM] Migrate the Transaction Overview tests to Scout/Playwright/Component/API tests (elastic#245972)
  [Cases] Change nested field search to be case insensitive (elastic#246643)
  [ES|QL] PromQL parser initial implementation (elastic#246552)
  [Agent Builder] Adds keyboard shortcut and toggle behavior to AI Agent button (elastic#246659)
  Retry on "all shards failed" from ES (elastic#246533)
  [Streams] Test enable wired streams flow (elastic#246113)
  [Agent Builder] Fast-follow bugfixes for MCP Tool type  (elastic#246665)
  [Entity Store][API] Fix snake case on CRUD API List response (elastic#246003)
  [ResponseOps][Slack] Simplify channel configuration  (elastic#245423)
  Add Canonical Name Badge to Documentation (elastic#246647)
  [Streams] Add simulation filtering by conditions (elastic#245400)
  [o11y AI] Add `get_hosts` tool (elastic#246541)
  [agent builder] create_visualization: support heatmap and regionmap (elastic#246671)
  [AI Infra] Chat experience: Selection modal title change (elastic#246683)
  [Background search] Change polling behavior (elastic#244760)
  [ES|QL  ]  Common Lookup Join Fields Are Not Listed First (elastic#246582)
  Add missing `dynamic: false` (elastic#246685)
  [Metrics in Discover] Unskip metrics api test (elastic#246593)
  [ES|QL] Show next actions after simple field assignment in RERANK ON Clause (elastic#246676)
  ...
KodeRad pushed a commit to KodeRad/kibana that referenced this pull request Dec 17, 2025
## Summary

A couple of relatively small bugfixes for MCP tool type support in Agent
Builder bundled together:
- __MCP tool search not working on the bulk import page__: I forgot that
if you have a custom change handler for `search`, you need to handle the
filtering as well
- __Select all MCP tools__: Would inadvertently get reset when clicking
on the "x selected" button due to some reconciliation logic built into
`EuiInMemoryTable`
- __Namespace validation__: Focused on the complicated one first but
forgot to add the simple ones — added similar validation rules to tool
IDs
- __UX improvement: Automatically select newly created connector__
- __Health status improvements__: Disabled retries for health checks
(faster feedback) and some minor refactor and improvements to how
they're rendered


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants