[ResponseOps][Slack] Simplify channel configuration by cnasikas · Pull Request #245423 · elastic/kibana

cnasikas · 2025-12-05T16:56:44Z

Summary

Fixes: #230979

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

Release notes

Slack connector can be configured to send messages to any channel using channel names.

…na into slack_ui_optional_channels

cnasikas · 2025-12-15T14:53:50Z

...atform/plugins/shared/stack_connectors/public/connector_types/slack_api/form_deserializer.ts

+import type { SlackApiConfig } from '@kbn/connector-schemas/slack_api';
+
+export const deserializer = (data: ConnectorFormSchema): InternalConnectorForm => {
+  const allowedChannels = (data.config?.allowedChannels as SlackApiConfig['allowedChannels']) ?? [];


The casting is needed because the TS types do not support templates, as they assume the data is the same for all connectors. I opened this issue: #246390.

cnasikas · 2025-12-15T14:59:47Z

...tform/plugins/shared/stack_connectors/public/connector_types/slack_api/slack_params.test.tsx

I wrote everything from scratch as a lot of the functionality was removed.

cnasikas · 2025-12-15T15:01:26Z

...k/platform/plugins/shared/stack_connectors/public/connector_types/slack_api/slack_params.tsx

+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [defaultMessage, useDefaultMessage]);
+
+  return <SlackParamsFieldsComponent {...props} key={key} />;


The key will reset the state (useState) of the component if it changes. This helps to reset the fields when the connector changes.

cnasikas · 2025-12-15T15:08:17Z

...m/plugins/shared/triggers_actions_ui/public/application/components/simple_connector_form.tsx

  readOnly,
  configFormSchema,
  secretsFormSchema,
-  configFormSchemaAfterSecrets = [],


Not used by any connector type.

elasticmachine · 2025-12-16T13:50:34Z

Pinging @elastic/response-ops (Team:ResponseOps)

js-jankisalvi

Verified changes locally, working as expected with new and existing connectors and rules using those connectors

Few minor things (no blocker)

Channels dropdown is different for Old connector (from main) test tab view than in rules action form

Old rule with old connector (from main)

As discussed offline, Help text with example for allowedChannels field could be helpful.
Also known bug - security solution rule form doesn't show channel on selecting/changing the connector

umbopepato

LGTM!

nit: not related to this changes, but like in the Scheduled Reports form and other hook lib forms, the errors accumulate on every validation instead of replacing the old one. If we didn't already, we could inform the relevant team (Core?) to improve this

jcger · 2025-12-16T15:17:17Z

...atform/plugins/shared/stack_connectors/public/connector_types/slack_api/form_deserializer.ts

+        return channel.name;
+      }
+
+      return `#${channel.name}`;


how can this happen? Did we miss a schema validation to check that channel.name starts with # ?

The old code always put names without #. We can do the same but I thought users are more used to the # on front of channels and it will make it easier to distinguish channel names for channel IDs.

jcger · 2025-12-16T15:19:06Z

x-pack/platform/plugins/shared/stack_connectors/public/connector_types/slack_api/slack_api.tsx

+const DEFAULT_PARAMS = { subAction: 'postMessage' as const, subActionParams: { text: undefined } };
+
+const getChannelErrors = (channels?: string[], channelIds?: string[], channelNames?: string[]) => {
+  const isUndefinedOrEmptyArray = (arr?: string[]) => {


nit: could be moved outside this function to avoid creating it each time

jcger · 2025-12-16T15:20:31Z

...m/plugins/shared/stack_connectors/public/connector_types/slack_api/slack_connectors.test.tsx

+      await userEvent.paste('some token');
+
+      await userEvent.click(screen.getByTestId('comboBoxSearchInput'));
+      await userEvent.type(screen.getByTestId('comboBoxSearchInput'), '#general{enter}');


why not paste like the token? (just curious)

Paste does not work with the combobox or at least I cannot make it work 🙂

jcger · 2025-12-16T15:29:38Z

...atform/plugins/shared/stack_connectors/public/connector_types/slack_api/slack_connectors.tsx

+            return;
+          }
+
+          const areAllValid = valueAsArray.every((value) => value.startsWith('#'));


does this not accept channel ids anymore? What's the point in forcing # as prefix in the UI then?

No, not any more. For new usage, we will go with channel names, and the backend will throw an error if the # is not prefixed on the channel name.

It's no breaking change because it will still be working, it's just that the UI on edit connector will show something broken or nothing in the "Allowed channels" list?

Isn't it weird that a user can set allowed channel ids via API but then the UI will be broken/users can't update via UI this list using the same id they use via API? I would think we keep feature parity between API and UI (meaning both work)

elasticmachine · 2025-12-17T12:47:26Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 233d53e

Failed CI Steps

FTR Configs #113

Test Failures

[job] [logs] FTR Configs #113 / Endpoint Policy @ess @serverless Creation of DOT indices for elastic defend policies "before each" hook for "should create indices when endpoint integration policy is created"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`stackConnectors`	633	634	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`stackConnectors`	1.1MB	1.1MB	-3.2KB
`triggersActionsUi`	1.5MB	1.5MB	+33.0B
total			-3.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`stackConnectors`	76.2KB	76.6KB	+391.0B
`triggersActionsUi`	107.2KB	107.1KB	-151.0B
total			+240.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`stackConnectors`	155	151	-4

References to deprecated APIs

id	before	after	diff
`stackConnectors`	2	1	-1

Total ESLint disabled count

id	before	after	diff
`stackConnectors`	160	156	-4

History

cc @cnasikas

…donly * commit 'bb1f55fa520b30ceb923af069ef403b24dcb1606': (52 commits) [CPS][Maps] Support CPS Picker in Maps (elastic#246382) [APM] Migrate the Transaction Overview tests to Scout/Playwright/Component/API tests (elastic#245972) [Cases] Change nested field search to be case insensitive (elastic#246643) [ES|QL] PromQL parser initial implementation (elastic#246552) [Agent Builder] Adds keyboard shortcut and toggle behavior to AI Agent button (elastic#246659) Retry on "all shards failed" from ES (elastic#246533) [Streams] Test enable wired streams flow (elastic#246113) [Agent Builder] Fast-follow bugfixes for MCP Tool type (elastic#246665) [Entity Store][API] Fix snake case on CRUD API List response (elastic#246003) [ResponseOps][Slack] Simplify channel configuration (elastic#245423) Add Canonical Name Badge to Documentation (elastic#246647) [Streams] Add simulation filtering by conditions (elastic#245400) [o11y AI] Add `get_hosts` tool (elastic#246541) [agent builder] create_visualization: support heatmap and regionmap (elastic#246671) [AI Infra] Chat experience: Selection modal title change (elastic#246683) [Background search] Change polling behavior (elastic#244760) [ES|QL ] Common Lookup Join Fields Are Not Listed First (elastic#246582) Add missing `dynamic: false` (elastic#246685) [Metrics in Discover] Unskip metrics api test (elastic#246593) [ES|QL] Show next actions after simple field assignment in RERANK ON Clause (elastic#246676) ...

## Summary Fixes: elastic#230979 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

…g Slack connector (#247098) ## Summary PR #245423 simplified a lot the logic of the Slack connector regarding channels. This PR fixes a small bug introduced in the PR where it would remove the ID of the channel from the payload for existing connector. ### Testing 1. Create a connector using the following payload: ``` { "name": "Slack - test allowedChannels", "config": { "allowedChannels": [ { "id": "C096LSBJZBQ", // should have an ID "name": "test" } ] }, "secrets": { "token": "foo" }, "connector_type_id": ".slack_api" } ``` 2. Edit the connector by adding an extra channel 3. Verify that the payload sent to the API preserves the channel ID. The new channel should only have a name. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

…g Slack connector (elastic#247098) ## Summary PR elastic#245423 simplified a lot the logic of the Slack connector regarding channels. This PR fixes a small bug introduced in the PR where it would remove the ID of the channel from the payload for existing connector. ### Testing 1. Create a connector using the following payload: ``` { "name": "Slack - test allowedChannels", "config": { "allowedChannels": [ { "id": "C096LSBJZBQ", // should have an ID "name": "test" } ] }, "secrets": { "token": "foo" }, "connector_type_id": ".slack_api" } ``` 2. Edit the connector by adding an extra channel 3. Verify that the payload sent to the API preserves the channel ID. The new channel should only have a name. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 2dce199)

…g Slack connector (elastic#247098) ## Summary PR elastic#245423 simplified a lot the logic of the Slack connector regarding channels. This PR fixes a small bug introduced in the PR where it would remove the ID of the channel from the payload for existing connector. ### Testing 1. Create a connector using the following payload: ``` { "name": "Slack - test allowedChannels", "config": { "allowedChannels": [ { "id": "C096LSBJZBQ", // should have an ID "name": "test" } ] }, "secrets": { "token": "foo" }, "connector_type_id": ".slack_api" } ``` 2. Edit the connector by adding an extra channel 3. Verify that the payload sent to the API preserves the channel ID. The new channel should only have a name. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

…xisting Slack connector (#247098) (#247159) # Backport This will backport the following commits from `main` to `9.3`: - [[ResponseOps][Connectors] Keep the channel ID when editing an existing Slack connector (#247098)](#247098)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…g Slack connector (elastic#247098) ## Summary PR elastic#245423 simplified a lot the logic of the Slack connector regarding channels. This PR fixes a small bug introduced in the PR where it would remove the ID of the channel from the payload for existing connector. ### Testing 1. Create a connector using the following payload: ``` { "name": "Slack - test allowedChannels", "config": { "allowedChannels": [ { "id": "C096LSBJZBQ", // should have an ID "name": "test" } ] }, "secrets": { "token": "foo" }, "connector_type_id": ".slack_api" } ``` 2. Edit the connector by adding an extra channel 3. Verify that the payload sent to the API preserves the channel ID. The new channel should only have a name. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Remove validation of channels

de5cfc5

cnasikas self-assigned this Dec 5, 2025

cnasikas added release_note:enhancement Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// backport:version Backport to applied version labels v9.3.0 labels Dec 5, 2025

cnasikas added 9 commits December 8, 2025 17:54

Remove validation of channels

663a4db

Merge branch 'main' into slack_ui_optional_channels

26bde28

Small fixes

dfac6b9

Merge branch 'main' into slack_ui_optional_channels

105ea12

Merge branch 'slack_ui_optional_channels' of github.com:cnasikas/kiba…

e563094

…na into slack_ui_optional_channels

Add tests for creating/editing connector

2248a90

Merge branch 'main' into slack_ui_optional_channels

a5d6501

Fix bugs and add tests

28901a0

Merge branch 'main' into slack_ui_optional_channels

5b3b943

cnasikas mentioned this pull request Dec 15, 2025

[ResponseOps][Connectors] Type the connector serializer/deserializer correctly #246390

Open

cnasikas commented Dec 15, 2025

View reviewed changes

cnasikas added 4 commits December 15, 2025 17:22

Fix tests

86157d1

Fix i18n

8af968e

Merge branch 'main' into slack_ui_optional_channels

6492d51

Fix bug with validation

a2f937c

cnasikas marked this pull request as ready for review December 16, 2025 13:50

cnasikas requested a review from a team as a code owner December 16, 2025 13:50

Add helptext

a198fe3

js-jankisalvi approved these changes Dec 16, 2025

View reviewed changes

Fix integration test

ee6838e

umbopepato approved these changes Dec 17, 2025

View reviewed changes

jcger reviewed Dec 17, 2025

View reviewed changes

cnasikas added 3 commits December 17, 2025 11:57

Fix issues with the test form

1709280

Fix types

c21642e

Merge branch 'main' into slack_ui_optional_channels

233d53e

cnasikas merged commit 0bf64ab into elastic:main Dec 17, 2025
14 checks passed

cnasikas deleted the slack_ui_optional_channels branch December 17, 2025 13:14

kibanamachine added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Dec 17, 2025

cnasikas mentioned this pull request Dec 19, 2025

[ResponseOps][Connectors] Keep the channel ID when editing an existing Slack connector #247098

Merged

1 task

cnasikas mentioned this pull request Dec 31, 2025

[ResponesOps][Connectors] Make the channel IDs optional when configuring the Slack connector #206716

Closed

cnasikas mentioned this pull request Feb 10, 2026

[ResponseOps][Connectors] Channel id not selected automatically for slack connector #234731

Closed

Conversation

cnasikas commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Release notes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 16, 2025

Uh oh!

js-jankisalvi left a comment

Choose a reason for hiding this comment

Uh oh!

umbopepato left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcger Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 17, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cnasikas commented Dec 5, 2025 •

edited

Loading

jcger Dec 17, 2025 •

edited

Loading