Skip to content

[ES|QL] Show next actions after simple field assignment in RERANK ON Clause #246676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartoval merged 1 commit into from
Dec 17, 2025
Merged

[ES|QL] Show next actions after simple field assignment in RERANK ON Clause #246676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/platform/packages/shared/kbn-esql-ast/src/commands/registry/rerank/autocomplete.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,18 @@ describe('RERANK Autocomplete', () => {

await expectRerankSuggestions(query, NEXT_ACTIONS_EXPRESSIONS);
});

test('suggests next actions after simple field assignment', async () => {
const query =
buildRerankQuery({
query: '"search query"',
onClause: 'col0 = keywordField',
}) + ' ';

await expectRerankSuggestions(query, {
contains: NEXT_ACTIONS,
});
});
});

describe('Terminal operators', () => {
Expand Down
4 changes: 2 additions & 2 deletions src/platform/packages/shared/kbn-esql-ast/src/commands/registry/rerank/autocomplete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,9 @@ async function handleOnExpression({
},
});

const { expressionType, isComplete, insideFunction } = computed;
const { isComplete, insideFunction } = computed;

if (expressionRoot && expressionType === 'boolean' && isComplete && !insideFunction) {
if (expressionRoot && isComplete && !insideFunction) {
suggestions.push(...buildNextActions());
}

Expand Down