[ES|QL ] Common Lookup Join Fields Are Not Listed First#246582
Merged
stratoula merged 3 commits intoelastic:mainfrom Dec 17, 2025
Merged
[ES|QL ] Common Lookup Join Fields Are Not Listed First#246582stratoula merged 3 commits intoelastic:mainfrom
stratoula merged 3 commits intoelastic:mainfrom
Conversation
bartoval
added
bug
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
bartoval
changed the title
Contributor
Author
bartoval
force-pushed
the
lookup_columns_wrong_order
branch
from
628c84e to
45c58a0
Compare
stratoula
approved these changes
Dec 17, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Looks great, just one question for the extra category, do we really need this?
| return [...markedSourceSuggestions, ...uniqueLookupSuggestions]; | ||
| const categorizedLookupSuggestions = uniqueLookupSuggestions.map((suggestion) => ({ | ||
| ...suggestion, | ||
| category: SuggestionCategory.LOOKUP_INDEX_FIELD, |
Contributor
There was a problem hiding this comment.
@bartoval remind me why we have to give a different category for this? Why is not falling on the typical field category? I would expect to only have a new category for the common ones and the rest to be SuggestionCategory.FIELD
Contributor
Author
There was a problem hiding this comment.
I added it only for clarity and to distinguish it, in case we want to change the rules in the future. The priority is the same as the FIELDs. I can remove it anyway.
Contributor
There was a problem hiding this comment.
Yeah let's remove it for now and if there is a need let's add it then!
bartoval
force-pushed
the
lookup_columns_wrong_order
branch
from
63e51ce to
bc3d86e
Compare
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @bartoval |
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Dec 17, 2025
…donly * commit 'bb1f55fa520b30ceb923af069ef403b24dcb1606': (52 commits) [CPS][Maps] Support CPS Picker in Maps (elastic#246382) [APM] Migrate the Transaction Overview tests to Scout/Playwright/Component/API tests (elastic#245972) [Cases] Change nested field search to be case insensitive (elastic#246643) [ES|QL] PromQL parser initial implementation (elastic#246552) [Agent Builder] Adds keyboard shortcut and toggle behavior to AI Agent button (elastic#246659) Retry on "all shards failed" from ES (elastic#246533) [Streams] Test enable wired streams flow (elastic#246113) [Agent Builder] Fast-follow bugfixes for MCP Tool type (elastic#246665) [Entity Store][API] Fix snake case on CRUD API List response (elastic#246003) [ResponseOps][Slack] Simplify channel configuration (elastic#245423) Add Canonical Name Badge to Documentation (elastic#246647) [Streams] Add simulation filtering by conditions (elastic#245400) [o11y AI] Add `get_hosts` tool (elastic#246541) [agent builder] create_visualization: support heatmap and regionmap (elastic#246671) [AI Infra] Chat experience: Selection modal title change (elastic#246683) [Background search] Change polling behavior (elastic#244760) [ES|QL ] Common Lookup Join Fields Are Not Listed First (elastic#246582) Add missing `dynamic: false` (elastic#246685) [Metrics in Discover] Unskip metrics api test (elastic#246593) [ES|QL] Show next actions after simple field assignment in RERANK ON Clause (elastic#246676) ...
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Dec 17, 2025
## Summary Added two new sorting categories for common and unique lookup fields. Common has higher priority than fields and unique lookup fields (same priority).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added two new sorting categories for common and unique lookup fields.
Common has higher priority than fields and unique lookup fields (same priority).