[9.3] [ResponseOps][Connectors] Keep the channel ID when editing an existing Slack connector (#247098)#247159
Merged
kibanamachine merged 3 commits intoelastic:9.3from Dec 23, 2025
Conversation
…g Slack connector (elastic#247098) ## Summary PR elastic#245423 simplified a lot the logic of the Slack connector regarding channels. This PR fixes a small bug introduced in the PR where it would remove the ID of the channel from the payload for existing connector. ### Testing 1. Create a connector using the following payload: ``` { "name": "Slack - test allowedChannels", "config": { "allowedChannels": [ { "id": "C096LSBJZBQ", // should have an ID "name": "test" } ] }, "secrets": { "token": "foo" }, "connector_type_id": ".slack_api" } ``` 2. Edit the connector by adding an extra channel 3. Verify that the payload sent to the API preserves the channel ID. The new channel should only have a name. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 2dce199)
Merged
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
|
@elasticmachine merge upstream |
Contributor
|
There are no new commits on the base branch. |
Member
|
@elasticmachine merge upstream |
Contributor
|
There are no new commits on the base branch. |
Member
|
/ci |
Member
|
@elasticmachine merge upstream |
Contributor
|
There are no new commits on the base branch. |
Member
|
@elasticmachine merge upstream |
Contributor
|
There are no new commits on the base branch. |
Member
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @cnasikas |
Member
|
@elasticmachine merge upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:Questions ?
Please refer to the Backport tool documentation