[ES|QL] Fixes wrong validation on expressions between aggregations#227989
Merged
stratoula merged 1 commit intoelastic:mainfrom Jul 16, 2025
Merged
Conversation
13 tasks
stratoula
added
v9.1.0
v8.19.0
Feature:ES|QL
stratoula
changed the title
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
drewdaemon
approved these changes
Jul 15, 2025
Contributor
drewdaemon
left a comment
drewdaemon
left a comment
There was a problem hiding this comment.
Code change looks good
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16310694539 |
Contributor
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jul 16, 2025
…lastic#227989) ## Summary Fixes wrong client side validation error in expressions between aggregations Before <img width="3196" height="542" alt="image" src="https://github.com/user-attachments/assets/512f0b2c-b64f-40c9-aa08-645f3f312bc6" /> After <img width="1598" height="186" alt="image" src="https://github.com/user-attachments/assets/d47b1888-4ae9-4f9c-b474-383dede4b3d0" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 3c027eb) # Conflicts: # src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/stats/utils.ts # src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/stats/validate.test.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jul 16, 2025
…lastic#227989) ## Summary Fixes wrong client side validation error in expressions between aggregations Before <img width="3196" height="542" alt="image" src="https://github.com/user-attachments/assets/512f0b2c-b64f-40c9-aa08-645f3f312bc6" /> After <img width="1598" height="186" alt="image" src="https://github.com/user-attachments/assets/d47b1888-4ae9-4f9c-b474-383dede4b3d0" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 3c027eb) # Conflicts: # src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/stats/utils.ts # src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/stats/validate.test.ts
stratoula
added a commit
that referenced
this pull request
Jul 16, 2025
…ions (#227989) (#228129) # Backport This will backport the following commits from `main` to `8.19`: - [[ES|QL] Fixes wrong validation on expressions between aggregations (#227989)](#227989) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-07-16T04:50:55Z","message":"[ES|QL] Fixes wrong validation on expressions between aggregations (#227989)\n\n## Summary\n\nFixes wrong client side validation error in expressions between\naggregations\n\nBefore\n<img width=\"3196\" height=\"542\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/512f0b2c-b64f-40c9-aa08-645f3f312bc6\"\n/>\n\n\nAfter\n<img width=\"1598\" height=\"186\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d47b1888-4ae9-4f9c-b474-383dede4b3d0\"\n/>\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"3c027ebd64fb5819c224d6735e8edc11783211a1","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ES|QL] Fixes wrong validation on expressions between aggregations","number":227989,"url":"https://github.com/elastic/kibana/pull/227989","mergeCommit":{"message":"[ES|QL] Fixes wrong validation on expressions between aggregations (#227989)\n\n## Summary\n\nFixes wrong client side validation error in expressions between\naggregations\n\nBefore\n<img width=\"3196\" height=\"542\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/512f0b2c-b64f-40c9-aa08-645f3f312bc6\"\n/>\n\n\nAfter\n<img width=\"1598\" height=\"186\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d47b1888-4ae9-4f9c-b474-383dede4b3d0\"\n/>\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"3c027ebd64fb5819c224d6735e8edc11783211a1"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227989","number":227989,"mergeCommit":{"message":"[ES|QL] Fixes wrong validation on expressions between aggregations (#227989)\n\n## Summary\n\nFixes wrong client side validation error in expressions between\naggregations\n\nBefore\n<img width=\"3196\" height=\"542\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/512f0b2c-b64f-40c9-aa08-645f3f312bc6\"\n/>\n\n\nAfter\n<img width=\"1598\" height=\"186\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d47b1888-4ae9-4f9c-b474-383dede4b3d0\"\n/>\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"3c027ebd64fb5819c224d6735e8edc11783211a1"}}]}] BACKPORT-->
stratoula
added a commit
that referenced
this pull request
Jul 16, 2025
…ons (#227989) (#228128) # Backport This will backport the following commits from `main` to `9.1`: - [[ES|QL] Fixes wrong validation on expressions between aggregations (#227989)](#227989) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-07-16T04:50:55Z","message":"[ES|QL] Fixes wrong validation on expressions between aggregations (#227989)\n\n## Summary\n\nFixes wrong client side validation error in expressions between\naggregations\n\nBefore\n<img width=\"3196\" height=\"542\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/512f0b2c-b64f-40c9-aa08-645f3f312bc6\"\n/>\n\n\nAfter\n<img width=\"1598\" height=\"186\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d47b1888-4ae9-4f9c-b474-383dede4b3d0\"\n/>\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"3c027ebd64fb5819c224d6735e8edc11783211a1","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ES|QL] Fixes wrong validation on expressions between aggregations","number":227989,"url":"https://github.com/elastic/kibana/pull/227989","mergeCommit":{"message":"[ES|QL] Fixes wrong validation on expressions between aggregations (#227989)\n\n## Summary\n\nFixes wrong client side validation error in expressions between\naggregations\n\nBefore\n<img width=\"3196\" height=\"542\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/512f0b2c-b64f-40c9-aa08-645f3f312bc6\"\n/>\n\n\nAfter\n<img width=\"1598\" height=\"186\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d47b1888-4ae9-4f9c-b474-383dede4b3d0\"\n/>\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"3c027ebd64fb5819c224d6735e8edc11783211a1"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227989","number":227989,"mergeCommit":{"message":"[ES|QL] Fixes wrong validation on expressions between aggregations (#227989)\n\n## Summary\n\nFixes wrong client side validation error in expressions between\naggregations\n\nBefore\n<img width=\"3196\" height=\"542\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/512f0b2c-b64f-40c9-aa08-645f3f312bc6\"\n/>\n\n\nAfter\n<img width=\"1598\" height=\"186\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d47b1888-4ae9-4f9c-b474-383dede4b3d0\"\n/>\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"3c027ebd64fb5819c224d6735e8edc11783211a1"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
…lastic#227989) ## Summary Fixes wrong client side validation error in expressions between aggregations Before <img width="3196" height="542" alt="image" src="https://github.com/user-attachments/assets/512f0b2c-b64f-40c9-aa08-645f3f312bc6" /> After <img width="1598" height="186" alt="image" src="https://github.com/user-attachments/assets/d47b1888-4ae9-4f9c-b474-383dede4b3d0" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…lastic#227989) ## Summary Fixes wrong client side validation error in expressions between aggregations Before <img width="3196" height="542" alt="image" src="https://github.com/user-attachments/assets/512f0b2c-b64f-40c9-aa08-645f3f312bc6" /> After <img width="1598" height="186" alt="image" src="https://github.com/user-attachments/assets/d47b1888-4ae9-4f9c-b474-383dede4b3d0" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes wrong client side validation error in expressions between aggregations
Before
After
Checklist