Skip to content

Comments

[ska] add .gitignore in test dirs#227013

Merged
dmlemeshko merged 5 commits intoelastic:mainfrom
dmlemeshko:ska/add-gitignore-in-test-dir
Jul 15, 2025
Merged

[ska] add .gitignore in test dirs#227013
dmlemeshko merged 5 commits intoelastic:mainfrom
dmlemeshko:ska/add-gitignore-in-test-dir

Conversation

@dmlemeshko
Copy link
Contributor

@dmlemeshko dmlemeshko commented Jul 8, 2025

Summary

With test relocation FTR will create test artefact directories in x-pack/platform/test and x-pack/solutions/<solution>/test directories. This PR adds .gitignore similar to the existing one in x-pack/test to avoid accidental addition to PR.

@dmlemeshko dmlemeshko self-assigned this Jul 8, 2025
@dmlemeshko dmlemeshko requested a review from a team July 8, 2025 12:36
@csr
Copy link
Contributor

csr commented Jul 8, 2025

This reminds me we'll eventually need to post command to upload the artifacts from the new folders.

LGTM, but I'll try it out locally soon. It looks like the CI is failing because we're missing an owner for these new files.

@dmlemeshko dmlemeshko marked this pull request as ready for review July 14, 2025 08:10
@dmlemeshko dmlemeshko requested a review from a team as a code owner July 14, 2025 08:10
@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 v9.2.0 labels Jul 14, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @dmlemeshko

@dmlemeshko dmlemeshko merged commit a0ab728 into elastic:main Jul 15, 2025
12 of 13 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16294490674

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts
9.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 227013

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 15, 2025
## Summary

With test relocation FTR will create test artefact directories in
`x-pack/platform/test` and `x-pack/solutions/<solution>/test`
directories. This PR adds `.gitignore` similar to the existing one in
`x-pack/test` to avoid accidental addition to PR.

(cherry picked from commit a0ab728)

# Conflicts:
#	.github/CODEOWNERS
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 15, 2025
## Summary

With test relocation FTR will create test artefact directories in
`x-pack/platform/test` and `x-pack/solutions/<solution>/test`
directories. This PR adds `.gitignore` similar to the existing one in
`x-pack/test` to avoid accidental addition to PR.

(cherry picked from commit a0ab728)

# Conflicts:
#	.github/CODEOWNERS
@dmlemeshko
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.1
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit that referenced this pull request Jul 16, 2025
# Backport

This will backport the following commits from `main` to `9.1`:
- [[ska] add .gitignore in test dirs
(#227013)](#227013)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-15T13:22:52Z","message":"[ska]
add .gitignore in test dirs (#227013)\n\n## Summary\n\nWith test
relocation FTR will create test artefact directories
in\n`x-pack/platform/test` and
`x-pack/solutions/<solution>/test`\ndirectories. This PR adds
`.gitignore` similar to the existing one in\n`x-pack/test` to avoid
accidental addition to
PR.","sha":"a0ab72819dbcfa5de68f0c48ca439d9b36cb654b","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ska]
add .gitignore in test
dirs","number":227013,"url":"https://github.com/elastic/kibana/pull/227013","mergeCommit":{"message":"[ska]
add .gitignore in test dirs (#227013)\n\n## Summary\n\nWith test
relocation FTR will create test artefact directories
in\n`x-pack/platform/test` and
`x-pack/solutions/<solution>/test`\ndirectories. This PR adds
`.gitignore` similar to the existing one in\n`x-pack/test` to avoid
accidental addition to
PR.","sha":"a0ab72819dbcfa5de68f0c48ca439d9b36cb654b"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227013","number":227013,"mergeCommit":{"message":"[ska]
add .gitignore in test dirs (#227013)\n\n## Summary\n\nWith test
relocation FTR will create test artefact directories
in\n`x-pack/platform/test` and
`x-pack/solutions/<solution>/test`\ndirectories. This PR adds
`.gitignore` similar to the existing one in\n`x-pack/test` to avoid
accidental addition to
PR.","sha":"a0ab72819dbcfa5de68f0c48ca439d9b36cb654b"}}]}] BACKPORT-->
dmlemeshko added a commit that referenced this pull request Jul 16, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[ska] add .gitignore in test dirs
(#227013)](#227013)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-15T13:22:52Z","message":"[ska]
add .gitignore in test dirs (#227013)\n\n## Summary\n\nWith test
relocation FTR will create test artefact directories
in\n`x-pack/platform/test` and
`x-pack/solutions/<solution>/test`\ndirectories. This PR adds
`.gitignore` similar to the existing one in\n`x-pack/test` to avoid
accidental addition to
PR.","sha":"a0ab72819dbcfa5de68f0c48ca439d9b36cb654b","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ska]
add .gitignore in test
dirs","number":227013,"url":"https://github.com/elastic/kibana/pull/227013","mergeCommit":{"message":"[ska]
add .gitignore in test dirs (#227013)\n\n## Summary\n\nWith test
relocation FTR will create test artefact directories
in\n`x-pack/platform/test` and
`x-pack/solutions/<solution>/test`\ndirectories. This PR adds
`.gitignore` similar to the existing one in\n`x-pack/test` to avoid
accidental addition to
PR.","sha":"a0ab72819dbcfa5de68f0c48ca439d9b36cb654b"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227013","number":227013,"mergeCommit":{"message":"[ska]
add .gitignore in test dirs (#227013)\n\n## Summary\n\nWith test
relocation FTR will create test artefact directories
in\n`x-pack/platform/test` and
`x-pack/solutions/<solution>/test`\ndirectories. This PR adds
`.gitignore` similar to the existing one in\n`x-pack/test` to avoid
accidental addition to
PR.","sha":"a0ab72819dbcfa5de68f0c48ca439d9b36cb654b"}}]}] BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Bluefinger pushed a commit to Bluefinger/kibana that referenced this pull request Jul 22, 2025
## Summary

With test relocation FTR will create test artefact directories in
`x-pack/platform/test` and `x-pack/solutions/<solution>/test`
directories. This PR adds `.gitignore` similar to the existing one in
`x-pack/test` to avoid accidental addition to PR.
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
## Summary

With test relocation FTR will create test artefact directories in
`x-pack/platform/test` and `x-pack/solutions/<solution>/test`
directories. This PR adds `.gitignore` similar to the existing one in
`x-pack/test` to avoid accidental addition to PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.19.0 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants