[SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed#227705
Merged
tsullivan merged 9 commits intoelastic:mainfrom Jul 15, 2025
Merged
[SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed#227705tsullivan merged 9 commits intoelastic:mainfrom
tsullivan merged 9 commits intoelastic:mainfrom
Conversation
tsullivan
commented
Jul 11, 2025
| ): RenderAs => { | ||
| if (isSideNavCollapsed && navNode.renderAs === 'panelOpener' && !nodeHasLink(navNode)) | ||
| return 'accordion'; // When the side nav is collapsed, we render panel openers as accordions if they don't have a landing page | ||
| if (isSideNavCollapsed && navNode.renderAs === 'panelOpener') return 'accordion'; // When the side nav is collapsed, we render panel openers as accordions |
Member
Author
There was a problem hiding this comment.
This is the actual fix
| import type { PanelSelectedNode } from '@kbn/core-chrome-browser'; | ||
| import { usePanel } from './context'; | ||
| import { getNavPanelStyles, getPanelWrapperStyles } from './styles'; | ||
| import { navPanelStyles, panelWrapperStyles } from './styles'; |
Member
Author
There was a problem hiding this comment.
Initially, I thought the bug was caused by styling, so I cleaned up styles in this component to use @emotion/react instead of @emotion/css.
tsullivan
added
release_note:fix
backport:version
Contributor
|
Tested on cloud deployment. Works fine! small_Works_fine.mp4 |
bhavyarm
approved these changes
Jul 11, 2025
Contributor
bhavyarm
left a comment
bhavyarm
left a comment
There was a problem hiding this comment.
LGTM. Tested on cloud deployment. Works fine!
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16299162744 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 15, 2025
…hen side nav is collapsed (elastic#227705) Closes elastic#227616 The bug was caused some time around elastic#210893 where support for the landing pages of panel opener nav items ("four squares" design) was removed. During that removal, the behavior changed when the side nav is collapsed: panel opener items need to open as an accordion in that scenario. ### Other changes - Initially, I thought the root cause was due to styling, so I cleaned up styles in `navigation_panel.tsx` and refactored them to use `@emotion/react`. ### Release Note Fixed a bug with the solution nav submenu items when the nav is collapsed. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit d85f216)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jul 15, 2025
…hen side nav is collapsed (elastic#227705) Closes elastic#227616 The bug was caused some time around elastic#210893 where support for the landing pages of panel opener nav items ("four squares" design) was removed. During that removal, the behavior changed when the side nav is collapsed: panel opener items need to open as an accordion in that scenario. ### Other changes - Initially, I thought the root cause was due to styling, so I cleaned up styles in `navigation_panel.tsx` and refactored them to use `@emotion/react`. ### Release Note Fixed a bug with the solution nav submenu items when the nav is collapsed. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit d85f216) # Conflicts: # src/platform/packages/shared/shared-ux/chrome/navigation/src/ui/components/panel/styles.ts
tsullivan
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 15, 2025
…hen side nav is collapsed (elastic#227705) Closes elastic#227616 The bug was caused some time around elastic#210893 where support for the landing pages of panel opener nav items ("four squares" design) was removed. During that removal, the behavior changed when the side nav is collapsed: panel opener items need to open as an accordion in that scenario. ### Other changes - Initially, I thought the root cause was due to styling, so I cleaned up styles in `navigation_panel.tsx` and refactored them to use `@emotion/react`. ### Release Note Fixed a bug with the solution nav submenu items when the nav is collapsed. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit d85f216)
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jul 15, 2025
…hen side nav is collapsed (elastic#227705) Closes elastic#227616 The bug was caused some time around elastic#210893 where support for the landing pages of panel opener nav items ("four squares" design) was removed. During that removal, the behavior changed when the side nav is collapsed: panel opener items need to open as an accordion in that scenario. ### Other changes - Initially, I thought the root cause was due to styling, so I cleaned up styles in `navigation_panel.tsx` and refactored them to use `@emotion/react`. ### Release Note Fixed a bug with the solution nav submenu items when the nav is collapsed. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit d85f216) # Conflicts: # src/platform/packages/shared/shared-ux/chrome/navigation/src/ui/components/panel/styles.ts
1 task
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
tsullivan
added a commit
that referenced
this pull request
Jul 16, 2025
…eners when side nav is collapsed (#227705) (#228083) # Backport This will backport the following commits from `main` to `8.19`: - [[SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed (#227705)](#227705) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-15T16:42:08Z","message":"[SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed (#227705)\n\nCloses https://github.com/elastic/kibana/issues/227616\n\nThe bug was caused some time around\nhttps://github.com//pull/210893 where support for the\nlanding pages of panel opener nav items (\"four squares\" design) was\nremoved. During that removal, the behavior changed when the side nav is\ncollapsed: panel opener items need to open as an accordion in that\nscenario.\n\n### Other changes\n- Initially, I thought the root cause was due to styling, so I cleaned\nup styles in `navigation_panel.tsx` and refactored them to use\n`@emotion/react`.\n\n### Release Note\n\nFixed a bug with the solution nav submenu items when the nav is\ncollapsed.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- ~~[ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~\n- ~~[ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~~\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- ~~[ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~\n- ~~[ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~~\n- ~~[ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"d85f216c8749525cb360649a641754f343800f69","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","ci:cloud-deploy","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed","number":227705,"url":"https://github.com/elastic/kibana/pull/227705","mergeCommit":{"message":"[SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed (#227705)\n\nCloses https://github.com/elastic/kibana/issues/227616\n\nThe bug was caused some time around\nhttps://github.com//pull/210893 where support for the\nlanding pages of panel opener nav items (\"four squares\" design) was\nremoved. During that removal, the behavior changed when the side nav is\ncollapsed: panel opener items need to open as an accordion in that\nscenario.\n\n### Other changes\n- Initially, I thought the root cause was due to styling, so I cleaned\nup styles in `navigation_panel.tsx` and refactored them to use\n`@emotion/react`.\n\n### Release Note\n\nFixed a bug with the solution nav submenu items when the nav is\ncollapsed.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- ~~[ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~\n- ~~[ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~~\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- ~~[ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~\n- ~~[ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~~\n- ~~[ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"d85f216c8749525cb360649a641754f343800f69"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/228067","number":228067,"state":"OPEN"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227705","number":227705,"mergeCommit":{"message":"[SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed (#227705)\n\nCloses https://github.com/elastic/kibana/issues/227616\n\nThe bug was caused some time around\nhttps://github.com//pull/210893 where support for the\nlanding pages of panel opener nav items (\"four squares\" design) was\nremoved. During that removal, the behavior changed when the side nav is\ncollapsed: panel opener items need to open as an accordion in that\nscenario.\n\n### Other changes\n- Initially, I thought the root cause was due to styling, so I cleaned\nup styles in `navigation_panel.tsx` and refactored them to use\n`@emotion/react`.\n\n### Release Note\n\nFixed a bug with the solution nav submenu items when the nav is\ncollapsed.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- ~~[ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~\n- ~~[ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~~\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- ~~[ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~\n- ~~[ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~~\n- ~~[ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"d85f216c8749525cb360649a641754f343800f69"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 16, 2025
…ners when side nav is collapsed (#227705) (#228067) # Backport This will backport the following commits from `main` to `9.1`: - [[SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed (#227705)](#227705) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-15T16:42:08Z","message":"[SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed (#227705)\n\nCloses https://github.com/elastic/kibana/issues/227616\n\nThe bug was caused some time around\nhttps://github.com//pull/210893 where support for the\nlanding pages of panel opener nav items (\"four squares\" design) was\nremoved. During that removal, the behavior changed when the side nav is\ncollapsed: panel opener items need to open as an accordion in that\nscenario.\n\n### Other changes\n- Initially, I thought the root cause was due to styling, so I cleaned\nup styles in `navigation_panel.tsx` and refactored them to use\n`@emotion/react`.\n\n### Release Note\n\nFixed a bug with the solution nav submenu items when the nav is\ncollapsed.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- ~~[ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~\n- ~~[ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~~\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- ~~[ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~\n- ~~[ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~~\n- ~~[ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"d85f216c8749525cb360649a641754f343800f69","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","ci:cloud-deploy","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed","number":227705,"url":"https://github.com/elastic/kibana/pull/227705","mergeCommit":{"message":"[SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed (#227705)\n\nCloses https://github.com/elastic/kibana/issues/227616\n\nThe bug was caused some time around\nhttps://github.com//pull/210893 where support for the\nlanding pages of panel opener nav items (\"four squares\" design) was\nremoved. During that removal, the behavior changed when the side nav is\ncollapsed: panel opener items need to open as an accordion in that\nscenario.\n\n### Other changes\n- Initially, I thought the root cause was due to styling, so I cleaned\nup styles in `navigation_panel.tsx` and refactored them to use\n`@emotion/react`.\n\n### Release Note\n\nFixed a bug with the solution nav submenu items when the nav is\ncollapsed.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- ~~[ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~\n- ~~[ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~~\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- ~~[ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~\n- ~~[ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~~\n- ~~[ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"d85f216c8749525cb360649a641754f343800f69"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227705","number":227705,"mergeCommit":{"message":"[SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed (#227705)\n\nCloses https://github.com/elastic/kibana/issues/227616\n\nThe bug was caused some time around\nhttps://github.com//pull/210893 where support for the\nlanding pages of panel opener nav items (\"four squares\" design) was\nremoved. During that removal, the behavior changed when the side nav is\ncollapsed: panel opener items need to open as an accordion in that\nscenario.\n\n### Other changes\n- Initially, I thought the root cause was due to styling, so I cleaned\nup styles in `navigation_panel.tsx` and refactored them to use\n`@emotion/react`.\n\n### Release Note\n\nFixed a bug with the solution nav submenu items when the nav is\ncollapsed.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- ~~[ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~\n- ~~[ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~~\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- ~~[ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~\n- ~~[ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~~\n- ~~[ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"d85f216c8749525cb360649a641754f343800f69"}}]}] BACKPORT--> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
kibanamachine
removed
the
backport missing
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
…hen side nav is collapsed (elastic#227705) Closes elastic#227616 The bug was caused some time around elastic#210893 where support for the landing pages of panel opener nav items ("four squares" design) was removed. During that removal, the behavior changed when the side nav is collapsed: panel opener items need to open as an accordion in that scenario. ### Other changes - Initially, I thought the root cause was due to styling, so I cleaned up styles in `navigation_panel.tsx` and refactored them to use `@emotion/react`. ### Release Note Fixed a bug with the solution nav submenu items when the nav is collapsed. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…hen side nav is collapsed (elastic#227705) Closes elastic#227616 The bug was caused some time around elastic#210893 where support for the landing pages of panel opener nav items ("four squares" design) was removed. During that removal, the behavior changed when the side nav is collapsed: panel opener items need to open as an accordion in that scenario. ### Other changes - Initially, I thought the root cause was due to styling, so I cleaned up styles in `navigation_panel.tsx` and refactored them to use `@emotion/react`. ### Release Note Fixed a bug with the solution nav submenu items when the nav is collapsed. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227616
The bug was caused some time around #210893 where support for the landing pages of panel opener nav items ("four squares" design) was removed. During that removal, the behavior changed when the side nav is collapsed: panel opener items need to open as an accordion in that scenario.
Other changes
navigation_panel.tsxand refactored them to use@emotion/react.Release Note
Fixed a bug with the solution nav submenu items when the nav is collapsed.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.[ ] Flaky Test Runner was used on any tests changedrelease_note:*label is applied per the guidelinesbackport:*labels.