Skip to content

Comments

[9.1] [ES|QL] Fixes wrong validation on expressions between aggregations (#227989)#228128

Merged
stratoula merged 2 commits intoelastic:9.1from
stratoula:backport/9.1/pr-227989
Jul 16, 2025
Merged

[9.1] [ES|QL] Fixes wrong validation on expressions between aggregations (#227989)#228128
stratoula merged 2 commits intoelastic:9.1from
stratoula:backport/9.1/pr-227989

Conversation

@stratoula
Copy link
Contributor

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…lastic#227989)

## Summary

Fixes wrong client side validation error in expressions between
aggregations

Before
<img width="3196" height="542" alt="image"
src="https://github.com/user-attachments/assets/512f0b2c-b64f-40c9-aa08-645f3f312bc6"
/>

After
<img width="1598" height="186" alt="image"
src="https://github.com/user-attachments/assets/d47b1888-4ae9-4f9c-b474-383dede4b3d0"
/>

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 3c027eb)

# Conflicts:
#	src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/stats/utils.ts
#	src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/stats/validate.test.ts
@stratoula stratoula requested a review from kibanamachine as a code owner July 16, 2025 05:19
@stratoula stratoula added the backport This PR is a backport of another PR label Jul 16, 2025
@stratoula stratoula enabled auto-merge (squash) July 16, 2025 05:19
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.7MB 3.7MB +37.0B

@stratoula stratoula disabled auto-merge July 16, 2025 07:56
@stratoula stratoula merged commit f23cae1 into elastic:9.1 Jul 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants