Skip to content

[ES|QL] Fixes wrong validation on expressions between aggregations #227989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stratoula merged 1 commit into from
Jul 16, 2025
Merged

[ES|QL] Fixes wrong validation on expressions between aggregations #227989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/stats/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,15 @@ export function checkFunctionContent(arg: ESQLFunction) {
if (isAggregation(arg) || isFunctionOperatorParam(arg)) {
return true;
}
return (arg as ESQLFunction).args.every(
(subArg): boolean =>
return (arg as ESQLFunction).args.every((subArg): boolean => {
// Differentiate between array and non-array arguments
if (Array.isArray(subArg)) {
return subArg.every((item) => checkFunctionContent(item as ESQLFunction));
}
return (
isLiteral(subArg) ||
isAggregation(subArg) ||
(isNotAnAggregation(subArg) ? checkFunctionContent(subArg) : false)
);
);
});
}
5 changes: 5 additions & 0 deletions ...atform/packages/shared/kbn-esql-ast/src/commands_registry/commands/stats/validate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ describe('STATS Validation', () => {
statsExpectErrors('from a_index | STATS abs( doubleField + sum( doubleField )) ', [
'Cannot combine aggregation and non-aggregation values in [STATS], found [abs(doubleField+sum(doubleField))]',
]);
// This is a valid expression as it is an operation on two aggregation functions
statsExpectErrors(
'from a_index | STATS sum(doubleField) / (min(doubleField) + max(doubleField)) ',
[]
);
});

test('errors on each aggregation field, which does not contain at least one agg function', () => {
Expand Down