[Alerts table] Unskipped pagination test#227486
Merged
cesco-f merged 3 commits intoelastic:mainfrom Jul 15, 2025
Merged
Conversation
cesco-f
added
release_note:skip
botelastic
bot
added
the
ci:project-deploy-observability
github-actions
bot
added
the
author:obs-ux-management
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
cesco-f
force-pushed
the
alerts-table-test
branch
from
bbaa353 to
ce7909b
Compare
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#8596[❌] x-pack/test/observability_functional/with_rac_write.config.ts: 25/50 tests passed. |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#8599[✅] x-pack/test/observability_functional/with_rac_write.config.ts: 25/25 tests passed. |
cesco-f
force-pushed
the
alerts-table-test
branch
from
ce7909b to
b4b5e56
Compare
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#8602[❌] x-pack/test/observability_functional/with_rac_write.config.ts: 0/25 tests passed. |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#8606[✅] x-pack/test/observability_functional/with_rac_write.config.ts: 25/25 tests passed. |
cesco-f
force-pushed
the
alerts-table-test
branch
from
43aec26 to
cbd2cf5
Compare
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16285148073 |
Contributor
cesco-f
added a commit
to cesco-f/kibana
that referenced
this pull request
Jul 15, 2025
This PR closes elastic#120440 . This test was skipped a long time ago and several things changed since then. The main thing is that the container that shows the alerts changed, now it's a component that shows a `data-test-subj` equal to `internalAlertsPageLoading` when loading and `alertsTableIsLoaded` when the alerts have been loaded. The component shown when alerts are being loaded is not always shown, probably for some caching, so I removed the `alertDataIsBeingLodaded` check. I also had to add a function to include the `recovered` alerts because the `active` alerts in the test data are only 10 and the pagination cannot work with just 10 alerts. (cherry picked from commit ca9a70b) # Conflicts: # x-pack/solutions/observability/test/functional/services/observability/alerts/common.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Jul 15, 2025
cesco-f
added a commit
that referenced
this pull request
Jul 16, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[Alerts table] Unskipped pagination test (#227486)](#227486) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Francesco Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-07-15T05:45:30Z","message":"[Alerts table] Unskipped pagination test (#227486)\n\nThis PR closes #120440 .\n\nThis test was skipped a long time ago and several things changed since\nthen.\nThe main thing is that the container that shows the alerts changed, now\nit's a component that shows a `data-test-subj` equal to\n`internalAlertsPageLoading` when loading and `alertsTableIsLoaded` when\nthe alerts have been loaded.\n\nThe component shown when alerts are being loaded is not always shown,\nprobably for some caching, so I removed the `alertDataIsBeingLodaded`\ncheck.\n\nI also had to add a function to include the `recovered` alerts because\nthe `active` alerts in the test data are only 10 and the pagination\ncannot work with just 10 alerts.","sha":"ca9a70b7040399cb6a2433ff77b6e3d5fffc13cf","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.2.0"],"title":"[Alerts table] Unskipped pagination test","number":227486,"url":"https://github.com/elastic/kibana/pull/227486","mergeCommit":{"message":"[Alerts table] Unskipped pagination test (#227486)\n\nThis PR closes #120440 .\n\nThis test was skipped a long time ago and several things changed since\nthen.\nThe main thing is that the container that shows the alerts changed, now\nit's a component that shows a `data-test-subj` equal to\n`internalAlertsPageLoading` when loading and `alertsTableIsLoaded` when\nthe alerts have been loaded.\n\nThe component shown when alerts are being loaded is not always shown,\nprobably for some caching, so I removed the `alertDataIsBeingLodaded`\ncheck.\n\nI also had to add a function to include the `recovered` alerts because\nthe `active` alerts in the test data are only 10 and the pagination\ncannot work with just 10 alerts.","sha":"ca9a70b7040399cb6a2433ff77b6e3d5fffc13cf"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227486","number":227486,"mergeCommit":{"message":"[Alerts table] Unskipped pagination test (#227486)\n\nThis PR closes #120440 .\n\nThis test was skipped a long time ago and several things changed since\nthen.\nThe main thing is that the container that shows the alerts changed, now\nit's a component that shows a `data-test-subj` equal to\n`internalAlertsPageLoading` when loading and `alertsTableIsLoaded` when\nthe alerts have been loaded.\n\nThe component shown when alerts are being loaded is not always shown,\nprobably for some caching, so I removed the `alertDataIsBeingLodaded`\ncheck.\n\nI also had to add a function to include the `recovered` alerts because\nthe `active` alerts in the test data are only 10 and the pagination\ncannot work with just 10 alerts.","sha":"ca9a70b7040399cb6a2433ff77b6e3d5fffc13cf"}}]}] BACKPORT-->
cesco-f
added a commit
that referenced
this pull request
Jul 16, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Alerts table] Unskipped pagination test (#227486)](#227486) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Francesco Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-07-15T05:45:30Z","message":"[Alerts table] Unskipped pagination test (#227486)\n\nThis PR closes #120440 .\n\nThis test was skipped a long time ago and several things changed since\nthen.\nThe main thing is that the container that shows the alerts changed, now\nit's a component that shows a `data-test-subj` equal to\n`internalAlertsPageLoading` when loading and `alertsTableIsLoaded` when\nthe alerts have been loaded.\n\nThe component shown when alerts are being loaded is not always shown,\nprobably for some caching, so I removed the `alertDataIsBeingLodaded`\ncheck.\n\nI also had to add a function to include the `recovered` alerts because\nthe `active` alerts in the test data are only 10 and the pagination\ncannot work with just 10 alerts.","sha":"ca9a70b7040399cb6a2433ff77b6e3d5fffc13cf","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.2.0"],"title":"[Alerts table] Unskipped pagination test","number":227486,"url":"https://github.com/elastic/kibana/pull/227486","mergeCommit":{"message":"[Alerts table] Unskipped pagination test (#227486)\n\nThis PR closes #120440 .\n\nThis test was skipped a long time ago and several things changed since\nthen.\nThe main thing is that the container that shows the alerts changed, now\nit's a component that shows a `data-test-subj` equal to\n`internalAlertsPageLoading` when loading and `alertsTableIsLoaded` when\nthe alerts have been loaded.\n\nThe component shown when alerts are being loaded is not always shown,\nprobably for some caching, so I removed the `alertDataIsBeingLodaded`\ncheck.\n\nI also had to add a function to include the `recovered` alerts because\nthe `active` alerts in the test data are only 10 and the pagination\ncannot work with just 10 alerts.","sha":"ca9a70b7040399cb6a2433ff77b6e3d5fffc13cf"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227486","number":227486,"mergeCommit":{"message":"[Alerts table] Unskipped pagination test (#227486)\n\nThis PR closes #120440 .\n\nThis test was skipped a long time ago and several things changed since\nthen.\nThe main thing is that the container that shows the alerts changed, now\nit's a component that shows a `data-test-subj` equal to\n`internalAlertsPageLoading` when loading and `alertsTableIsLoaded` when\nthe alerts have been loaded.\n\nThe component shown when alerts are being loaded is not always shown,\nprobably for some caching, so I removed the `alertDataIsBeingLodaded`\ncheck.\n\nI also had to add a function to include the `recovered` alerts because\nthe `active` alerts in the test data are only 10 and the pagination\ncannot work with just 10 alerts.","sha":"ca9a70b7040399cb6a2433ff77b6e3d5fffc13cf"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
This PR closes elastic#120440 . This test was skipped a long time ago and several things changed since then. The main thing is that the container that shows the alerts changed, now it's a component that shows a `data-test-subj` equal to `internalAlertsPageLoading` when loading and `alertsTableIsLoaded` when the alerts have been loaded. The component shown when alerts are being loaded is not always shown, probably for some caching, so I removed the `alertDataIsBeingLodaded` check. I also had to add a function to include the `recovered` alerts because the `active` alerts in the test data are only 10 and the pagination cannot work with just 10 alerts.
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
This PR closes elastic#120440 . This test was skipped a long time ago and several things changed since then. The main thing is that the container that shows the alerts changed, now it's a component that shows a `data-test-subj` equal to `internalAlertsPageLoading` when loading and `alertsTableIsLoaded` when the alerts have been loaded. The component shown when alerts are being loaded is not always shown, probably for some caching, so I removed the `alertDataIsBeingLodaded` check. I also had to add a function to include the `recovered` alerts because the `active` alerts in the test data are only 10 and the pagination cannot work with just 10 alerts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #120440 .
This test was skipped a long time ago and several things changed since then.
The main thing is that the container that shows the alerts changed, now it's a component that shows a
data-test-subjequal tointernalAlertsPageLoadingwhen loading andalertsTableIsLoadedwhen the alerts have been loaded.The component shown when alerts are being loaded is not always shown, probably for some caching, so I removed the
alertDataIsBeingLodadedcheck.I also had to add a function to include the
recoveredalerts because theactivealerts in the test data are only 10 and the pagination cannot work with just 10 alerts.