Skip to content

Comments

(Accessibility) Dashboard controls should be grouped as a labelled list#227633

Merged
mbondyra merged 3 commits intoelastic:mainfrom
mbondyra:a11y/controls
Jul 12, 2025
Merged

(Accessibility) Dashboard controls should be grouped as a labelled list#227633
mbondyra merged 3 commits intoelastic:mainfrom
mbondyra:a11y/controls

Conversation

@mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Jul 11, 2025

Summary

Fixes #154561
Screenshot 2025-07-11 at 14 06 34

@mbondyra mbondyra requested a review from a team as a code owner July 11, 2025 12:09
@mbondyra mbondyra added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// backport:version Backport to applied version labels v9.1.0 v8.19.0 v9.2.0 labels Jul 11, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM
code review only

@mbondyra mbondyra enabled auto-merge (squash) July 12, 2025 14:53
@mbondyra mbondyra merged commit b3a923e into elastic:main Jul 12, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16239866224

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 477.7KB 477.7KB +30.0B

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 12, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 12, 2025
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 15, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @mbondyra

kibanamachine added a commit that referenced this pull request Jul 16, 2025
…lled list (#227633) (#227744)

# Backport

This will backport the following commits from `main` to `8.19`:
- [(Accessibility) Dashboard controls should be grouped as a labelled
list (#227633)](#227633)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-12T16:22:22Z","message":"(Accessibility)
Dashboard controls should be grouped as a labelled list (#227633)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/154561\n<img
width=\"1212\" height=\"362\" alt=\"Screenshot 2025-07-11 at 14 06
34\"\nsrc=\"https://github.com/user-attachments/assets/3362f7bc-6b4e-4ed8-8820-6f546af38aa7\"\n/>","sha":"b3a923e61112e915a74d5a06ccf40de83ae3321d","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"(Accessibility)
Dashboard controls should be grouped as a labelled
list","number":227633,"url":"https://github.com/elastic/kibana/pull/227633","mergeCommit":{"message":"(Accessibility)
Dashboard controls should be grouped as a labelled list (#227633)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/154561\n<img
width=\"1212\" height=\"362\" alt=\"Screenshot 2025-07-11 at 14 06
34\"\nsrc=\"https://github.com/user-attachments/assets/3362f7bc-6b4e-4ed8-8820-6f546af38aa7\"\n/>","sha":"b3a923e61112e915a74d5a06ccf40de83ae3321d"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227633","number":227633,"mergeCommit":{"message":"(Accessibility)
Dashboard controls should be grouped as a labelled list (#227633)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/154561\n<img
width=\"1212\" height=\"362\" alt=\"Screenshot 2025-07-11 at 14 06
34\"\nsrc=\"https://github.com/user-attachments/assets/3362f7bc-6b4e-4ed8-8820-6f546af38aa7\"\n/>","sha":"b3a923e61112e915a74d5a06ccf40de83ae3321d"}}]}]
BACKPORT-->

---------

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 16, 2025
…led list (#227633) (#227745)

# Backport

This will backport the following commits from `main` to `9.1`:
- [(Accessibility) Dashboard controls should be grouped as a labelled
list (#227633)](#227633)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-12T16:22:22Z","message":"(Accessibility)
Dashboard controls should be grouped as a labelled list (#227633)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/154561\n<img
width=\"1212\" height=\"362\" alt=\"Screenshot 2025-07-11 at 14 06
34\"\nsrc=\"https://github.com/user-attachments/assets/3362f7bc-6b4e-4ed8-8820-6f546af38aa7\"\n/>","sha":"b3a923e61112e915a74d5a06ccf40de83ae3321d","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"(Accessibility)
Dashboard controls should be grouped as a labelled
list","number":227633,"url":"https://github.com/elastic/kibana/pull/227633","mergeCommit":{"message":"(Accessibility)
Dashboard controls should be grouped as a labelled list (#227633)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/154561\n<img
width=\"1212\" height=\"362\" alt=\"Screenshot 2025-07-11 at 14 06
34\"\nsrc=\"https://github.com/user-attachments/assets/3362f7bc-6b4e-4ed8-8820-6f546af38aa7\"\n/>","sha":"b3a923e61112e915a74d5a06ccf40de83ae3321d"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227633","number":227633,"mergeCommit":{"message":"(Accessibility)
Dashboard controls should be grouped as a labelled list (#227633)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/154561\n<img
width=\"1212\" height=\"362\" alt=\"Screenshot 2025-07-11 at 14 06
34\"\nsrc=\"https://github.com/user-attachments/assets/3362f7bc-6b4e-4ed8-8820-6f546af38aa7\"\n/>","sha":"b3a923e61112e915a74d5a06ccf40de83ae3321d"}}]}]
BACKPORT-->

---------

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 16, 2025
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.19.0 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Accessibility) Dashboard controls should be grouped as a labelled list

4 participants